[release-4.1] Bug 1754681: do not force skip tls verify to true on image source injection #112

openshift-cherrypick-robot · 2019-11-08T20:10:07Z

This is an automated cherry-pick of #110

/assign gabemontero

openshift-ci-robot · 2019-11-08T20:10:10Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1755140, which is invalid:

expected the bug to target the "4.1.z" release, but it targets "4.3.0" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.1] Bug 1755140: do not force skip tls verify to true on image source injection

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2019-11-11T20:00:47Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1771053, which is invalid:

expected dependent Bugzilla bug 1754680 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead
expected dependent Bugzilla bug 1755140 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.1] Bug 1771053: do not force skip tls verify to true on image source injection

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gabemontero · 2019-11-18T20:09:44Z

/hold
this pr needs both openshift/origin#24111 and openshift/origin#24130 to merge before e2e-aws-builds will pass

gabemontero · 2019-11-20T18:52:49Z

/retest

gabemontero · 2019-11-20T20:21:08Z

/bugzilla refresh

openshift-ci-robot · 2019-11-20T20:21:12Z

@gabemontero: This pull request references Bugzilla bug 1771053, which is invalid:

expected the bug to be open, but it isn't
expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is CLOSED (DUPLICATE) instead
expected dependent Bugzilla bug 1754680 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2019-11-20T20:24:12Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1754681, which is invalid:

expected dependent Bugzilla bug 1754680 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.1] Bug 1754681: do not force skip tls verify to true on image source injection

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gabemontero · 2019-11-20T20:24:36Z

/hold cancel

gabemontero · 2019-12-01T20:42:28Z

/bugzilla refresh

openshift-ci-robot · 2019-12-01T20:42:32Z

@gabemontero: This pull request references Bugzilla bug 1754681, which is invalid:

expected dependent Bugzilla bug 1754680 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gabemontero · 2019-12-03T14:59:44Z

/bugzilla refresh

openshift-ci-robot · 2019-12-03T14:59:53Z

@gabemontero: This pull request references Bugzilla bug 1754681, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gabemontero · 2019-12-03T15:01:35Z

bump @adambkaplan we now have valid bugzilla

adambkaplan

/lgtm

openshift-ci-robot · 2019-12-03T15:04:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [adambkaplan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

adambkaplan · 2019-12-03T15:05:51Z

Patch manager note - openshift/origin#24130 should merge first.

openshift-ci-robot · 2019-12-06T19:44:42Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1754681 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.1] Bug 1754681: do not force skip tls verify to true on image source injection

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

do not force skip tls verify to true on image source injection

f448ae6

openshift-ci-robot assigned gabemontero Nov 8, 2019

openshift-cherrypick-robot mentioned this pull request Nov 8, 2019

Bug 1755140: do not force skip tls verify to true on image source injection #110

Merged

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 8, 2019

openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 8, 2019

openshift-ci-robot requested review from adambkaplan and coreydaley November 8, 2019 20:11

gabemontero changed the title ~~[release-4.1] Bug 1755140: do not force skip tls verify to true on image source injection~~ [release-4.1] Bug 1771053: do not force skip tls verify to true on image source injection Nov 11, 2019

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2019

gabemontero changed the title ~~[release-4.1] Bug 1771053: do not force skip tls verify to true on image source injection~~ [release-4.1] Bug 1754681: do not force skip tls verify to true on image source injection Nov 20, 2019

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2019

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 3, 2019

adambkaplan approved these changes Dec 3, 2019

View reviewed changes

openshift-ci-robot assigned adambkaplan Dec 3, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2019

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2019

shawn-hurley added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 6, 2019

openshift-merge-robot merged commit abc66f4 into openshift:release-4.1 Dec 6, 2019

[release-4.1] Bug 1754681: do not force skip tls verify to true on image source injection #112

[release-4.1] Bug 1754681: do not force skip tls verify to true on image source injection #112

Uh oh!

Conversation

openshift-cherrypick-robot commented Nov 8, 2019

Uh oh!

openshift-ci-robot commented Nov 8, 2019

Uh oh!

openshift-ci-robot commented Nov 11, 2019

Uh oh!

gabemontero commented Nov 18, 2019

Uh oh!

gabemontero commented Nov 20, 2019

Uh oh!

gabemontero commented Nov 20, 2019

Uh oh!

openshift-ci-robot commented Nov 20, 2019

Uh oh!

openshift-ci-robot commented Nov 20, 2019

Uh oh!

gabemontero commented Nov 20, 2019

Uh oh!

gabemontero commented Dec 1, 2019

Uh oh!

openshift-ci-robot commented Dec 1, 2019

Uh oh!

gabemontero commented Dec 3, 2019

Uh oh!

openshift-ci-robot commented Dec 3, 2019

Uh oh!

gabemontero commented Dec 3, 2019

Uh oh!

adambkaplan left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Dec 3, 2019

Uh oh!

adambkaplan commented Dec 3, 2019

Uh oh!

openshift-ci-robot commented Dec 6, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants