Skip to content

Revert "[release 4.3] Bug 1779282: Use OwnerRefs to clean up SA pull secrets"#78

Closed
smarterclayton wants to merge 1 commit intorelease-4.3from
revert-72-cherry-pick-67-to-release-4.3
Closed

Revert "[release 4.3] Bug 1779282: Use OwnerRefs to clean up SA pull secrets"#78
smarterclayton wants to merge 1 commit intorelease-4.3from
revert-72-cherry-pick-67-to-release-4.3

Conversation

@smarterclayton
Copy link
Copy Markdown
Contributor

Reverts #72

Is possibly the cause of https://bugzilla.redhat.com/show_bug.cgi?id=1785023

/hold

while we triage

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 26, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@smarterclayton: This pull request references Bugzilla bug 1779282, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Revert "[release 4.3] Bug 1779282: Use OwnerRefs to clean up SA pull secrets"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@smarterclayton
Copy link
Copy Markdown
Contributor Author

/retest

@smarterclayton
Copy link
Copy Markdown
Contributor Author

/test e2e-aws

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@smarterclayton: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-builds f0a387c link /test e2e-gcp-builds

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Copy Markdown
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/bugzilla refresh

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@adambkaplan: This pull request references Bugzilla bug 1779282, which is invalid:

  • expected dependent Bugzilla bug 1806792 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/lgtm

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2020
@smarterclayton
Copy link
Copy Markdown
Contributor Author

Real fix is in 4.5 and appears to work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants