Skip to content

[release 4.3] Bug 1779282: Use OwnerRefs to clean up SA pull secrets#72

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.3from
openshift-cherrypick-robot:cherry-pick-67-to-release-4.3
Mar 25, 2020
Merged

[release 4.3] Bug 1779282: Use OwnerRefs to clean up SA pull secrets#72
openshift-merge-robot merged 1 commit intoopenshift:release-4.3from
openshift-cherrypick-robot:cherry-pick-67-to-release-4.3

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot openshift-cherrypick-robot commented Mar 9, 2020

This is an automated cherry-pick of #67

/assign adambkaplan

@adambkaplan
Bug 1765294: Use OwnerRefs to clean up SA pull secrets
a8132d3 
Update the service account pull secret controller to add owner
references to generated pull secrets. This ensures pull secrets are
deleted when the associated token is deleted.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 9, 2020
Merged
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 9, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 9, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1806792, which is invalid:

  • expected the bug to target the "4.3.z" release, but it targets "4.4.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead
  • expected dependent Bugzilla bug 1765294 to target the "4.4.0" release, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.3] [release-4.4] Bug 1806792: Use OwnerRefs to clean up SA pull secrets

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 9, 2020
@adambkaplan
Copy link
Copy Markdown
Contributor

adambkaplan commented Mar 9, 2020

/retitle [release 4.3] Bug 1779282: Use OwnerRefs to clean up SA pull secrets

@openshift-ci-robot openshift-ci-robot changed the title [release-4.3] [release-4.4] Bug 1806792: Use OwnerRefs to clean up SA pull secrets [release 4.3] Bug 1779282: Use OwnerRefs to clean up SA pull secrets Mar 9, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 9, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 9, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1779282, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.3.z) matches configured target release for branch (4.3.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1806792 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1806792 targets the "4.4.0" release, matching the expected (4.4.0) release
  • bug has dependents
Details

In response to this:

[release 4.3] Bug 1779282: Use OwnerRefs to clean up SA pull secrets

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 9, 2020
adambkaplan
adambkaplan approved these changes Mar 9, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/hold

This was verified in 4.4.0 - I'd like to see this soak with GA install/upgrades before merging.

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 9, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 9, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2020
@sdodson
Copy link
Copy Markdown
Member

sdodson commented Mar 11, 2020

@adambkaplan Do you intend to lift the hold by Friday?

@adambkaplan
Copy link
Copy Markdown
Contributor

adambkaplan commented Mar 12, 2020

@sdodson No, I do not. I am holding until 4.4.0 is GA and has verified fast channel updates.

@adambkaplan
Copy link
Copy Markdown
Contributor

adambkaplan commented Mar 24, 2020

/hold cancel

4.4.0 GA has been pushed out another sprint.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2020
@adambkaplan
Copy link
Copy Markdown
Contributor

adambkaplan commented Mar 24, 2020

/retest

@adambkaplan
Copy link
Copy Markdown
Contributor

adambkaplan commented Mar 25, 2020

CI indicates that upgrades from 4.3.z to 4.4 are not falling over due to this issue. We should be good to merge this to the z-stream.

https://openshift-release.svc.ci.openshift.org/#4.4.0-0.ci

@jwforres jwforres added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 25, 2020
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Mar 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit c7c802a into openshift:release-4.3 Mar 25, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 25, 2020

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1779282 has been moved to the MODIFIED state.

Details

In response to this:

[release 4.3] Bug 1779282: Use OwnerRefs to clean up SA pull secrets

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@smarterclayton smarterclayton mentioned this pull request Mar 26, 2020
Closed
@mfojtik mfojtik mentioned this pull request Mar 26, 2020
Closed
@adambkaplan adambkaplan mentioned this pull request Oct 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adambkaplan adambkaplan adambkaplan approved these changes

@bparees bparees Awaiting requested review from bparees

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@adambkaplan adambkaplan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@openshift-cherrypick-robot @openshift-ci-robot @adambkaplan @sdodson @openshift-bot @jwforres @openshift-merge-robot