Skip to content

Revert "tests: disable ResourceQuota e2e test for life of a secret"#24774

Closed
mfojtik wants to merge 1 commit intoopenshift:masterfrom
mfojtik:revert-quota-fix
Closed

Revert "tests: disable ResourceQuota e2e test for life of a secret"#24774
mfojtik wants to merge 1 commit intoopenshift:masterfrom
mfojtik:revert-quota-fix

Conversation

@mfojtik
Copy link
Copy Markdown
Contributor

@mfojtik mfojtik commented Mar 26, 2020

We believe that openshift/openshift-controller-manager#72 and it's parents is the likely cause of the issue, that is reverted in openshift/openshift-controller-manager#80

@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2020
@smarterclayton
Copy link
Copy Markdown
Contributor

As soon as this goes green I'm going to merge it. I wish I had test e2e PR1,PR2, time to go finish writing that.

@openshift-ci-robot
Copy link
Copy Markdown

@mfojtik: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-upgrade af791e9 link /test e2e-gcp-upgrade
ci/prow/e2e-cmd af791e9 link /test e2e-cmd
ci/prow/e2e-gcp af791e9 link /test e2e-gcp
ci/prow/e2e-gcp-builds af791e9 link /test e2e-gcp-builds

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mfojtik mfojtik closed this Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants