Skip to content

Added section on Setting Resource Quota for Extended Resources#13467

Merged
ahardin-rh merged 1 commit intoopenshift:masterfrom
ahardin-rh:quota-for-extended-resources
Jan 30, 2019
Merged

Added section on Setting Resource Quota for Extended Resources#13467
ahardin-rh merged 1 commit intoopenshift:masterfrom
ahardin-rh:quota-for-extended-resources

Conversation

@ahardin-rh
Copy link
Copy Markdown
Contributor

@ahardin-rh ahardin-rh commented Jan 29, 2019 •
edited
Loading

@ahardin-rh ahardin-rh added this to the Next Release milestone Jan 29, 2019
@ahardin-rh ahardin-rh self-assigned this Jan 29, 2019
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 29, 2019
@ahardin-rh ahardin-rh mentioned this pull request Jan 29, 2019
Closed
@openshift-docs-preview-bot
Copy link
Copy Markdown

openshift-docs-preview-bot commented Jan 29, 2019

The preview will be availble shortly at:

@ahardin-rh
Copy link
Copy Markdown
Contributor Author

ahardin-rh commented Jan 29, 2019

@jeremyeder PTAL

@jeremyeder
Copy link
Copy Markdown
Contributor

jeremyeder commented Jan 29, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2019
@jeremyeder
Copy link
Copy Markdown
Contributor

jeremyeder commented Jan 29, 2019

this has the label branch/enterprise-3.11 but it is also valid for 4.0.

@ahardin-rh
Copy link
Copy Markdown
Contributor Author

ahardin-rh commented Jan 29, 2019

@jeremyeder Thanks! I will open a new PR to add this content to 4.0 docs.

@ahardin-rh
Copy link
Copy Markdown
Contributor Author

ahardin-rh commented Jan 29, 2019

@openshift/team-documentation Please peer review

@ahardin-rh ahardin-rh added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 29, 2019
@ahardin-rh
Copy link
Copy Markdown
Contributor Author

ahardin-rh commented Jan 29, 2019

@xingxingxia Can you please provide a QE review?

@ahardin-rh
Copy link
Copy Markdown
Contributor Author

ahardin-rh commented Jan 29, 2019

Note to self 🗒️ Add this content to this WIP PR: #13470

@ahardin-rh
Copy link
Copy Markdown
Contributor Author

ahardin-rh commented Jan 29, 2019

Opened adellape#10 to add content into 4.0

@xingxingxia
Copy link
Copy Markdown
Contributor

xingxingxia commented Jan 30, 2019

/lgtm

mburke5678
mburke5678 reviewed Jan 30, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@mburke5678 mburke5678 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahardin-rh one nit. Otherwise LGTM.

Comment thread admin_guide/quota.adoc Outdated
@ahardin-rh ahardin-rh force-pushed the quota-for-extended-resources branch from 2574f3f to 7fa4059 Compare January 30, 2019 16:29
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2019
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 30, 2019

New changes are detected. LGTM label has been removed.

@ahardin-rh ahardin-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 30, 2019
@ahardin-rh ahardin-rh merged commit 6b213f6 into openshift:master Jan 30, 2019
@ahardin-rh
Copy link
Copy Markdown
Contributor Author

ahardin-rh commented Jan 30, 2019

/cherrypick enterprise-3.11

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 30, 2019
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Jan 30, 2019

@ahardin-rh: new pull request created: #13476

Details

In response to this:

/cherrypick enterprise-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mburke5678 mburke5678 mburke5678 left review comments

Assignees

@jeremyeder jeremyeder

@xingxingxia xingxingxia

@ahardin-rh ahardin-rh

Labels

branch/enterprise-3.11 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

7 participants

@ahardin-rh @openshift-docs-preview-bot @jeremyeder @xingxingxia @openshift-ci-robot @openshift-cherrypick-robot @mburke5678