Skip to content

Add quota docs to v4#13470

Merged
adellape merged 1 commit intoopenshift:enterprise-4.0from
adellape:quotas
Feb 5, 2019
Merged

Add quota docs to v4#13470
adellape merged 1 commit intoopenshift:enterprise-4.0from
adellape:quotas

Conversation

@adellape adellape added this to the Future Release milestone Jan 29, 2019
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 29, 2019
@adellape adellape force-pushed the quotas branch 3 times, most recently from a0e89ef to 99ba0f2 Compare February 5, 2019 20:13
@adellape
Copy link
Copy Markdown
Contributor Author

adellape commented Feb 5, 2019

@ahardin-rh Grabbed your new module from adellape@c328e5a and manually added it in, cuz I changed some file names around.

@adellape adellape force-pushed the quotas branch 2 times, most recently from 071dd54 to 3ef4243 Compare February 5, 2019 20:36
@adellape adellape changed the title [WIP] Add quota docs to v4 Add quota docs to v4 Feb 5, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 5, 2019
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeremyeder What is an "extended resource" exactly? I would like to include a brief definition here for clarity's sake. 🤔

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/may/might (per IBM Style Guide)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify that the

@openshift-docs-preview-bot
Copy link
Copy Markdown

The preview will be availble shortly at:

@ahardin-rh ahardin-rh added the peer-review-done Signifies that the peer review team has reviewed this PR label Feb 5, 2019
Copy link
Copy Markdown
Contributor

@ahardin-rh ahardin-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adellape Just a few minor comments from me 👍

Comment thread modules/quotas-enforcement.adoc Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/stats/statistics

Comment thread modules/quotas-requests-vs-limits.adoc Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/may/might

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/may/might

Comment thread modules/quotas-resources-managed.adoc Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/may/can

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In 4.0, we're now using backticks for file names

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

`BestEffort`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

`compute-resources-long-running.yaml`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/may/can

@adellape
Copy link
Copy Markdown
Contributor Author

adellape commented Feb 5, 2019

@ahardin-rh Thanks! 💥

@adellape adellape merged commit 6aacf80 into openshift:enterprise-4.0 Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.1 peer-review-done Signifies that the peer review team has reviewed this PR size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants