bug 1715118 updating parameter value#15059
bug 1715118 updating parameter value#15059kalexand-rh merged 1 commit intoopenshift:enterprise-4.1from
Conversation
openshift-ci-robot
added
the
size/S
There was a problem hiding this comment.
zone needs to be changed to region
I don't know what <dns_stack> is. There's no bit in the documentation describing what should go in this position. I can guess from what actually gets deployed is it's --RegisterNlbIpTargets-
This makes the example look obnoxious ...
"ParameterValue": "arn:aws:lambda:<region>:<account_number>:function:<infrastructure name>-<stack name>-RegisterNlbIpTargets-<random hash>"
It's verbose but clearer than before. The excessive length is because the resource names are too long. and doesn't need to be in the resource name. The random hash is going to prevent name conflict. They're all tagged correctly so well searchable.
AWS uses the following generic examples for Lamda ...
arn:aws:lambda:region:account-id:function:function-name
arn:aws:lambda:region:account-id:function:function-name:alias-name
arn:aws:lambda:region:account-id:function:function-name:version
arn:aws:lambda:region:account-id:event-source-mappings:event-source-mapping-id
This is taken from here. Then web browser search for AWS Lambda
There was a problem hiding this comment.
@mazzystr, I'm making some updates based on you feedback. Thanks! Will you PTAL?
openshift-ci-robot
added
size/M
|
LGTM! Thank you! |
|
Thanks Chris! Merging. |
| }, | ||
| { | ||
| "ParameterKey": "WorkerSubnet", <5> | ||
| "ParameterValue": "yes" <6> |
There was a problem hiding this comment.
Sorry ... found another problem. This parameter key should be called PrivateSubnet. The Value should be sg- string. The parameter should be modified in the template yaml also @wking
Since there is only one subnet parameter for workers nodes how do I span subnets across availability zones?
Because we can no longer use "UPI" in customer-facing documentation and the CloudFormation templates in /installer are published in /openshift-docs, I want to change the source templates instead of having to always reproduce the fix in the docs repo. I'm making a few other style and changes to the parameter descriptions. Per a comment on a docs PR (openshift/openshift-docs#15059), the subnet type for the worker CloudFormation template needs to change to PrivateSubnet from WorkerSubnet. Trevor clarified that the subnet in the worker does not need to be private. s/PrivateSubnet/Subnet in just that CloudFormation Template.
4 participants
https://bugzilla.redhat.com/show_bug.cgi?id=1715118
@mazzystr, PTAL?