Skip to content

bug 1715118 updating parameter value #15059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kalexand-rh merged 1 commit into from
May 30, 2019
Merged

bug 1715118 updating parameter value #15059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions modules/installation-creating-aws-bootstrap.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,27 +78,27 @@ requires:
[
{
"ParameterKey": "InfrastructureName", <1>
"ParameterValue": "mycluster-vw9j6" <2>
"ParameterValue": "mycluster-<random_string>" <2>
},
{
"ParameterKey": "RhcosAmi", <3>
"ParameterValue": "ami-07f604c5f18a1e7a9" <4>
"ParameterValue": "ami-<random_string>" <4>
},
{
"ParameterKey": "AllowedBootstrapSshCidr", <5>
"ParameterValue": "0.0.0.0/0" <6>
},
{
"ParameterKey": "PublicSubnet", <7>
"ParameterValue": "subnet-09c2adf329727bc59" <8>
"ParameterValue": "subnet-<random_string>" <8>
},
{
"ParameterKey": "MasterSecurityGroupId", <9>
"ParameterValue": "sg-0a53cd3337c15a2ee" <10>
"ParameterValue": "sg-<random_string>" <10>
},
{
"ParameterKey": "VpcId", <11>
"ParameterValue": "vpc-055h956b1e6572be9" <12>
"ParameterValue": "vpc-<random_string>" <12>
},
{
"ParameterKey": "BootstrapIgnitionLocation", <13>
Expand All @@ -110,19 +110,19 @@ requires:
},
{
"ParameterKey": "RegisterNlbIpTargetsLambdaArn", <17>
"ParameterValue": "arn:aws:lambda:<zone>:269733483066:function:<dns_stack>-RegisterNlbIpTargets-NHEKB9IHN5XZ" <18>
"ParameterValue": "arn:aws:lambda:<region>:<account_number>:function:<dns_stack_name>-RegisterNlbIpTargets-<random_string>" <18>
},
{
"ParameterKey": "ExternalApiTargetGroupArn", <19>
"ParameterValue": "arn:aws:elasticloadbalancing:<zone>:269733383066:targetgroup/<dns_stack>-Exter-D374J8IQ3K03/b26760f600ff322e" <20>
"ParameterValue": "arn:aws:elasticloadbalancing:<region>:<account_number>:targetgroup/<dns_stack_name>-Exter-<random_string>" <20>
},
{
"ParameterKey": "InternalApiTargetGroupArn", <21>
"ParameterValue": "arn:aws:elasticloadbalancing:<zone>:269733383066:targetgroup/<dns_stack>-Inter-1Q3IAOSC8ZNNM/8e85701acf15632d" <22>
"ParameterValue": "arn:aws:elasticloadbalancing:<region>:<account_number>:targetgroup/<dns_stack_name>-Inter-<random_string>" <22>
},
{
"ParameterKey": "InternalServiceTargetGroupArn", <23>
"ParameterValue": "arn:aws:elasticloadbalancing:<zone>:269733383066:targetgroup/<dns_stack>-Inter-1INRIWR8L3627/4cd9e764bb418f47" <24>
"ParameterValue": "arn:aws:elasticloadbalancing:<region>:<account_number>:targetgroup/<dns_stack_name>-Inter-<random_string>" <24>
}
]

Expand Down
24 changes: 12 additions & 12 deletions modules/installation-creating-aws-control-plane.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,39 +36,39 @@ requires:
[
{
"ParameterKey": "InfrastructureName", <1>
"ParameterValue": "mycluster-vw9j6" <2>
"ParameterValue": "mycluster-<random_string>" <2>
},
{
"ParameterKey": "RhcosAmi", <3>
"ParameterValue": "ami-07f604c5f18a1e7a9" <4>
"ParameterValue": "ami-<random_string>" <4>
},
{
"ParameterKey": "AutoRegisterDNS", <5>
"ParameterValue": "yes" <6>
},
{
"ParameterKey": "PrivateHostedZoneId", <7>
"ParameterValue": "ZU8NEZOFWCCYZ" <8>
"ParameterValue": "<random_string>" <8>
},
{
"ParameterKey": "PrivateHostedZoneName", <9>
"ParameterValue": "mycluster.example.com" <10>
},
{
"ParameterKey": "Master0Subnet", <11>
"ParameterValue": "subnet-0dfe1c9412a54d352" <12>
"ParameterValue": "subnet-<random_string>" <12>
},
{
"ParameterKey": "Master1Subnet", <11>
"ParameterValue": "subnet-0dfe1c9412a54d352" <12>
"ParameterValue": "subnet-<random_string>" <12>
},
{
"ParameterKey": "Master2Subnet", <11>
"ParameterValue": "subnet-0dfe1c9412a54d352" <12>
"ParameterValue": "subnet-<random_string>" <12>
},
{
"ParameterKey": "MasterSecurityGroupId", <13>
"ParameterValue": "sg-0a53cd1337f15u2ee" <14>
"ParameterValue": "sg-<random_string>" <14>
},
{
"ParameterKey": "IgnitionLocation", <15>
Expand All @@ -80,7 +80,7 @@ requires:
},
{
"ParameterKey": "MasterInstanceProfileName", <19>
"ParameterValue": "<roles_stack>-MasterInstanceProfile-1HCV65K4PMWCMN" <20>
"ParameterValue": "<roles_stack>-MasterInstanceProfile-<random_string>" <20>
},
{
"ParameterKey": "MasterInstanceType", <21>
Expand All @@ -92,19 +92,19 @@ requires:
},
{
"ParameterKey": "RegisterNlbIpTargetsLambdaArn", <25>
"ParameterValue": "arn:aws:lambda:<zone>:269733483066:function:<dns_stack>-RegisterNlbIpTargets-NHEKB9IHN5XZ" <26>
"ParameterValue": "arn:aws:lambda:<region>:<account_number>:function:<dns_stack_name>-RegisterNlbIpTargets-<random_string>" <26>
},
{
"ParameterKey": "ExternalApiTargetGroupArn", <27>
"ParameterValue": "arn:aws:elasticloadbalancing:<zone>:269733383066:targetgroup/<dns_stack>-Exter-D374J8IQ3K03/b26760f600ff322e" <28>
"ParameterValue": "arn:aws:elasticloadbalancing:<region>:<account_number>:targetgroup/<dns_stack_name>-Exter-<random_string>" <28>
},
{
"ParameterKey": "InternalApiTargetGroupArn", <29>
"ParameterValue": "arn:aws:elasticloadbalancing:<zone>:269733383066:targetgroup/<dns_stack>-Inter-1Q3IAOSC8ZNNM/8e85701acf15632d" <30>
"ParameterValue": "arn:aws:elasticloadbalancing:<region>:<account_number>:targetgroup/<dns_stack_name>-Inter-<random_string>" <30>
},
{
"ParameterKey": "InternalServiceTargetGroupArn", <31>
"ParameterValue": "arn:aws:elasticloadbalancing:<zone>:269733383066:targetgroup/<dns_stack>-Inter-1INRIWR8L3627/4cd9e764bb418f47" <32>
"ParameterValue": "arn:aws:elasticloadbalancing:<region>:<account_number>:targetgroup/<dns_stack_name>-Inter-<random_string>" <32>
}
]
----
Expand Down
10 changes: 5 additions & 5 deletions modules/installation-creating-aws-dns.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,27 +57,27 @@ requires:
},
{
"ParameterKey": "InfrastructureName", <3>
"ParameterValue": "mycluster-vw9j6" <4>
"ParameterValue": "mycluster-<random_string>" <4>
},
{
"ParameterKey": "HostedZoneId", <5>
"ParameterValue": "Z21IXYZABCZ2A4" <6>
"ParameterValue": "<random_string>" <6>
},
{
"ParameterKey": "HostedZoneName", <7>
"ParameterValue": "example.com" <8>
},
{
"ParameterKey": "PublicSubnets", <9>
"ParameterValue": "subnet-09c2adf329727bc59" <10>
"ParameterValue": "subnet-<random_string>" <10>
},
{
"ParameterKey": "PrivateSubnets", <11>
"ParameterValue": "subnet-0dfe1c9412a54d352" <12>
"ParameterValue": "subnet-<random_string>" <12>
},
{
"ParameterKey": "VpcId", <13>
"ParameterValue": "vpc-055h956b1e6572be9" <14>
"ParameterValue": "vpc-<random_string>" <14>
}
]
----
Expand Down
6 changes: 3 additions & 3 deletions modules/installation-creating-aws-security.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,19 +33,19 @@ requires:
[
{
"ParameterKey": "InfrastructureName", <1>
"ParameterValue": "mycluster-vw9j6" <2>
"ParameterValue": "mycluster-<random_string>" <2>
},
{
"ParameterKey": "VpcCidr", <3>
"ParameterValue": "10.0.0.0/16" <4>
},
{
"ParameterKey": "PrivateSubnets", <5>
"ParameterValue": "subnet-0dfe1c9412a54d352" <6>
"ParameterValue": "subnet-<random_string>" <6>
},
{
"ParameterKey": "VpcId", <7>
"ParameterValue": "vpc-055h956b1e6572be9" <8>
"ParameterValue": "vpc-<random_string>" <8>
}
]
----
Expand Down
6 changes: 3 additions & 3 deletions modules/installation-creating-aws-worker.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,19 +41,19 @@ template requires:
[
{
"ParameterKey": "InfrastructureName", <1>
"ParameterValue": "mycluster-vw9j6" <2>
"ParameterValue": "mycluster-<random_string>" <2>
},
{
"ParameterKey": "RhcosAmi", <3>
"ParameterValue": "ami-07f604c5f18a1e7a9" <4>
"ParameterValue": "ami-<random_string>" <4>
},
{
"ParameterKey": "WorkerSubnet", <5>
"ParameterValue": "yes" <6>
Copy link
Copy Markdown

@mazzystr mazzystr May 30, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry ... found another problem. This parameter key should be called PrivateSubnet. The Value should be sg- string. The parameter should be modified in the template yaml also @wking

Since there is only one subnet parameter for workers nodes how do I span subnets across availability zones?

Copy link
Copy Markdown
Contributor Author

@kalexand-rh kalexand-rh May 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#15086

},
{
"ParameterKey": "WorkerSecurityGroupId", <7>
"ParameterValue": "sg-042ebc4dd65c71d67" <8>
"ParameterValue": "sg-<random_string>" <8>
},
{
"ParameterKey": "IgnitionLocation", <9>
Expand Down