Skip to content

Bug 1712525, Configuring a custom PKI #18207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codyhoag merged 1 commit into from
Nov 25, 2019
Merged

Bug 1712525, Configuring a custom PKI #18207

codyhoag merged 1 commit into from
Nov 25, 2019

Conversation

@codyhoag
Copy link
Contributor

@codyhoag codyhoag commented Nov 20, 2019 •
edited
Loading

https://bugzilla.redhat.com/show_bug.cgi?id=1712525

Reorganized from previous submission: #18004

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 20, 2019
@codyhoag codyhoag added this to the Next Release milestone Nov 20, 2019
@openshift-docs-preview-bot
Copy link

openshift-docs-preview-bot commented Nov 20, 2019

The preview will be available shortly at:

@codyhoag
Copy link
Contributor Author

codyhoag commented Nov 20, 2019

Configuring a custom PKI assembly build:

http://file.rdu.redhat.com/~choag/112019/ingress-cert/networking/configuring-a-custom-pki.html

@codyhoag codyhoag mentioned this pull request Nov 20, 2019
Closed
@codyhoag
Copy link
Contributor Author

codyhoag commented Nov 20, 2019

@danehans can you review the new docs I've created on Configuring a custom PKI?

codyhoag
codyhoag commented Nov 20, 2019
View reviewed changes
danehans
danehans reviewed Nov 22, 2019
View reviewed changes
danehans
danehans reviewed Nov 22, 2019
View reviewed changes
danehans
danehans reviewed Nov 22, 2019
View reviewed changes
danehans
danehans reviewed Nov 22, 2019
View reviewed changes
danehans
danehans reviewed Nov 22, 2019
View reviewed changes
danehans
danehans reviewed Nov 22, 2019
View reviewed changes
@danehans
Copy link
Contributor

danehans commented Nov 22, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2019
@codyhoag
Copy link
Contributor Author

codyhoag commented Nov 22, 2019

@lihongan can you review this content? Thanks!

@codyhoag codyhoag assigned lihongan and unassigned danehans Nov 22, 2019
@lihongan
Copy link

lihongan commented Nov 25, 2019

LGTM, thank you!

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 25, 2019

New changes are detected. LGTM label has been removed.

@codyhoag
Copy link
Contributor Author

codyhoag commented Nov 25, 2019

@bergerhoffer can you review to ensure I followed all the rules? 🙂 This is a reorg of #18004. Thanks!

@bergerhoffer bergerhoffer self-requested a review November 25, 2019 17:01
bergerhoffer
bergerhoffer reviewed Nov 25, 2019
View reviewed changes
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions to consider!

@bergerhoffer bergerhoffer added the peer-review-done Signifies that the peer review team has reviewed this PR label Nov 25, 2019
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 25, 2019
@codyhoag codyhoag merged commit 23788df into openshift:master Nov 25, 2019
@codyhoag
Copy link
Contributor Author

codyhoag commented Nov 25, 2019

/cherrypick enterprise-4.2

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 25, 2019
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 25, 2019

@codyhoag: new pull request created: #18285

Details

In response to this:

/cherrypick enterprise-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codyhoag
Copy link
Contributor Author

codyhoag commented Nov 25, 2019

/cherrypick enterprise-4.3

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 25, 2019
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 25, 2019

@codyhoag: new pull request created: #18286

Details

In response to this:

/cherrypick enterprise-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codyhoag codyhoag deleted the ingress-cert branch December 5, 2019 21:03
wking added a commit to wking/openshift-docs that referenced this pull request May 12, 2020
@wking
networking/configuring-a-custom-pki: Link back to builds trusted-CA c…
e837645 
…onfig

Reciprocating the builds -> proxy link from 1fdd604 (New assembly
for configuring custom pki, 2019-11-07, openshift#18207), so folks who think "I
need to add X.509 trust" and land on the "custom PKI" section can see
"oh, I'm not using a proxy, I guess I should configure the build
tooling directly..." and head over.  Also, we're likely to have a
number of additional cluster components that have their own custom CA
injection mechanisms, and this new section gives us a convenient list
we can extend.
@wking wking mentioned this pull request May 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergerhoffer bergerhoffer bergerhoffer left review comments

+1 more reviewer

@danehans danehans danehans left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.2 branch/enterprise-4.3 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

7 participants

@codyhoag @openshift-docs-preview-bot @danehans @lihongan @openshift-ci-robot @openshift-cherrypick-robot @bergerhoffer