networking/configuring-a-custom-pki: Link back to builds trusted-CA config #22009
Conversation
…onfig Reciprocating the builds -> proxy link from 1fdd604 (New assembly for configuring custom pki, 2019-11-07, openshift#18207), so folks who think "I need to add X.509 trust" and land on the "custom PKI" section can see "oh, I'm not using a proxy, I guess I should configure the build tooling directly..." and head over. Also, we're likely to have a number of additional cluster components that have their own custom CA injection mechanisms, and this new section gives us a convenient list we can extend.
kalexand-rh
left a comment
kalexand-rh
left a comment
There was a problem hiding this comment.
I have a few suggestions.
|
|
||
| Cluster components may provide alternative mechanisms for configuring additional trust, for situations when a proxy is not needed: | ||
|
|
||
| * xref:../builds/setting-up-trusted-ca.adoc[Builds] |
There was a problem hiding this comment.
It's better for the link to use the doc title: s/Builds/Setting up additional trusted certificate authorities for builds
| certificate and key pair used by the cluster component. | ||
| ==== | ||
|
|
||
| == Alternatives for additional trust |
There was a problem hiding this comment.
Consider removing the heading. When it's rendered, it looks out of place.
|
|
||
| == Alternatives for additional trust | ||
|
|
||
| Cluster components may provide alternative mechanisms for configuring additional trust, for situations when a proxy is not needed: |
There was a problem hiding this comment.
I might say "If you do not use a proxy, you can configure some cluster components to provide additional trust instead:"
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci-robot
added
the
lifecycle/stale
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci-robot
added
lifecycle/rotten
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
Reciprocating the builds -> proxy link from 1fdd604 (#18207), so folks who think "I need to add X.509 trust" and land on the "custom PKI" section can see "oh, I'm not using a proxy, I guess I should configure the build tooling directly..." and head over. Also, we're likely to have a number of additional cluster components that have their own custom CA injection mechanisms, and this new section gives us a convenient list we can extend.