Skip to content

Add information about octavia upgrades impact on Kuryr SDN#21488

Merged
maxwelldb merged 5 commits intoopenshift:masterfrom
luis5tb:octavia-upgrades-limitations
Jun 9, 2020
Merged

Add information about octavia upgrades impact on Kuryr SDN#21488
maxwelldb merged 5 commits intoopenshift:masterfrom
luis5tb:octavia-upgrades-limitations

Conversation

@luis5tb
Copy link
Copy Markdown
Contributor

@luis5tb luis5tb commented Apr 24, 2020

This PR adds information about the octavia upgrades problems with using Kuryr SDN, depending on the way OSP handles them

@maxwelldb
Copy link
Copy Markdown
Contributor

maxwelldb commented Apr 24, 2020

@luis5tb And this one is 4.5+, right?

@luis5tb
Copy link
Copy Markdown
Contributor Author

luis5tb commented Apr 24, 2020

@luis5tb And this one is 4.5+, right?

right!

@maxwelldb maxwelldb added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 24, 2020
@maxwelldb maxwelldb self-requested a review April 24, 2020 16:48
@maxwelldb maxwelldb marked this pull request as draft April 24, 2020 18:04
@maxwelldb maxwelldb self-assigned this Apr 24, 2020
MaysaMacedo
MaysaMacedo reviewed Apr 27, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@MaysaMacedo MaysaMacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just few nits and a question.

Comment thread modules/installation-osp-kuryr-known-limitations.adoc Outdated
Comment thread modules/installation-osp-kuryr-known-limitations.adoc Outdated
Comment thread modules/installation-osp-kuryr-known-limitations.adoc Outdated
Copy link
Copy Markdown
Contributor

@MaysaMacedo MaysaMacedo Apr 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though it's really likely that this will happen, have we check it?

Copy link
Copy Markdown
Contributor Author

@luis5tb luis5tb Apr 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I'll do as soon as I get access to an env where I can test it

@luis5tb luis5tb force-pushed the octavia-upgrades-limitations branch 2 times, most recently from f5e09d0 to 91ab5dd Compare April 28, 2020 14:32
@MaysaMacedo
Copy link
Copy Markdown
Contributor

MaysaMacedo commented Apr 29, 2020

Looks good. Should we add a note about the DNS service recreation on the CNO?

@luis5tb luis5tb force-pushed the octavia-upgrades-limitations branch from 91ab5dd to 3f991e2 Compare May 28, 2020 15:16
@luis5tb
Copy link
Copy Markdown
Contributor Author

luis5tb commented May 28, 2020

Looks good. Should we add a note about the DNS service recreation on the CNO?

done

@MaysaMacedo
Copy link
Copy Markdown
Contributor

MaysaMacedo commented May 28, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2020
@maxwelldb maxwelldb added this to the Future Release milestone May 28, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 29, 2020
@maxwelldb
Copy link
Copy Markdown
Contributor

maxwelldb commented May 29, 2020

@luis5tb Let me know what you think about 922542b. No rush.

@luis5tb
Copy link
Copy Markdown
Contributor Author

luis5tb commented Jun 1, 2020

@luis5tb Let me know what you think about 922542b. No rush.

Looks good

@maxwelldb
Copy link
Copy Markdown
Contributor

maxwelldb commented Jun 1, 2020

@luis5tb TY.

@rlobillo Would you be able to review these changes?

@rlobillo
Copy link
Copy Markdown

rlobillo commented Jun 2, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 9, 2020

New changes are detected. LGTM label has been removed.

@maxwelldb
Copy link
Copy Markdown
Contributor

maxwelldb commented Jun 9, 2020

Tweaked to fix parallel construction error. Nothing substantive.

@maxwelldb maxwelldb marked this pull request as ready for review June 9, 2020 13:05
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 9, 2020
@maxwelldb maxwelldb added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 9, 2020
@bmcelvee bmcelvee added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 9, 2020
@bmcelvee
Copy link
Copy Markdown
Contributor

bmcelvee commented Jun 9, 2020

LGTM. Don't forget to squash your commits. :)

@maxwelldb
Copy link
Copy Markdown
Contributor

maxwelldb commented Jun 9, 2020

LGTM. Don't forget to squash your commits. :)

Always! Thanks!

@maxwelldb maxwelldb merged commit 7512082 into openshift:master Jun 9, 2020
@maxwelldb
Copy link
Copy Markdown
Contributor

maxwelldb commented Jun 9, 2020

/cherry-pick enterprise-4.5

@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Jun 9, 2020

@maxwelldb: new pull request created: #22787

Details

In response to this:

/cherry-pick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 9, 2020
Merged
@maxwelldb maxwelldb mentioned this pull request Jul 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxwelldb maxwelldb maxwelldb approved these changes

+1 more reviewer

@MaysaMacedo MaysaMacedo MaysaMacedo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@MaysaMacedo MaysaMacedo

@maxwelldb maxwelldb

@rlobillo rlobillo

Labels

branch/enterprise-4.5 peer-review-done Signifies that the peer review team has reviewed this PR

Projects

None yet

Milestone

OCP 4.5 GA

Development

Successfully merging this pull request may close these issues.

8 participants

@luis5tb @maxwelldb @MaysaMacedo @rlobillo @openshift-ci-robot @bmcelvee @openshift-cherrypick-robot @vikram-redhat