Skip to content

Remove outdated Kuryr + Octavia compatibility notes#23716

Merged
maxwelldb merged 1 commit intoopenshift:masterfrom
maxwelldb:osp-4.5-octavia-compat-23711
Jul 16, 2020
Merged

Remove outdated Kuryr + Octavia compatibility notes#23716
maxwelldb merged 1 commit intoopenshift:masterfrom
maxwelldb:osp-4.5-octavia-compat-23711

Conversation

@maxwelldb
Copy link
Copy Markdown
Contributor

@maxwelldb maxwelldb commented Jul 13, 2020

This PR resolves #23711.

QE should be covered already by #21488 and #22878.

@maxwelldb
Remove outdated Kuryr + Octavia compat notes
f485691 
This change addresses openshift-docs issue 23711
openshift#23711
@maxwelldb maxwelldb added this to the Next Release milestone Jul 13, 2020
@maxwelldb maxwelldb requested a review from luis5tb July 13, 2020 13:32
@maxwelldb maxwelldb self-assigned this Jul 13, 2020
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 13, 2020
@maxwelldb
Copy link
Copy Markdown
Contributor Author

maxwelldb commented Jul 13, 2020

Let me know if you have any concerns, @luis5tb.

@openshift-docs-preview-bot
Copy link
Copy Markdown

openshift-docs-preview-bot commented Jul 13, 2020

The preview will be available shortly at:

@luis5tb
Copy link
Copy Markdown
Contributor

luis5tb commented Jul 13, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2020
@maxwelldb
Copy link
Copy Markdown
Contributor Author

maxwelldb commented Jul 13, 2020

@openshift/team-documentation PTAL. S review: +1 and -11.

@maxwelldb maxwelldb added the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 13, 2020
@maxwelldb maxwelldb changed the title Remove outdated Kuryr + Octavia compat notes Remove outdated Kuryr + Octavia compatibility notes Jul 16, 2020
maxwelldb
maxwelldb commented Jul 16, 2020
View reviewed changes
Comment thread modules/installation-osp-kuryr-known-limitations.adoc
for DNS resolution if:

* The {rh-openstack} version is earlier than 16
* The OVN Octavia driver is used
Copy link
Copy Markdown
Contributor Author

@maxwelldb maxwelldb Jul 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bullet no longer applies--OVN Octavia support is improved in 4.5+.

maxwelldb
maxwelldb commented Jul 16, 2020
View reviewed changes
Comment thread modules/installation-osp-kuryr-known-limitations.adoc
same port. Services that expose the same port to different protocols, like TCP
and UDP, are not supported.

[IMPORTANT]
Copy link
Copy Markdown
Contributor Author

@maxwelldb maxwelldb Jul 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This admonition no longer applies--OVN Octavia support is improved in 4.5+.

adellape
adellape approved these changes Jul 16, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@adellape adellape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@maxwelldb
Copy link
Copy Markdown
Contributor Author

maxwelldb commented Jul 16, 2020

@adellape Thanks!

@adellape adellape added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jul 16, 2020
@maxwelldb maxwelldb merged commit 10f9a95 into openshift:master Jul 16, 2020
@maxwelldb
Copy link
Copy Markdown
Contributor Author

maxwelldb commented Jul 16, 2020

/cherry-pick enterprise-4.5

@maxwelldb
Copy link
Copy Markdown
Contributor Author

maxwelldb commented Jul 16, 2020

/cherry-pick enterprise-4.6

@maxwelldb maxwelldb deleted the osp-4.5-octavia-compat-23711 branch July 16, 2020 15:51
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 16, 2020
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Jul 16, 2020

@maxwelldb: new pull request created: #23878

Details

In response to this:

/cherry-pick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 16, 2020
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Jul 16, 2020

@maxwelldb: new pull request created: #23879

Details

In response to this:

/cherry-pick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luis5tb luis5tb Awaiting requested review from luis5tb

1 more reviewer

@adellape adellape adellape approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@luis5tb luis5tb

@maxwelldb maxwelldb

Labels

branch/enterprise-4.5 branch/enterprise-4.6 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

[enterprise-4.5] Update Kuryr and Octavia compatibility statements in OSP installation docs

6 participants

@maxwelldb @openshift-docs-preview-bot @luis5tb @openshift-cherrypick-robot @adellape @openshift-ci-robot