CNV-1396 Cloning a DataVolume using smart-cloning by bgaydosrh · Pull Request #25231 · openshift/openshift-docs

bgaydosrh · 2020-09-02T23:55:59Z

Tagging @awels for code review.

Label *peer review needed" and enterprise-4.6.

Test Build: https://cnv-1396--ocpdocs.netlify.app/openshift-enterprise/latest/virt/virtual_machines/virtual_disks/virt-cloning-a-datavolume-using-smart-cloning.html

Link to new PR to fix changes suggested after merging: #26676

openshift-docs-preview-bot · 2020-09-02T23:58:50Z

The preview will be available shortly at:

https://CNV-1396--ocpdocs.netlify.com/

awels · 2020-09-04T13:30:47Z

Looks good to me.

kgoldbla

LGTM

bgaydosrh · 2020-09-09T14:40:08Z

Both Dev and QE have signed off but the feature is still not testable.Once it is and I receive confirmation of this I can move this PR to peer review and merge.

bergerhoffer

Just two more minor things, otherwise LGTM!

kgoldbla

Please update the doc with changes requested by mhenricks

bergerhoffer · 2020-10-15T15:00:53Z

This LGTM too now. @bgaydosrh is this ready for me to merge?

bgaydosrh · 2020-10-15T15:08:38Z

Yes thanks!

On Thu, Oct 15, 2020 at 11:02 AM Andrea Hoffer ***@***.***> wrote: This LGTM too now. @bgaydosrh <https://github.com/bgaydosrh> is this ready for me to merge? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#25231 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALQXFOJXPCBH7Z6BX2Y5Z53SK4FDXANCNFSM4QT7LD2Q> .

-- *Bob Gaydos* He | His Senior Technical Writer, Customer Content Services, Cloud Platform Red Hat Virtualization Red Hat <https://www.redhat.com/> <https://www.redhat.com/>

bergerhoffer · 2020-10-15T15:16:29Z

/cherrypick enterprise-4.6

openshift-cherrypick-robot · 2020-10-15T15:16:57Z

@bergerhoffer: new pull request created: #26502

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vikram-redhat · 2020-10-20T22:32:18Z

+
+== Additional resources
+
+* xref:../../../virt/virtual_machines/cloning_vms/virt-cloning-vm-disk-into-new-datavolume.html#virt-cloning-pvc-of-vm-disk-into-new-datavolume_virt-cloning-vm-disk-into-new-datavolume[Cloning the PersistentVolumeClaim of a virtual machine disk into a new DataVolume]


Hey @bgaydosrh this should link to an adoc file, not to an HTML.

vikram-redhat · 2020-10-20T22:33:00Z

+<3> The name of the source PVC.
+<4> The size of the new DataVolume. You must allocate enough space, or the
+cloning operation fails. The size must be the same as or larger than the source PVC.
+ifdef::blockstorage[]


@bgaydosrh - what's the usage of blockstorage attribute here (and in other code samples) for? I don't see it defined in the enclosing assembly.

I lifted the module code from something written (by Andrew perhaps?) for another assembly with the blockstorage conditional attribute appropriately defined and unset. I have added the definition and un-setting of the conditional in my new assembly for consistency.

@vikram-redhat -- if you like I can confer with Andrew if this cond is needed at all. Since I copied this module doc, I assumed it was but I can investigate now, or do it after GA. Your call.

@bgaydosrh can you link to the new PR to make these fixes?

Using or not using the conditional changes the code samples so this should go through a QE review.

Link to new PR to fix changes suggested after merging: #26670

@kgoldbla can you re-review for this change in conditionals?

openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 2, 2020

bgaydosrh force-pushed the CNV-1396 branch 6 times, most recently from ccf3647 to bf3b13e Compare September 3, 2020 16:40

bgaydosrh changed the title ~~CNV-1396 Cloning Virtual Disks~~ CNV-1396 Cloning DataVolumes using smart-cloning Sep 3, 2020

bgaydosrh changed the title ~~CNV-1396 Cloning DataVolumes using smart-cloning~~ CNV-1396 Cloning DataVolumes Sep 3, 2020

bgaydosrh changed the title ~~CNV-1396 Cloning DataVolumes~~ CNV-1396 Cloning a DataVolume Sep 3, 2020

bgaydosrh force-pushed the CNV-1396 branch from d671726 to 894a7bd Compare September 3, 2020 17:30

bgaydosrh changed the title ~~CNV-1396 Cloning a DataVolume~~ CNV-1396 Cloning a DataVolume using smart-cloning Sep 3, 2020

bgaydosrh force-pushed the CNV-1396 branch 3 times, most recently from f0f5c3a to 113a8d5 Compare September 3, 2020 18:28

kgoldbla reviewed Sep 6, 2020

View reviewed changes

bgaydosrh force-pushed the CNV-1396 branch 2 times, most recently from 8c186bb to 40c9d12 Compare September 22, 2020 15:45

bergerhoffer added branch/enterprise-4.6 CNV Label for all CNV PRs peer-review-needed Signifies that the peer review team needs to review this PR labels Sep 22, 2020

bergerhoffer reviewed Sep 22, 2020

View reviewed changes

bergerhoffer added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Sep 22, 2020

bergerhoffer added this to the Future Release milestone Sep 22, 2020

bgaydosrh force-pushed the CNV-1396 branch from 40c9d12 to 3f8b4f9 Compare September 24, 2020 17:37

openshift-ci-robot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 24, 2020

openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 24, 2020

bgaydosrh force-pushed the CNV-1396 branch from 3f8b4f9 to 8e8a187 Compare September 24, 2020 17:37

bergerhoffer reviewed Sep 24, 2020

View reviewed changes

Comment thread modules/virt-understanding-smart-cloning.adoc Outdated

Comment thread modules/virt-cloning-a-datavolume.adoc Outdated

Comment thread modules/virt-cloning-a-datavolume.adoc Outdated

bergerhoffer reviewed Sep 24, 2020

View reviewed changes

bgaydosrh force-pushed the CNV-1396 branch from 7b2947e to 5f18222 Compare September 24, 2020 19:05

mhenriks reviewed Oct 6, 2020

View reviewed changes

Comment thread modules/virt-cloning-a-datavolume.adoc Outdated

kgoldbla suggested changes Oct 8, 2020

View reviewed changes

bgaydosrh force-pushed the CNV-1396 branch from 5f18222 to 279f16f Compare October 15, 2020 01:48

QE review

739dee5

bgaydosrh force-pushed the CNV-1396 branch from 279f16f to 739dee5 Compare October 15, 2020 01:53

bergerhoffer merged commit 839d57a into openshift:master Oct 15, 2020

openshift-cherrypick-robot mentioned this pull request Oct 15, 2020

[enterprise-4.6] CNV-1396 Cloning a DataVolume using smart-cloning #26502

Merged

vikram-redhat reviewed Oct 20, 2020

View reviewed changes

bgaydosrh mentioned this pull request Oct 23, 2020

CNV-1396_2 Fixing Vikram's comments from merged PR #26676

Merged

vikram-redhat modified the milestones: Future Release, OCP 4.6 GA Oct 27, 2020


		== Additional resources

		* xref:../../../virt/virtual_machines/cloning_vms/virt-cloning-vm-disk-into-new-datavolume.html#virt-cloning-pvc-of-vm-disk-into-new-datavolume_virt-cloning-vm-disk-into-new-datavolume[Cloning the PersistentVolumeClaim of a virtual machine disk into a new DataVolume]

Conversation

bgaydosrh commented Sep 2, 2020 • edited by openshift-ci-robot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-docs-preview-bot commented Sep 2, 2020

Uh oh!

awels commented Sep 4, 2020

Uh oh!

kgoldbla left a comment

Choose a reason for hiding this comment

Uh oh!

bgaydosrh commented Sep 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bergerhoffer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kgoldbla left a comment

Choose a reason for hiding this comment

Uh oh!

bergerhoffer commented Oct 15, 2020

Uh oh!

bgaydosrh commented Oct 15, 2020 via email

Uh oh!

bergerhoffer commented Oct 15, 2020 • edited by openshift-ci-robot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-cherrypick-robot commented Oct 15, 2020 • edited by openshift-ci-robot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vikram-redhat Oct 20, 2020

Choose a reason for hiding this comment

Uh oh!

bgaydosrh Oct 23, 2020

Choose a reason for hiding this comment

Uh oh!

vikram-redhat Oct 20, 2020

Choose a reason for hiding this comment

Uh oh!

bgaydosrh Oct 23, 2020

Choose a reason for hiding this comment

Uh oh!

bgaydosrh Oct 23, 2020

Choose a reason for hiding this comment

Uh oh!

vikram-redhat Oct 23, 2020

Choose a reason for hiding this comment

Uh oh!

bgaydosrh Oct 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

bgaydosrh commented Sep 2, 2020 •

edited by openshift-ci-robot

Loading

bgaydosrh commented Sep 9, 2020 •

edited

Loading

bergerhoffer commented Oct 15, 2020 •

edited by openshift-ci-robot

Loading

openshift-cherrypick-robot commented Oct 15, 2020 •

edited by openshift-ci-robot

Loading

bgaydosrh Oct 23, 2020 •

edited

Loading