Skip to content

CNV-1396_2 Fixing Vikram's comments from merged PR #26676

Merged
adellape merged 1 commit intoopenshift:masterfrom
bgaydosrh:CNV-1396_2
Nov 9, 2020
Merged

CNV-1396_2 Fixing Vikram's comments from merged PR #26676
adellape merged 1 commit intoopenshift:masterfrom
bgaydosrh:CNV-1396_2

Conversation

@bgaydosrh
Copy link
Copy Markdown

@bgaydosrh bgaydosrh commented Oct 23, 2020 •
edited by openshift-ci-robot
Loading

This PR fixes issues raised by @vikram-redhat in merged PR #25231

Link to original story: https://issues.redhat.com/browse/CNV-1396

Peer review needed. Label enterprise-4.6 only

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 23, 2020
@openshift-docs-preview-bot
Copy link
Copy Markdown

openshift-docs-preview-bot commented Oct 23, 2020

The preview will be available shortly at:

@bgaydosrh bgaydosrh mentioned this pull request Oct 23, 2020
Merged
adellape
adellape approved these changes Oct 23, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@adellape adellape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM: ifdef'd items now show up in the rendered assembly.

@adellape adellape added peer-review-done Signifies that the peer review team has reviewed this PR CNV Label for all CNV PRs branch/enterprise-4.6 labels Oct 23, 2020
@vikram-redhat
Copy link
Copy Markdown
Contributor

vikram-redhat commented Oct 23, 2020

Needs QE ack to verify that the addition of the blockstorage in the code samples makes sense.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 28, 2020
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 9, 2020
@bgaydosrh
Copy link
Copy Markdown
Author

bgaydosrh commented Nov 9, 2020 •
edited
Loading

Eliminated conditionals from both module and assembly. @aglitke approved new YAML (in Chat) and suggested accessmode parm be ReadWriteMany not ReadWriteOnce. Revised some text to reflect block mode is used in this example.

adellape
adellape reviewed Nov 9, 2020
View reviewed changes
Comment thread modules/virt-cloning-a-datavolume.adoc Outdated
@adellape adellape added this to the Next Release milestone Nov 9, 2020
@adellape adellape merged commit e676343 into openshift:master Nov 9, 2020
@adellape
Copy link
Copy Markdown
Contributor

adellape commented Nov 9, 2020 •
edited by openshift-ci-robot
Loading

/cherrypick enterprise-4.6

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 9, 2020
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Nov 9, 2020 •
edited by openshift-ci-robot
Loading

@adellape: new pull request created: #27206

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aburdenthehand
Copy link
Copy Markdown
Contributor

aburdenthehand commented Nov 26, 2020 •
edited by openshift-ci-robot
Loading

@bgaydosrh I see that this has 'enterprise-4.6 only' and was not cherry-picked to enterprise-4.7. This has created a bunch of merge conflicts trying to cherry-pick #27562 to enterprise-4.7 now and it's difficult to see how the changes in this PR don't also apply to enterprise-4.7. Since this PR was initially created a few days before enterprise-4.7 was created, I'm going to presume that it was an oversight and this PR should have been updated to also be cherry-picked to enterprise-4.7, which I'll do now so that it's in line with master and e-4.6.
If this is in error, I'll take care of undoing it.

@vikram-redhat in case you have more context

@aburdenthehand
Copy link
Copy Markdown
Contributor

aburdenthehand commented Nov 26, 2020 •
edited by openshift-ci-robot
Loading

/cherry-pick enterprise-4.7

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 26, 2020
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Nov 26, 2020 •
edited by openshift-ci-robot
Loading

@aburdenthehand: new pull request created: #27679

Details

In response to this:

/cherry-pick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aburdenthehand aburdenthehand mentioned this pull request Nov 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@adellape adellape adellape approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.6 CNV Label for all CNV PRs peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

7 participants

@bgaydosrh @openshift-docs-preview-bot @vikram-redhat @adellape @openshift-cherrypick-robot @aburdenthehand @openshift-ci-robot