Skip to content

Fix non existing image in Serverless eventing#25236

Merged
bergerhoffer merged 1 commit intoopenshift:masterfrom
nak3:fix-absent-image
Sep 3, 2020
Merged

Fix non existing image in Serverless eventing#25236
bergerhoffer merged 1 commit intoopenshift:masterfrom
nak3:fix-absent-image

Conversation

@nak3
Copy link
Copy Markdown
Contributor

@nak3 nak3 commented Sep 3, 2020

Fixes #23465

This patch fixes non existing image.
Ideally we should use an official image, but we don't have it yet. So use an image in quay.io.

/cc @abrennan89 @matzew

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 3, 2020
Copy link
Copy Markdown
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks Kenjiro!

Copy link
Copy Markdown
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just need to know which versions this is for.

@bergerhoffer
Copy link
Copy Markdown
Contributor

/cherrypick enterprise-4.6

@bergerhoffer
Copy link
Copy Markdown
Contributor

/cherrypick enterprise-4.5

@bergerhoffer
Copy link
Copy Markdown
Contributor

/cherrypick enterprise-4.4

@openshift-cherrypick-robot
Copy link
Copy Markdown

@bergerhoffer: new pull request created: #25243

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bergerhoffer
Copy link
Copy Markdown
Contributor

/cherrypick enterprise-4.3

@openshift-cherrypick-robot
Copy link
Copy Markdown

@bergerhoffer: new pull request created: #25244

Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@bergerhoffer: new pull request created: #25245

Details

In response to this:

/cherrypick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@bergerhoffer: new pull request created: #25246

Details

In response to this:

/cherrypick enterprise-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nak3
Copy link
Copy Markdown
Contributor Author

nak3 commented Sep 3, 2020

LGTM! Just need to know which versions this is for.

Yeah, we need it for all version as you already cherri-picked. Thank you! 😺

@nak3 nak3 deleted the fix-absent-image branch September 3, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.3 branch/enterprise-4.4 branch/enterprise-4.5 branch/enterprise-4.6 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gcr.io/hello-minikube-zero-install/hello-node image does not exist

5 participants