Skip to content

logging: configuration from configmaps etc#2538

Merged
ahardin-rh merged 2 commits into
openshift:masterfrom
sosiouxme:20160714-logging-configmaps-etc
Aug 18, 2016
Merged

logging: configuration from configmaps etc#2538
ahardin-rh merged 2 commits into
openshift:masterfrom
sosiouxme:20160714-logging-configmaps-etc

Conversation

@sosiouxme
Copy link
Copy Markdown
Member

@sosiouxme sosiouxme commented Jul 21, 2016 •
edited
Loading

Deployer uses a configmap for config, and so do fluentd and curator.

These changes are relevant for Origin and also for OSE 3.3 when it arrives. Definitely not OSE 3.2.1.

@sosiouxme
Copy link
Copy Markdown
Member Author

sosiouxme commented Jul 21, 2016

@adellape @ewolinetz there are probably more changes I'll find to make but I wanted to get any preliminary feedback on the direction this is going. Rather a large change, but it is simplifying in many ways.

@adellape
Copy link
Copy Markdown
Contributor

adellape commented Jul 21, 2016

@sosiouxme Is there an associated Trello card?

@sosiouxme
Copy link
Copy Markdown
Member Author

sosiouxme commented Jul 21, 2016

@adellape well... there's https://trello.com/c/lY49CWNI/281-3-get-origin-features-into-enterprise-repo-for-3-3-logging at least.

@sosiouxme sosiouxme force-pushed the 20160714-logging-configmaps-etc branch from 19f03da to 5a520cb Compare August 8, 2016 20:24
@sosiouxme sosiouxme changed the title [WIP] logging: configuration from configmaps etc logging: configuration from configmaps etc Aug 8, 2016
@sosiouxme
Copy link
Copy Markdown
Member Author

sosiouxme commented Aug 8, 2016 •
edited
Loading

@adellape @ewolinetz I have been looking at this for too long... think it's about ready, though.
Compare current https://docs.openshift.org/latest/install_config/aggregate_logging.html with http://file.rdu.redhat.com/~lmeyer/_preview/openshift-origin/20160714-logging-configmaps-etc/install_config/aggregate_logging.html (and little-different http://file.rdu.redhat.com/~lmeyer/_preview/openshift-enterprise/20160714-logging-configmaps-etc/install_config/aggregate_logging.html)
Feedback most welcome.

ewolinetz
ewolinetz reviewed Aug 8, 2016
View reviewed changes
Comment thread install_config/aggregate_logging.adoc Outdated
Copy link
Copy Markdown

@ewolinetz ewolinetz Aug 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Storage

Copy link
Copy Markdown
Member Author

@sosiouxme sosiouxme Aug 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reeeally been looking at this too long.

@ewolinetz
Copy link
Copy Markdown

ewolinetz commented Aug 8, 2016 •
edited
Loading

Should we make reference to how to update the fluentd configuration for origin?

@sosiouxme
Copy link
Copy Markdown
Member Author

sosiouxme commented Aug 9, 2016

That would be a good idea. I'll work on it... think I just need to pull out
the contents from the README

On Mon, Aug 8, 2016 at 5:31 PM, Eric Wolinetz notifications@github.com
wrote:

Should we make reference to how to update the fluentd configuration for
origin?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#2538 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABz-iXj_0OCqFRUMOsbuYfS4X4wICZiks5qd6A3gaJpZM4JSMig
.

@ewolinetz ewolinetz mentioned this pull request Aug 11, 2016
Merged
@sosiouxme sosiouxme force-pushed the 20160714-logging-configmaps-etc branch from e04c346 to eb6ea7a Compare August 15, 2016 14:44
@sosiouxme
Copy link
Copy Markdown
Member Author

sosiouxme commented Aug 15, 2016

I included a bunch of info about fluentd.

@adellape any feedback?

@sosiouxme sosiouxme force-pushed the 20160714-logging-configmaps-etc branch 2 times, most recently from 8c421d0 to 9e8986d Compare August 18, 2016 14:39
@sosiouxme
Copy link
Copy Markdown
Member Author

sosiouxme commented Aug 18, 2016

@adellape or @ahardin-rh can we move this along so I don't have to keep fixing conflicts? 😃

@sosiouxme sosiouxme force-pushed the 20160714-logging-configmaps-etc branch from 9e8986d to 021cf7a Compare August 18, 2016 18:08
ahardin-rh
ahardin-rh reviewed Aug 18, 2016
View reviewed changes
Comment thread install_config/aggregate_logging.adoc Outdated
Copy link
Copy Markdown
Contributor

@ahardin-rh ahardin-rh Aug 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add in the anchor above the heading, so:

[[aggregate-logging-specifying-deployer-parameters]]
== Specifying Deployer Parameters

@ahardin-rh ahardin-rh added this to the Future Release milestone Aug 18, 2016
@ahardin-rh
Copy link
Copy Markdown
Contributor

ahardin-rh commented Aug 18, 2016

@sosiouxme Just a few link xref fixes please. 🙇 I can take care of some other minor nits in a follow-up PR ⭐

@ahardin-rh ahardin-rh self-assigned this Aug 18, 2016
@sosiouxme
logging: configuration from configmaps etc
bbbda51 
Because we use configmaps to configure the deployer as well as fluentd
and curator, this document has been refactored a fair amount.

Differences between origin and enterprise 3.3 have largely been
reconciled.
Newly-available parameters have been described.
Granting permissions to SAs has been simplified.
Wording has been adjusted in various places.
@sosiouxme
logging: fluentd post-deploy config options
887ab0d
@sosiouxme sosiouxme force-pushed the 20160714-logging-configmaps-etc branch from 021cf7a to 887ab0d Compare August 18, 2016 20:42
@sosiouxme
Copy link
Copy Markdown
Member Author

sosiouxme commented Aug 18, 2016

@ahardin-rh done, thanks!

@ahardin-rh ahardin-rh merged commit a75fdad into openshift:master Aug 18, 2016
@ahardin-rh
Copy link
Copy Markdown
Contributor

ahardin-rh commented Aug 18, 2016

[rev_history]
|xref:../install_config/aggregate_logging.adoc#install-config-aggregate-logging[Aggregating Container Logs]
|Added information about configuration from configmaps, Fluentd, and Curator.
%

@ahardin-rh ahardin-rh mentioned this pull request Aug 18, 2016
Merged
@sosiouxme sosiouxme deleted the 20160714-logging-configmaps-etc branch August 19, 2016 17:36
@tpoitras tpoitras mentioned this pull request Aug 29, 2016
Merged
@vikram-redhat vikram-redhat modified the milestones: OCP 3.3 GA, TEMP Oct 7, 2016
@adellape adellape mentioned this pull request Dec 14, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ahardin-rh ahardin-rh

Labels

branch/enterprise-3.3

Projects

None yet

Milestone

OCP 3.3 GA

Development

Successfully merging this pull request may close these issues.

5 participants

@sosiouxme @adellape @ewolinetz @ahardin-rh @vikram-redhat