Updating logging upgrade docs to account for MODE=upgrade#2643
Merged
Conversation
Contributor
|
@ewolinetz Couple nits inline, otherwise LGTM. @sosiouxme bump |
ewolinetz
force-pushed
the
migrate_mode
branch
from
cc01d9c to
bcca76a
Compare
Author
|
@sosiouxme @adellape for the enterprise upgrade path, is the on-disk logging template updated as part of upgrading? If not then I should further update that command... |
Member
There was a problem hiding this comment.
We also need to ensure that the "new" cluster role is added (unfortunately it can't go in the account template).
$ oadm policy add-cluster-role-to-user oauth-editor \
system:serviceaccount:logging:logging-deployer
(Use the project you created earlier (e.g., logging) when specifying this service account.)
Member
|
The on-disk logging one is updated, yeah, it's part of the RPM. |
ewolinetz
force-pushed
the
migrate_mode
branch
2 times, most recently
from
878231b to
9062b68
Compare
ewolinetz
force-pushed
the
migrate_mode
branch
from
9062b68 to
410090d
Compare
Author
|
Addressed nits |
Author
|
@adellape @sosiouxme bump |
Contributor
|
👍 Gonna go ahead and merge. @sosiouxme If you have further comments, add them here and I'll get to them in follow-up? |
Contributor
|
@adellape - please follow up early next week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependent on changes in #2538
@sosiouxme @adellape PTAL
This describes the new way to upgrade components as of OSE 3.3 and Origin 1.3