Skip to content

BZ1850429 Added proxy instructions to the installation section#30011

Merged
vikram-redhat merged 1 commit intoopenshift:masterfrom
sagidlow:BZ1850429
Mar 8, 2021
Merged

BZ1850429 Added proxy instructions to the installation section#30011
vikram-redhat merged 1 commit intoopenshift:masterfrom
sagidlow:BZ1850429

Conversation

@sagidlow
Copy link
Copy Markdown
Contributor

@sagidlow sagidlow commented Mar 2, 2021

Applies to version 4.4+
BZ Link: https://bugzilla.redhat.com/show_bug.cgi?id=1850429
Pending QE Approval: @wjiangjay

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 2, 2021
@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 2, 2021

Deploy preview for osdocs ready!

Built with commit 269431b

https://deploy-preview-30011--osdocs.netlify.app

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update the module to list these assemblies as places that they're used. Otherwise, this seems reasonable.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kalexand-rh - please verify. I just added it.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ghost
Copy link
Copy Markdown

ghost commented Mar 3, 2021

@sagidlow LGTM!

@sagidlow
Copy link
Copy Markdown
Contributor Author

sagidlow commented Mar 3, 2021

@kalexand-rh ready for merge.

@vikram-redhat vikram-redhat merged commit e0fc822 into openshift:master Mar 8, 2021
@vikram-redhat
Copy link
Copy Markdown
Contributor

/cherrypick enterprise-4.5

@vikram-redhat
Copy link
Copy Markdown
Contributor

/cherrypick enterprise-4.6

@openshift-cherrypick-robot
Copy link
Copy Markdown

@vikram-redhat: new pull request created: #30175

Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@vikram-redhat: new pull request created: #30176

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vikram-redhat
Copy link
Copy Markdown
Contributor

/cherrypick enterprise-4.7

@openshift-cherrypick-robot
Copy link
Copy Markdown

@vikram-redhat: new pull request created: #30177

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vikram-redhat
Copy link
Copy Markdown
Contributor

/cherrypick enterprise-4.8

@openshift-cherrypick-robot
Copy link
Copy Markdown

@vikram-redhat: new pull request created: #30178

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vikram-redhat
Copy link
Copy Markdown
Contributor

It says 4.4, so I will add it there too even though that is EOL, but there is always a cross-over when a new GA goes out.

@vikram-redhat
Copy link
Copy Markdown
Contributor

/cherrypick enterprise-4.4

@openshift-cherrypick-robot
Copy link
Copy Markdown

@vikram-redhat: new pull request created: #30179

Details

In response to this:

/cherrypick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants