Skip to content

BZ1850429 Added proxy instructions to the installation section #30011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vikram-redhat merged 1 commit into from
Mar 8, 2021
Merged

BZ1850429 Added proxy instructions to the installation section #30011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions installing/installing_openstack/installing-openstack-installer-custom.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ include::modules/installation-osp-verifying-external-network.adoc[leveloffset=+1
include::modules/installation-osp-describing-cloud-parameters.adoc[leveloffset=+1]
include::modules/installation-obtaining-installer.adoc[leveloffset=+1]
include::modules/installation-initializing.adoc[leveloffset=+1]
include::modules/installation-configure-proxy.adoc[leveloffset=+2]
Copy link
Copy Markdown
Contributor

@kalexand-rh kalexand-rh Mar 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update the module to list these assemblies as places that they're used. Otherwise, this seems reasonable.

Copy link
Copy Markdown
Contributor Author

@sagidlow sagidlow Mar 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kalexand-rh - please verify. I just added it.

Copy link
Copy Markdown
Contributor

@kalexand-rh kalexand-rh Mar 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

include::modules/installation-configuration-parameters.adoc[leveloffset=+1]
include::modules/installation-osp-custom-subnet.adoc[leveloffset=+2]
include::modules/installation-osp-deploying-bare-metal-machines.adoc[leveloffset=+2]
Expand Down
1 change: 1 addition & 0 deletions installing/installing_openstack/installing-openstack-installer-kuryr.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ include::modules/installation-osp-verifying-external-network.adoc[leveloffset=+1
include::modules/installation-osp-describing-cloud-parameters.adoc[leveloffset=+1]
include::modules/installation-obtaining-installer.adoc[leveloffset=+1]
include::modules/installation-initializing.adoc[leveloffset=+1]
include::modules/installation-configure-proxy.adoc[leveloffset=+2]
include::modules/installation-configuration-parameters.adoc[leveloffset=+1]
include::modules/installation-osp-custom-subnet.adoc[leveloffset=+2]
include::modules/installation-osp-kuryr-config-yaml.adoc[leveloffset=+2]
Expand Down
2 changes: 2 additions & 0 deletions modules/installation-configure-proxy.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
// * installing/installing_bare_metal/installing-bare-metal.adoc
// * installing/installing_aws/installing-restricted-networks-aws.adoc
// * installing/installing_bare_metal/installing-restricted-networks-bare-metal.adoc
// * installing/installing_openstack/installing-openstack-installer-custom.adoc
// * installing/installing_openstack/installing-openstack-installer-kuryr.adoc
// * installing/installing_vsphere/installing-restricted-networks-vsphere.adoc
// * installing/installing_vsphere/installing-vsphere.adoc
// * installing/installing_ibm_z/installing-ibm-z.adoc
Expand Down