BZ#1929240 Adds warning label to Operator catalog image

[stevsmit]

For 4.5

https://bugzilla.redhat.com/show_bug.cgi?id=1929240

The BZ log suggests that this should be changed in 4.5 and 4.6, however this issue has already been changed in 4.6. Please see openshift/oc#673 if confirmation is needed.

Direct link to doc preview: https://deploy-preview-30678--osdocs.netlify.app/openshift-enterprise/latest/operators/admin/olm-managing-custom-catalogs.html

No QA needed.

[netlify]

Deploy preview for osdocs ready!

Built with commit 078b668

https://deploy-preview-30678--osdocs.netlify.app

[codyhoag]

Since the admonition is for callout 4, perhaps it could be attached to it instead of at the bottom? Maybe something like this?:

<4> This flag is currently required due to a known issue with multiple architecture support.
+
[WARNING]
====
If the `filter-by-os` remains unset or set to any value other than `.*`, filtering out different architectures changes the digest of the manifest list, also known as a "multi-arch image", which causes deployments of those images and Operators on disconnected clusters to fail. For more information, see link:https://bugzilla.redhat.com/show_bug.cgi?id=1890951[BZ#1890951].
====
<5>...

Other than that, LGTM!

[stevsmit]

Hey Cody,

That doesn't work. I tried that initially but it interrupts the number. The reason it interrupts the number is because this is a callout list, and asciidoctor doesn't support putting a warning in the middle of a call out list (see asciidoctor/asciidoctor#1478 (comment)). I'll message you a picture of what that looks like when I tried it, but here's an attach picture:

I found this kind of frustrating because admonition blocks within a callout actually do work, but only when the codeblock is not part of an ordered list (see https://docs.openshift.com/container-platform/4.7/installing/installing_aws/installing-aws-network-customizations.html#installation-aws-config-yaml_installing-aws-network-customizations). That example looks much better but my understanding is that it isn't possible here. I worked with Alex on this BZ for a bit before we had to settle.

If you want me to wrestle around with it a bit more, I'm happy to, though.

[codyhoag]

@stevsmit Interesting; I knew I had done that before, but I guess my experiences were never in an ordered list. That is a weird issue 😵

I'll go ahead and merge, since we've got our hands tied. Thanks for the explanation!