Skip to content

Edits to architecture/core_objects/builds file#405

Merged
adellape merged 4 commits intoopenshift:masterfrom
bfallonf:pull_secrets
Jun 2, 2015
Merged

Edits to architecture/core_objects/builds file#405
adellape merged 4 commits intoopenshift:masterfrom
bfallonf:pull_secrets

Conversation

@bfallonf
Copy link

PR in response to: #398

@mfojtik I know you only worked on part of this file, but could I ask for a tech review, please? I rewrote some sentences, arranged some info, and took out some info (commented out) as it was in the dev_guide/builds file: http://docs.openshift.com/enterprise/latest/dev_guide/builds.html#build-triggers

I also have a couple of questions:

  1. Would it be possible to get an example of the buildconfig? I feel like there's a JSON example that's missing.
  2. There are two procedures under "Using Private Repositories for Builds" and "Using Docker Credentials for Pushing and Pulling Images". Would you be against me moving them to the dev_guide/builds file? I feel their current location is more for context, and this is more about configuring builds.

I think that's all. Thanks in advance!

@adellape
Copy link
Contributor

@bfallonf For 1) in case it helps, if you're just looking for a full buildConfig example, you can use the CLI to take a look at an existing one, for example if you created the sample-app:

$ osc edit bc ruby-sample-build

Add -o json if you want JSON specifically instead of YAML.

You could take something like that and add it into the "BuildConfig" section of this topic, and re-purpose the [horizontal] labeled list you commented out as callout fodder for the various parts around the bc example.

@bfallonf
Copy link
Author

bfallonf commented Jun 1, 2015

@adellape Oh, of course. Thanks for that. I've added a buildconfig example and put in the list into footnotes things for the file.

@mfojtik Wold still like to request a tech review.

Thanks, guys.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a note, there will be v1 soon, but I think this applies to many other examples we have in docs... don't change it now, just a reminder

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mfojtik Good point. I've created an issue so that this can be remembered when the time comes: #428

@mfojtik
Copy link
Contributor

mfojtik commented Jun 1, 2015

@adellape @bfallonf comments added, otherwise LGTM

@bfallonf
Copy link
Author

bfallonf commented Jun 2, 2015

@mfojtik Cool. I have fixed up your suggested parts. If there's nothing else, I can put this onto peer review.

Thanks!

@bfallonf bfallonf changed the title [do not merge] Edits to architecture/core_objects/builds file [peer review] Edits to architecture/core_objects/builds file Jun 2, 2015
@adellape
Copy link
Contributor

adellape commented Jun 2, 2015

LGTM, merging.

@adellape adellape changed the title [peer review] Edits to architecture/core_objects/builds file Edits to architecture/core_objects/builds file Jun 2, 2015
adellape added a commit that referenced this pull request Jun 2, 2015
Edits to architecture/core_objects/builds file
@adellape adellape merged commit 48688e5 into openshift:master Jun 2, 2015
@bfallonf bfallonf deleted the pull_secrets branch June 2, 2015 23:46
sbeskin-redhat pushed a commit to sbeskin-redhat/openshift-docs that referenced this pull request Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants