Skip to content

Use bundle-secret for Secret creation#431

Merged
adellape merged 1 commit intoopenshift:masterfrom
mfojtik:secrets-fix
Jun 5, 2015
Merged

Use bundle-secret for Secret creation#431
adellape merged 1 commit intoopenshift:masterfrom
mfojtik:secrets-fix

Conversation

@mfojtik
Copy link
Contributor

@mfojtik mfojtik commented Jun 2, 2015

The secrets creation for Pull/PushSecret just get much easier.

@bparees @adellape PTAL

@adellape
Copy link
Contributor

adellape commented Jun 2, 2015

Rebase needed per #405.

@mfojtik
Copy link
Contributor Author

mfojtik commented Jun 2, 2015

@adellape hopefully I haven't nuked anything important :-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wouldn't nuke this, it's still important background about secrets.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

un-nuked :)

@adellape
Copy link
Contributor

adellape commented Jun 2, 2015

Should the "Using Private Repositories for Builds" section in this topic get a similar treatment in the secret-related spots?

Also, do we know if/when bundle-secret is getting pulled into osc proper? Or might it still be only available via openshift ex by GA?

@bparees
Copy link
Contributor

bparees commented Jun 2, 2015

Should the "Using Private Repositories for Builds" section in this topic get a similar treatment in the secret- related spots?

@adellape yes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ncdc just want to double check I'm not telling lies here :-)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct

@mfojtik
Copy link
Contributor Author

mfojtik commented Jun 4, 2015

@bparees @adellape is there something missing or good for merge? (i can do follow up for other places where we do need to mention bundle-secret)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link is messed up.

@adellape
Copy link
Contributor

adellape commented Jun 4, 2015

@mfojtik Couple minor bits inline, but I'm fine to merge otherwise, unless @bparees has other comments. I'm assuming we can take care of the thread about service account creds in a service accounts-related PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

little more detail on what this does please...
"generates json describing a secret named 'dockerhub' and then passes it to osc create which will define the new secret object in your current namespace"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, thanks!

@bparees
Copy link
Contributor

bparees commented Jun 4, 2015

@mfojtik one more nit and i think this is good, with the caveat that we need a follow-on to explain how the service account auto-auth logic works.

@mfojtik
Copy link
Contributor Author

mfojtik commented Jun 4, 2015

@adellape thanks! hopefully fixed all bits

@adellape
Copy link
Contributor

adellape commented Jun 4, 2015

@mfojtik Thanks, will merge after build passes.

adellape added a commit that referenced this pull request Jun 5, 2015
Use bundle-secret for Secret creation
@adellape adellape merged commit 65b78bc into openshift:master Jun 5, 2015
@mfojtik mfojtik deleted the secrets-fix branch August 25, 2015 09:39
sbeskin-redhat pushed a commit to sbeskin-redhat/openshift-docs that referenced this pull request Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants