Skip to content

Secure vs insecure image pruning#4471

Merged
ahardin-rh merged 1 commit intoopenshift:masterfrom
miminar:secure-image-pruning
Oct 5, 2017
Merged

Secure vs insecure image pruning#4471
ahardin-rh merged 1 commit intoopenshift:masterfrom
miminar:secure-image-pruning

Conversation

@miminar
Copy link

@miminar miminar commented May 24, 2017

Document new options related to secure connection to integrated docker registry and a mechanism that decides whether to fall-back to insecure connection.

Resolves #4232
Resolves bz#1469654

Is blocked on openshift/origin#14114? No longer blocked.

@miminar
Copy link
Author

miminar commented May 24, 2017

@legionus PTAL

@miminar
Copy link
Author

miminar commented May 31, 2017

@soltysh PTAL

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xref:using-insecure-connection-against-secured-registry[the one below]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

`certificate-authority`
`registry-url`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

`prune` command

s/with error similar to/with an error similar to

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/config/configuration file
s/-/--

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move the code block to just before "By default...." so that the first sentence does not get broken up.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

registry, but

Copy link
Contributor

@ahardin-rh ahardin-rh Jun 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can use a discrete heading here instead?

Copy link
Contributor

@ahardin-rh ahardin-rh Jun 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can use a discrete heading here instead?

Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left you some comments.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd move the last sentence as a NOTE below. Additionally, reword this to something like:

Whenever possible use --certificate-authority, instead. Use of this option is strongly discouraged.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've ditched it. There is plenty of other places advocating the same. Instead, I've put (Dangerous) at the beginning.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't encourage using --force-insecure anywhere, so drop the last sentence. It's already explained and that's it, it should not be used anywhere, though.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:
The secure connection is the preferred and recommended approach.

It's the recommended as a rule, not only for production.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/following/the following

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

following cases , unless

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add info in parenthesis this is not recommended.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add not recommended at the end in parens.

@miminar miminar changed the title Secure vs insecure image pruning [DO NOT MERGE] Secure vs insecure image pruning Jun 5, 2017
@miminar
Copy link
Author

miminar commented Jun 5, 2017

Now blocked on openshift/origin#14405. I will need to update error messages once it lands.

@miminar
Copy link
Author

miminar commented Jun 27, 2017

Now blocked on openshift/origin#14914

@miminar miminar force-pushed the secure-image-pruning branch 2 times, most recently from 1bb8a53 to cecc1f6 Compare July 11, 2017 11:53
@miminar
Copy link
Author

miminar commented Jul 11, 2017

Thanks for all the comments. They should be addressed now. The dependency PR is still waiting for the unblocked merge queue.

@miminar miminar force-pushed the secure-image-pruning branch from cecc1f6 to d82651d Compare October 3, 2017 13:28
@miminar miminar changed the title [DO NOT MERGE] Secure vs insecure image pruning Secure vs insecure image pruning Oct 3, 2017
@miminar
Copy link
Author

miminar commented Oct 3, 2017

No longer blocked. @ahardin-rh could you please review once more?

@miminar miminar force-pushed the secure-image-pruning branch from d82651d to 3b0ca97 Compare October 3, 2017 13:30
@miminar
Copy link
Author

miminar commented Oct 3, 2017

I'd like to make some corrections for earlier releases. Shall I re-open this against enterprise-3.6 and enterprise-3.5?

@bparees
Copy link
Contributor

bparees commented Oct 3, 2017

@miminar if we label this PR for 3.5 and 3.6, the changes will be applied there.

if 3.5 and 3.6 need a different set of doc, then you'll need to open a separate PR and only label it for 3.5 and 3.6.

@bparees
Copy link
Contributor

bparees commented Oct 3, 2017

@miminar so which versions is this specific PR appropriate for?

@bparees bparees self-assigned this Oct 3, 2017
@miminar
Copy link
Author

miminar commented Oct 4, 2017

@bparees 3.6 - latest; I'll re-submit new PRs for 3.4 and 3.5

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Images Not Being Pruned

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a Secure Connection Against an Insecure Registry

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you see a message similar to the following in the output of the oadm prune images command, then your registry is not secured and the oadm prune images client will attempt to use a secure connection:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can force the client to use an insecure

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using an Insecure Connection Against a Secured Registry

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the Wrong Certificate Authority

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that the certificate

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

different than

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docker registry

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be added instead

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docker registry

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docker registry

@ahardin-rh
Copy link
Contributor

@miminar Thanks! Just a few minor comments from me.

Just a heads-up that, given our new docs workflow, if you want to submit separate PRs for 3.4 and 3.5, be sure to do so against enterprise-3.4-stage and enterprise-3.5-stage respectively. Thanks again!

@miminar
Copy link
Author

miminar commented Oct 5, 2017

@ahardin-rh thanks a lot! Comments should be addressed now.

Document new options related to secure connection to integrated docker
registry and a mechanism that decides whether to fall-back to insecure
connection.

Signed-off-by: Michal Minář <miminar@redhat.com>
@ahardin-rh
Copy link
Contributor

@miminar Excellent. Thank you!

@ahardin-rh ahardin-rh merged commit 999c346 into openshift:master Oct 5, 2017
@ahardin-rh
Copy link
Contributor

[rev_history]
|xref:../admin_guide/pruning_resources.adoc#admin-guide-pruning-resources[Pruning Objects]
|Added details on secure versus insecure image pruning.
%

@adellape adellape modified the milestones: Next Release, Staging Oct 9, 2017
@vikram-redhat vikram-redhat modified the milestones: Staging, Published - 10/11/2017 Oct 12, 2017
@miminar miminar deleted the secure-image-pruning branch December 3, 2017 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants