[3.5] Secure vs insecure image pruning#5535
[3.5] Secure vs insecure image pruning#5535bmcelvee merged 1 commit intoopenshift:enterprise-3.5-stagefrom
Conversation
bparees
left a comment
bparees
left a comment
There was a problem hiding this comment.
a few nits, but you'll probably want to wait for @openshift/team-documentation to review as well and then make all the same changes to your 3.4 PR.
admin_guide/pruning_resources.adoc
Outdated
admin_guide/pruning_resources.adoc
Outdated
admin_guide/pruning_resources.adoc
Outdated
There was a problem hiding this comment.
"then your registry is not secured and the oadm prune images client
will attempt to use secure connection"
should be
"then your registry is not secured and the oadm prune images client
attempted to use secure connection" ?
admin_guide/pruning_resources.adoc
Outdated
admin_guide/pruning_resources.adoc
Outdated
There was a problem hiding this comment.
we probably shouldn't be documenting bugs (especially ones that are fixed) in our official documentation.
admin_guide/pruning_resources.adoc
Outdated
admin_guide/pruning_resources.adoc
Outdated
There was a problem hiding this comment.
the registry's service account name
|
@openshift/team-documentation ptal |
admin_guide/pruning_resources.adoc
Outdated
There was a problem hiding this comment.
We may want to add an additional warning for this option following the table. @bparees what do you think?
There was a problem hiding this comment.
I believe I've covered the danger in the [pruning-images-secure-or-insecure] section which is already recommended to read. I would rather refrain from clogging the doc with redundant information.
admin_guide/pruning_resources.adoc
Outdated
There was a problem hiding this comment.
s/an alternative route that works needs to be provided using this flag/use this flag to provide an alternate route.
Document new options related to secure connection to integrated docker registry and a mechanism that decides whether to fall-back to insecure connection. Signed-off-by: Michal Minář <miminar@redhat.com>
miminar
force-pushed
the
secure-image-pruning-3.5
branch
from
a1ae9d4 to
683cc46
Compare
|
Thank you! Comments addressed. If approved, I'll apply the changes to 3.4 as well. |
|
@bmcelvee nope |
|
[rev_history] |
5 participants
Document new options related to secure connection to integrated docker
registry and a mechanism that decides whether to fall-back to insecure
connection.
Backports #4471