Skip to content

OSDOCS4041: Support Windows Containers on GCP -- WMCO 7.0.0#49719

Merged
mburke5678 merged 1 commit into
openshift:mainfrom
mburke5678:winc-add-gcp
Jan 27, 2023
Merged

OSDOCS4041: Support Windows Containers on GCP -- WMCO 7.0.0#49719
mburke5678 merged 1 commit into
openshift:mainfrom
mburke5678:winc-add-gcp

Conversation

@mburke5678
Copy link
Copy Markdown
Contributor

@mburke5678 mburke5678 commented Aug 29, 2022 •
edited
Loading

https://issues.redhat.com/browse/OSDOCS-4041

Previews:
Creating a Windows MachineSet object on GCP Intro and the Sample YAML for a Windows MachineSet object on GCP
module. The other modules are existing and repreated in all Creating a Windows MachineSet assemblies.

WMCO 7.0.0 supported platforms and Windows Server versions -- Added GCP to table

@mburke5678 mburke5678 added this to the Planned for 4.12 GA milestone Aug 29, 2022
@openshift-ci openshift-ci Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 29, 2022
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 4, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 19, 2022
@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Sep 19, 2022

@sebsoto Are OK to review my PR at this time? I know we might have to revisit pending the outcome of https://issues.redhat.com/browse/OCPCLOUD-1533

@ocpdocs-previewbot
Copy link
Copy Markdown

ocpdocs-previewbot commented Sep 19, 2022 •
edited
Loading

🤖 Updated build preview is available at:
https://49719--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/4340

@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Sep 27, 2022

@sebsoto @jrvaldes PTAL

elmiko
elmiko reviewed Sep 28, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2022
@jrvaldes jrvaldes mentioned this pull request Sep 29, 2022
Merged
jrvaldes
jrvaldes reviewed Sep 29, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@jrvaldes jrvaldes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor suggestion.

@mburke5678 thanks for working on this.

Comment thread modules/windows-machineset-gcp.adoc Outdated
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2022
@jfrancoa
Copy link
Copy Markdown

jfrancoa commented Oct 3, 2022

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2022
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2022
@mburke5678 mburke5678 added peer-review-needed Signifies that the peer review team needs to review this PR lgtm Indicates that a PR is ready to be merged. labels Oct 4, 2022
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Oct 4, 2022

New changes are detected. LGTM label has been removed.

@jldohmann
Copy link
Copy Markdown
Contributor

jldohmann commented Oct 4, 2022

/label peer-review-in-progress

@openshift-ci openshift-ci Bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Oct 4, 2022
jldohmann
jldohmann reviewed Oct 4, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@jldohmann jldohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looking good! Feedback below

Comment thread modules/windows-machineset-gcp.adoc Outdated
Comment thread windows_containers/creating_windows_machinesets/creating-windows-machineset-gcp.adoc Outdated
Comment thread windows_containers/creating_windows_machinesets/creating-windows-machineset-gcp.adoc Outdated
@jldohmann
Copy link
Copy Markdown
Contributor

jldohmann commented Oct 4, 2022

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci Bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 4, 2022
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2022
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Oct 4, 2022

New changes are detected. LGTM label has been removed.

@mburke5678 mburke5678 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2022
@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Oct 4, 2022 •
edited
Loading

DO NOT MERGE until https://issues.redhat.com/browse/WINC-815 is merged

@mburke5678 mburke5678 changed the title OSDOCS4041: Support Windows Containers on GCP OSDOCS4041: Support Windows Containers on GCP -- WMCO 7.0.0 Oct 26, 2022
@mburke5678 mburke5678 changed the title OSDOCS4041: Support Windows Containers on GCP -- WMCO 7.0.0 HOLD: OSDOCS4041: Support Windows Containers on GCP -- WMCO 7.0.0 Nov 30, 2022
@mburke5678 mburke5678 changed the title HOLD: OSDOCS4041: Support Windows Containers on GCP -- WMCO 7.0.0 OSDOCS4041: Support Windows Containers on GCP -- WMCO 7.0.0 Dec 2, 2022
@mburke5678 mburke5678 changed the title OSDOCS4041: Support Windows Containers on GCP -- WMCO 7.0.0 HOLD: OSDOCS4041: Support Windows Containers on GCP -- WMCO 7.0.0 Dec 2, 2022
@bergerhoffer
Copy link
Copy Markdown
Contributor

bergerhoffer commented Jan 16, 2023

The branch/enterprise-4.13 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.12. And any PR going into main must also target the latest version branch (enterprise-4.13).

If the update in your PR does NOT apply to version 4.13 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

@mburke5678 mburke5678 merged commit 580561f into openshift:main Jan 27, 2023
@mburke5678 mburke5678 deleted the winc-add-gcp branch January 27, 2023 21:13
@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Jan 27, 2023

/cherrypick enterprise-4.13

@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Jan 27, 2023

@mburke5678: new pull request created: #55286

Details

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 27, 2023
Merged
@mburke5678 mburke5678 mentioned this pull request Jan 27, 2023
Closed
@mburke5678 mburke5678 changed the title HOLD: OSDOCS4041: Support Windows Containers on GCP -- WMCO 7.0.0 OSDOCS4041: Support Windows Containers on GCP -- WMCO 7.0.0 Jan 30, 2023
@mburke5678 mburke5678 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 30, 2023
@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Jan 30, 2023

/cherrypick enterprise-4.12

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 30, 2023
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Jan 30, 2023

@mburke5678: new pull request created: #55325

Details

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jldohmann jldohmann jldohmann left review comments

+2 more reviewers

@elmiko elmiko elmiko left review comments

@jrvaldes jrvaldes jrvaldes left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@elmiko elmiko

@jfrancoa jfrancoa

Labels

branch/enterprise-4.12 branch/enterprise-4.13 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

10 participants

@mburke5678 @ocpdocs-previewbot @jfrancoa @jldohmann @bergerhoffer @openshift-cherrypick-robot @elmiko @jrvaldes @openshift-merge-robot @kalexand-rh