Point MachineSet references to the official documentation in the Red Hat released CSV by jrvaldes · Pull Request #1232 · openshift/windows-machine-config-operator

jrvaldes · 2022-09-02T13:54:09Z

This change links the MachineSet references in the Red Hat released CSV to
the official OpenShift docs, so that the Red Hat released operator in the
OperatorHub for OCP points to the appropriated documentation. The links to
the WMCO repository in GitHub remain as supporting information for the
community released CSV.

Ran:

  make bundle

openshift-ci · 2022-09-02T13:54:18Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

jrvaldes · 2022-09-02T15:09:45Z

/hold

depends on #1230 to unblock CI

openshift-cherrypick-robot · 2022-09-02T15:11:09Z

@jrvaldes: once the present PR merges, I will cherry-pick it on top of release-4.11 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

saifshaikh48 · 2022-09-02T15:56:21Z

/lgtm

aravindhp · 2022-09-02T16:02:26Z

    Example MachineSet for other cloud providers:
-    - [AWS](https://github.com/openshift/windows-machine-config-operator/blob/master/docs/machineset-aws.md)
-    - [Azure](https://github.com/openshift/windows-machine-config-operator/blob/master/docs/machineset-azure.md)
+    - [AWS](https://docs.openshift.com/container-platform/4.11/windows_containers/creating_windows_machinesets/creating-windows-machineset-aws.html)


Do we have a stance on what these links should be for the community vs Red Hat operator?

I think we said community docs should link to our github repo, but @openshift/openshift-team-windows-containers please confirm

Do we have a stance on what these links should be for the community vs Red Hat operator?

Not sure if we discussed community doc links in the past. My two cents:

Links for Red Hat operator should point to official docs

Links for the community may also point to the latest official docs (less maintenance). GitHub may be fine too.

We have been pointing to github docs for community operator and official docs for RH operator.

We have been pointing to github docs for community operator and official docs for RH opera

This is the correct approach. We should not link the community CSV to the official docs. It is not about maintenance but about being able to release features quicker that won't have official docs.

Why are we updating this? Is this so that OpenShift docs are reflected in the Red Hat operator?

To use OpenShift docs in the Red Hat operator CSV

Then please call that out. Our PRs and commits should say WHAT is being done and WHY. I am noticing quite a few commits where the WHY is missing.

Thanks for highlighting this. Commit message updated.

jrvaldes · 2022-09-28T19:44:52Z

/hold cancel

saifshaikh48 · 2022-09-28T20:26:46Z

/lgtm

jrvaldes · 2022-09-29T17:05:47Z

-    - [GCP](https://github.com/openshift/windows-machine-config-operator/blob/master/docs/machineset-gcp.md)
+    - [AWS](https://docs.openshift.com/container-platform/4.12/windows_containers/creating_windows_machinesets/creating-windows-machineset-aws.html)
+    - [Azure](https://docs.openshift.com/container-platform/4.12/windows_containers/creating_windows_machinesets/creating-windows-machineset-azure.html)
+    - [GCP](https://docs.openshift.com/container-platform/4.12/windows_containers/creating_windows_machinesets/creating-windows-machineset-gcp.html)


creating-windows-machineset-gcp.html is proposed in openshift/openshift-docs#49719

openshift-ci · 2022-09-29T17:26:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aravindhp, jrvaldes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [aravindhp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This change links the MachineSet references in the Red Hat released CSV to the official OpenShift docs, so that the Red Hat released operator in the OperatorHub for OCP points to the appropriated documentation. The links to the WMCO repository in GitHub remain as supporting information for the community released CSV. Ran: make bundle

jrvaldes · 2022-10-03T12:41:27Z

/test gcp-e2e-operator

Failed deprovisioning cluster

aravindhp · 2022-10-03T17:25:52Z

/override ci/prow/gcp-e2e-operator

openshift-ci · 2022-10-03T17:26:33Z

@aravindhp: Overrode contexts on behalf of aravindhp: ci/prow/gcp-e2e-operator

Details

In response to this:

/override ci/prow/gcp-e2e-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-10-03T17:26:39Z

@jrvaldes: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

sebsoto · 2022-10-03T18:45:29Z

/lgtm

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2022

jrvaldes force-pushed the fix-csv-links branch from 32986d8 to 6f552df Compare September 2, 2022 13:54

jrvaldes marked this pull request as ready for review September 2, 2022 15:09

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2022

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 2, 2022

openshift-ci Bot requested review from mansikulkarni96 and sebsoto September 2, 2022 15:09

openshift-ci Bot assigned saifshaikh48 Sep 2, 2022

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2022

aravindhp reviewed Sep 2, 2022

View reviewed changes

saifshaikh48 mentioned this pull request Sep 6, 2022

[bundle] Add support for GCP in CSV #1236

Merged

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2022

jrvaldes force-pushed the fix-csv-links branch from 6f552df to 9793968 Compare September 28, 2022 19:27

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2022

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 28, 2022

jrvaldes changed the title ~~[deploy] Update links to official docs~~ Point MachineSet references to the official documentation in the CSV Sep 28, 2022

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 28, 2022

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2022

jrvaldes changed the title ~~Point MachineSet references to the official documentation in the CSV~~ Point MachineSet references to the official documentation in the Red Hat released CSV Sep 29, 2022

jrvaldes force-pushed the fix-csv-links branch from 9793968 to 84449ae Compare September 29, 2022 00:58

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2022

jrvaldes commented Sep 29, 2022

View reviewed changes

aravindhp approved these changes Sep 29, 2022

View reviewed changes

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2022

jrvaldes force-pushed the fix-csv-links branch from 84449ae to d552ac1 Compare October 2, 2022 04:10

openshift-ci Bot assigned sebsoto Oct 3, 2022

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2022

openshift-merge-robot merged commit 01499ac into openshift:master Oct 3, 2022

Conversation

jrvaldes commented Sep 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Sep 2, 2022

Uh oh!

jrvaldes commented Sep 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-cherrypick-robot commented Sep 2, 2022

Uh oh!

saifshaikh48 commented Sep 2, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mansikulkarni96 Sep 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jrvaldes commented Sep 28, 2022

Uh oh!

saifshaikh48 commented Sep 28, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Sep 29, 2022

Uh oh!

jrvaldes commented Oct 3, 2022

Uh oh!

aravindhp commented Oct 3, 2022

Uh oh!

openshift-ci Bot commented Oct 3, 2022

Uh oh!

openshift-ci Bot commented Oct 3, 2022

Uh oh!

sebsoto commented Oct 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

jrvaldes commented Sep 2, 2022 •

edited

Loading

jrvaldes commented Sep 2, 2022 •

edited

Loading

mansikulkarni96 Sep 2, 2022 •

edited

Loading