Skip to content

[bundle] Add support for GCP in CSV#1236

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
jrvaldes:bundle-gcp
Sep 20, 2022
Merged

[bundle] Add support for GCP in CSV#1236
openshift-merge-robot merged 1 commit into
openshift:masterfrom
jrvaldes:bundle-gcp

Conversation

@jrvaldes
Copy link
Copy Markdown
Contributor

@jrvaldes jrvaldes commented Sep 4, 2022

This change introduces GCP as a supported platform
in the description of the CSV.

Follow-up to:

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 4, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 4, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jrvaldes
Copy link
Copy Markdown
Contributor Author

jrvaldes commented Sep 6, 2022 •
edited
Loading

Should go after #1237 to accommodate the correct OCP version.

saifshaikh48
saifshaikh48 reviewed Sep 6, 2022
View reviewed changes
Comment thread bundle/manifests/windows-machine-config-operator.clusterserviceversion.yaml
Example MachineSet for other cloud providers:
- [AWS](https://github.com/openshift/windows-machine-config-operator/blob/master/docs/machineset-aws.md)
- [Azure](https://github.com/openshift/windows-machine-config-operator/blob/master/docs/machineset-azure.md)
- [GCP](https://github.com/openshift/windows-machine-config-operator/blob/master/docs/machineset-gcp.md)
Copy link
Copy Markdown
Contributor

@saifshaikh48 saifshaikh48 Sep 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The consensus in #1232 was to point to official OCP docs over github. Does it make sense to wait for GCP support to be published and point there?

Copy link
Copy Markdown
Contributor

@aravindhp aravindhp Sep 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The consensus in #1232 was to NOT point to the official OCP docs over GitHub. We should update the docs only when releasing the community operator with GCP support.

sebsoto
sebsoto reviewed Sep 12, 2022
View reviewed changes
Comment thread bundle/manifests/windows-machine-config-operator.clusterserviceversion.yaml Outdated
### Pre-requisites
* A Red Hat OpenShift Container Platform for Windows Containers [subscription](https://access.redhat.com/support/policy/updates/openshift#windows)
* OCP 4.11 cluster running on Azure, AWS or vSphere configured with hybrid OVN Kubernetes networking
* OCP 4.11 cluster running on Azure, AWS, GCP or vSphere configured with hybrid OVN Kubernetes networking
Copy link
Copy Markdown
Contributor

@sebsoto sebsoto Sep 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GCP is not supported on 4.11

Copy link
Copy Markdown
Contributor Author

@jrvaldes jrvaldes Sep 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. See #1236 (comment)

Comment thread config/manifests/bases/windows-machine-config-operator.clusterserviceversion.yaml Outdated
### Pre-requisites
* A Red Hat OpenShift Container Platform for Windows Containers [subscription](https://access.redhat.com/support/policy/updates/openshift#windows)
* OCP 4.11 cluster running on Azure, AWS or vSphere configured with hybrid OVN Kubernetes networking
* OCP 4.11 cluster running on Azure, AWS, GCP or vSphere configured with hybrid OVN Kubernetes networking
Copy link
Copy Markdown
Contributor

@sebsoto sebsoto Sep 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GCP is not supported on 4.11

@jrvaldes jrvaldes changed the title WINC-815: Add support for GCP in CSV [bundle] Add support for GCP in CSV Sep 12, 2022
@jrvaldes
[bundle] Add support for GCP in CSV
0918f36 
This change introduces GCP as a supported platform
in the description of the CSV.

Ran:
```
  make update
```
@jrvaldes
Copy link
Copy Markdown
Contributor Author

jrvaldes commented Sep 15, 2022

/hold cancel

Blocking PR merged:

@jrvaldes jrvaldes marked this pull request as ready for review September 15, 2022 03:27
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 15, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aravindhp, jrvaldes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2022
@sebsoto
Copy link
Copy Markdown
Contributor

sebsoto commented Sep 15, 2022

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2022
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 15, 2022

/retest-required

Remaining retests: 0 against base HEAD 435fa06 and 2 for PR HEAD 0918f36 in total

@jrvaldes
Copy link
Copy Markdown
Contributor Author

jrvaldes commented Sep 20, 2022

/test azure-e2e-operator

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 20, 2022

@jrvaldes: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 14c47b9 into openshift:master Sep 20, 2022
@jrvaldes jrvaldes deleted the bundle-gcp branch August 8, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mansikulkarni96 mansikulkarni96 Awaiting requested review from mansikulkarni96

3 more reviewers

@sebsoto sebsoto sebsoto left review comments

@saifshaikh48 saifshaikh48 saifshaikh48 left review comments

@aravindhp aravindhp aravindhp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sebsoto sebsoto

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jrvaldes @sebsoto @openshift-ci-robot @aravindhp @saifshaikh48 @openshift-merge-robot