OSDOCS-5562: update info about default LVMS behavior by dhellmann · Pull Request #57417 · openshift/openshift-docs

dhellmann · 2023-03-20T14:38:18Z

Version(s): 4.13+

Issue: OCPBUGS-10242

Link to docs preview:
https://57417--docspreview.netlify.app/microshift/latest/microshift_storage/microshift-storage-plugin-overview.html#lvms-volume-group-name_microshift-storage-plugin-overview for the main change
https://57417--docspreview.netlify.app/microshift/latest/microshift_storage/microshift-storage-plugin-overview.html#using-lvms_microshift-storage-plugin-overview for the command change

QE review:

QE has approved this change.

openshift-ci-robot · 2023-03-20T14:39:04Z

@dhellmann: This pull request references Jira Issue OCPBUGS-10242, which is invalid:

expected the bug to target the "4.14.0" version, but it targets "4.13.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-03-20T14:39:32Z

@dhellmann: This pull request references Jira Issue OCPBUGS-10242, which is invalid:

expected the bug to target the "4.14.0" version, but it targets "4.13.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Version(s): 4.14, 4.13

Issue: OCPBUGS-10242

Link to docs preview:

QE review:

QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dhellmann · 2023-03-20T14:40:07Z

/hold

This should wait for openshift/microshift#1530

openshift-ci-robot · 2023-03-20T14:42:14Z

@dhellmann: This pull request references OSDOCS-5562 which is a valid jira issue.

Details

In response to this:

Version(s): 4.14, 4.13

Issue: OCPBUGS-10242

Link to docs preview:

QE review:

QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ocpdocs-previewbot · 2023-03-20T14:50:45Z

🤖 Updated build preview is available at:
https://57417--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/12206

openshift-ci-robot · 2023-03-20T19:28:09Z

@dhellmann: This pull request references OSDOCS-5562 which is a valid jira issue.

Details

In response to this:

Version(s): 4.13+

Issue: OCPBUGS-10242

Link to docs preview:

QE review:

QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dhellmann · 2023-03-20T19:28:26Z

@ShaunaDiaz updated to incorporate your suggestions.

openshift-ci-robot · 2023-03-21T19:21:01Z

@dhellmann: This pull request references OSDOCS-5562 which is a valid jira issue.

Details

In response to this:

Version(s): 4.13+

Issue: OCPBUGS-10242

Link to docs preview:
https://57417--docspreview.netlify.app/microshift/latest/microshift_storage/microshift-storage-plugin-overview.html#lvms-volume-group-name_microshift-storage-plugin-overview for the main change
https://57417--docspreview.netlify.app/microshift/latest/microshift_storage/microshift-storage-plugin-overview.html#using-lvms_microshift-storage-plugin-overview for the command change

QE review:

QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dhellmann · 2023-03-21T19:21:23Z

/hold cancel

@ShaunaDiaz this PR is ready to go through the review process, the code has landed

ShaunaDiaz · 2023-03-22T17:21:13Z

/label peer-review-needed

JoeAldinger · 2023-03-22T18:42:54Z

/remove-label peer-review-needed
/label peer-review-in-progress

JoeAldinger

Small organization suggestion.

JoeAldinger · 2023-03-23T18:59:14Z

/remove-label peer-review-in-progress
/label peer-review-done

dhellmann · 2023-03-23T20:37:05Z

Squashed and rebased

kalexand-rh · 2023-03-27T12:47:44Z

@dhellmann, please squash your commits. Is this PR ready for merge review?

dhellmann · 2023-03-27T13:17:46Z

@dhellmann, please squash your commits. Is this PR ready for merge review?

The 2 commits aren't related, so I left them separate. I can squash if you prefer, though. And yes, once that's settled this is ready for merge review.

Update the description of the logic to match the changes for OCPBUGS-10242 in openshift/microshift#1530 clean up syntax of command for using LVMS Signed-off-by: Doug Hellmann <dhellmann@redhat.com>

dhellmann · 2023-03-27T13:22:57Z

/label merge-review-needed

mburke5678 · 2023-03-27T14:41:06Z

/cherrypick enterprise-4.13

openshift-cherrypick-robot · 2023-03-27T14:41:51Z

@mburke5678: new pull request created: #57790

Details

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dhellmann changed the title ~~~~ OCPBUGS-10242: update info about default LVMS behavior Mar 20, 2023

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 20, 2023

openshift-ci Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 20, 2023

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 20, 2023

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2023

dhellmann changed the title ~~OCPBUGS-10242: update info about default LVMS behavior~~ OSDOCS-5562: update info about default LVMS behavior Mar 20, 2023

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 20, 2023

dhellmann force-pushed the lvms-config-changes branch from c795c6d to b32e447 Compare March 20, 2023 15:04

ShaunaDiaz reviewed Mar 20, 2023

View reviewed changes

Comment thread modules/microshift-lvms-system-requirements.adoc Outdated

dhellmann force-pushed the lvms-config-changes branch from 1494dcb to ad837d0 Compare March 20, 2023 19:28

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2023

openshift-ci Bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 22, 2023

openshift-ci Bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 22, 2023

JoeAldinger reviewed Mar 23, 2023

View reviewed changes

Comment thread modules/microshift-lvms-system-requirements.adoc Outdated

JoeAldinger reviewed Mar 23, 2023

View reviewed changes

openshift-ci Bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 23, 2023

openshift-ci Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 23, 2023

dhellmann force-pushed the lvms-config-changes branch from e81c59a to 853f725 Compare March 23, 2023 20:36

Update info on default VG selection by LVMS

a40173c

Update the description of the logic to match the changes for OCPBUGS-10242 in openshift/microshift#1530 clean up syntax of command for using LVMS Signed-off-by: Doug Hellmann <dhellmann@redhat.com>

dhellmann force-pushed the lvms-config-changes branch from 853f725 to a40173c Compare March 27, 2023 13:22

openshift-ci Bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 27, 2023

mburke5678 added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Mar 27, 2023

mburke5678 added this to the Planned for 4.13 GA milestone Mar 27, 2023

mburke5678 merged commit 573ff6c into openshift:main Mar 27, 2023

openshift-cherrypick-robot mentioned this pull request Mar 27, 2023

[enterprise-4.13] OSDOCS-5562: update info about default LVMS behavior #57790

Merged

dhellmann mentioned this pull request Mar 27, 2023

OSDOCS-5563: add release note for LVMS configuration change #57829

Merged

Conversation

dhellmann commented Mar 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 20, 2023

Uh oh!

openshift-ci-robot commented Mar 20, 2023

Uh oh!

dhellmann commented Mar 20, 2023

Uh oh!

openshift-ci-robot commented Mar 20, 2023 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ocpdocs-previewbot commented Mar 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 20, 2023 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dhellmann commented Mar 20, 2023

Uh oh!

openshift-ci-robot commented Mar 21, 2023 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dhellmann commented Mar 21, 2023

Uh oh!

ShaunaDiaz commented Mar 22, 2023

Uh oh!

JoeAldinger commented Mar 22, 2023

Uh oh!

Uh oh!

JoeAldinger left a comment

Choose a reason for hiding this comment

Uh oh!

JoeAldinger commented Mar 23, 2023

Uh oh!

dhellmann commented Mar 23, 2023

Uh oh!

kalexand-rh commented Mar 27, 2023

Uh oh!

dhellmann commented Mar 27, 2023

Uh oh!

dhellmann commented Mar 27, 2023

Uh oh!

mburke5678 commented Mar 27, 2023

Uh oh!

openshift-cherrypick-robot commented Mar 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

dhellmann commented Mar 20, 2023 •

edited

Loading

openshift-ci-robot commented Mar 20, 2023 •

edited by openshift-ci Bot

Loading

ocpdocs-previewbot commented Mar 20, 2023 •

edited

Loading

openshift-ci-robot commented Mar 20, 2023 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Mar 21, 2023 •

edited by openshift-ci Bot

Loading