OSDOCS-5563: add release note for LVMS configuration change by dhellmann · Pull Request #57829 · openshift/openshift-docs

dhellmann · 2023-03-27T19:46:37Z

Version(s): 4.13

Link to docs preview:
https://57829--docspreview.netlify.app/microshift/latest/microshift_release_notes/microshift-4-13-release-notes.html#microshift-4-13-storage

QE review: N/A

Additional information:

See #57417 for the original documentation update.

/assign @ShaunaDiaz

openshift-ci-robot · 2023-03-27T19:46:41Z

@dhellmann: This pull request references OSDOCS-5562 which is a valid jira issue.

Details

In response to this:

Version(s): 4.13

Issue: OSDOCS-5562

Link to docs preview:

QE review:

QE has approved this change.

Additional information:

See #57417 for the original documentation update.

/assign @ShaunaDiaz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-03-27T19:46:45Z

@dhellmann: This pull request references OSDOCS-5562 which is a valid jira issue.

Details

In response to this:

Version(s): 4.13

Issue: OSDOCS-5562

Link to docs preview:

QE review:

QE has approved this change.

Additional information:

See #57417 for the original documentation update.

/assign @ShaunaDiaz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-03-27T19:52:25Z

@dhellmann: No Jira issue with key OSDOCS-55623 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

Details

In response to this:

Version(s): 4.13

Issue: OSDOCS-5562

Link to docs preview:

QE review:

QE has approved this change.

Additional information:

See #57417 for the original documentation update.

/assign @ShaunaDiaz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-03-27T19:52:41Z

@dhellmann: This pull request references OSDOCS-5563 which is a valid jira issue.

Details

In response to this:

Version(s): 4.13

Issue: OSDOCS-5562

Link to docs preview:

QE review:

QE has approved this change.

Additional information:

See #57417 for the original documentation update.

/assign @ShaunaDiaz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dhellmann · 2023-03-27T19:57:09Z

@ShaunaDiaz I've updated to include your edits.

dhellmann · 2023-03-27T22:24:52Z

Updated and squashed

ocpdocs-previewbot · 2023-03-28T18:29:49Z

🤖 Updated build preview is available at:
https://57829--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/12464

openshift-ci-robot · 2023-03-28T18:32:08Z

@dhellmann: This pull request references OSDOCS-5563 which is a valid jira issue.

Details

In response to this:

Version(s): 4.13

Issue: OSDOCS-5562

Link to docs preview:
https://57829--docspreview.netlify.app/microshift/latest/microshift_release_notes/microshift-4-13-release-notes.html#microshift-4-13-storage

QE review:

QE has approved this change.

Additional information:

See #57417 for the original documentation update.

/assign @ShaunaDiaz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-03-28T18:38:41Z

@dhellmann: This pull request references OSDOCS-5563 which is a valid jira issue.

Details

In response to this:

Version(s): 4.13

Issue: OSDOCS-5562

Link to docs preview:
https://57829--docspreview.netlify.app/microshift/latest/microshift_release_notes/microshift-4-13-release-notes.html#microshift-4-13-storage

QE review: N/A

Additional information:

See #57417 for the original documentation update.

/assign @ShaunaDiaz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dhellmann · 2023-03-28T18:40:04Z

/label

dhellmann · 2023-03-28T18:41:11Z

/label peer-review-needed

mburke5678 · 2023-03-28T18:49:09Z

+[id="microshift-4-13-storage"]
+=== Storage
+
+* {product-title} configures LVMS more dynamically based on the Volume Groups present. For more details, read the xref:../microshift_storage/microshift-storage-plugin-overview.adoc#lvms-volume-group-name_microshift-storage-plugin-overview[LVMS system requirements] section of this documentation.


Can you remove the more here_? I tripped over more dynamically based, reading it as more dynamically-based (if that makes sense).

mburke5678 · 2023-03-28T18:52:44Z

@dhellmann One tiny nit.
@ShaunaDiaz Where do you see that Volume Group is capitalized? A quick search in Atom shows the volume group predominantly used.

ShaunaDiaz · 2023-03-28T19:32:03Z

@mburke5678 I was looking at our parent assembly, the second-to-last sentence of the intro paragraphs:
"Each PVC references a storage class that represents an LVM Volume Group (VG) on the host node."
A lot of this boiler-plate assembly text is ye olde from OCP.

Signed-off-by: Doug Hellmann <dhellmann@redhat.com> Co-authored-by: Shauna Diaz <shdiaz@redhat.com>

dhellmann · 2023-03-28T20:31:08Z

@dhellmann One tiny nit.
@ShaunaDiaz Where do you see that Volume Group is capitalized? A quick search in Atom shows the volume group predominantly used.

Done

ShaunaDiaz · 2023-03-29T13:54:40Z

/label merge-review-needed

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 27, 2023

openshift-ci Bot assigned ShaunaDiaz Mar 27, 2023

openshift-ci Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 27, 2023

ShaunaDiaz reviewed Mar 27, 2023

View reviewed changes

Comment thread microshift_release_notes/microshift-4-13-release-notes.adoc

Comment thread microshift_release_notes/microshift-4-13-release-notes.adoc Outdated

dhellmann changed the title ~~OSDOCS-5562: add release note for LVMS configuration change~~ OSDOCS-55623: add release note for LVMS configuration change Mar 27, 2023

openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 27, 2023

dhellmann changed the title ~~OSDOCS-55623: add release note for LVMS configuration change~~ OSDOCS-5563: add release note for LVMS configuration change Mar 27, 2023

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 27, 2023

dhellmann force-pushed the OSDOCS-5562-lvms-release-note branch 2 times, most recently from 8dea2f1 to 4f5ef70 Compare March 27, 2023 19:56

ShaunaDiaz reviewed Mar 27, 2023

View reviewed changes

Comment thread microshift_release_notes/microshift-4-13-release-notes.adoc Outdated

dhellmann force-pushed the OSDOCS-5562-lvms-release-note branch from 7013fc8 to 7b2049c Compare March 27, 2023 22:24

ShaunaDiaz reviewed Mar 28, 2023

View reviewed changes

Comment thread microshift_release_notes/microshift-4-13-release-notes.adoc Outdated

dhellmann force-pushed the OSDOCS-5562-lvms-release-note branch from 7b2049c to 3a86577 Compare March 28, 2023 18:22

openshift-ci Bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 28, 2023

mburke5678 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Mar 28, 2023

mburke5678 reviewed Mar 28, 2023

View reviewed changes

mburke5678 removed the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Mar 28, 2023

mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 28, 2023

OSDOCS-5563: add release note for LVMS configuration change

61141cf

Signed-off-by: Doug Hellmann <dhellmann@redhat.com> Co-authored-by: Shauna Diaz <shdiaz@redhat.com>

dhellmann force-pushed the OSDOCS-5562-lvms-release-note branch from 3a86577 to 61141cf Compare March 28, 2023 20:30

openshift-ci Bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 29, 2023

sjhala-ccs added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.13 labels Mar 29, 2023

sjhala-ccs added this to the Planned for 4.13 GA milestone Mar 29, 2023

sjhala-ccs removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Mar 29, 2023

sjhala-ccs merged commit 815ef22 into openshift:enterprise-4.13 Mar 29, 2023

Conversation

dhellmann commented Mar 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 27, 2023 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 27, 2023 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 27, 2023 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 27, 2023 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dhellmann commented Mar 27, 2023

Uh oh!

Uh oh!

dhellmann commented Mar 27, 2023

Uh oh!

Uh oh!

ocpdocs-previewbot commented Mar 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 28, 2023 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 28, 2023 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dhellmann commented Mar 28, 2023

Uh oh!

dhellmann commented Mar 28, 2023

Uh oh!

mburke5678 Mar 28, 2023

Choose a reason for hiding this comment

Uh oh!

mburke5678 commented Mar 28, 2023

Uh oh!

ShaunaDiaz commented Mar 28, 2023

Uh oh!

dhellmann commented Mar 28, 2023

Uh oh!

ShaunaDiaz commented Mar 29, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dhellmann commented Mar 27, 2023 •

edited

Loading

openshift-ci-robot commented Mar 27, 2023 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Mar 27, 2023 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Mar 27, 2023 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Mar 27, 2023 •

edited by openshift-ci Bot

Loading

ocpdocs-previewbot commented Mar 28, 2023 •

edited

Loading

openshift-ci-robot commented Mar 28, 2023 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Mar 28, 2023 •

edited by openshift-ci Bot

Loading