Skip to content

Changed all instances of emptydir and EmptyDir to emptyDir#6084

Merged
gaurav-nelson merged 1 commit intoopenshift:masterfrom
gaurav-nelson:emptydir_fix
Nov 3, 2017
Merged

Changed all instances of emptydir and EmptyDir to emptyDir#6084
gaurav-nelson merged 1 commit intoopenshift:masterfrom
gaurav-nelson:emptydir_fix

Conversation

@gaurav-nelson
Copy link
Copy Markdown
Contributor

Kubernetes uses the term emptyDir

@gaurav-nelson
Copy link
Copy Markdown
Contributor Author

no revision history needed.

@gaurav-nelson
Copy link
Copy Markdown
Contributor Author

@mburke5678 @openshift/team-documentation PTAL

@ahardin-rh
Copy link
Copy Markdown
Contributor

LGTM 👍

@vikram-redhat
Copy link
Copy Markdown
Contributor

@gaurav-nelson - hey Gaurav - the cherry pick for 3.4 introduced a table which was not there before. Can you please check how that happened as this PR was only changing emptyDir variables.

@vikram-redhat
Copy link
Copy Markdown
Contributor

@gaurav-nelson fixed via: https://github.com/openshift/openshift-docs/pull/6134/files. Let us know if not correct.

@mburke5678 mburke5678 modified the milestones: Staging, Published - 11/03/17 Nov 4, 2017
@gaurav-nelson
Copy link
Copy Markdown
Contributor Author

Thank you @vikram-redhat for fixing it. These additions were part of resolving merge conflicts and making sure that install_config/cluster_metrics.adoc is same as master install_config/cluster_metrics.adoc.

I now know what the problem was, thank you again for fixing this.

@gaurav-nelson gaurav-nelson deleted the emptydir_fix branch November 5, 2017 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants