Skip to content

Bug 1518471 Added info about port 1936#6881

Merged
bfallonf merged 1 commit intoopenshift:masterfrom
bfallonf:ports_1518471
Dec 19, 2017
Merged

Bug 1518471 Added info about port 1936#6881
bfallonf merged 1 commit intoopenshift:masterfrom
bfallonf:ports_1518471

Conversation

@bfallonf
Copy link
Copy Markdown

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 19, 2017
@bfallonf
Copy link
Copy Markdown
Author

Verified. @openshift/team-documentation PTAL

@bfallonf
Copy link
Copy Markdown
Author

[rev_history]
|xref:../install_config/install/prerequisites.adoc#install-config-install-prerequisites[Installing a Cluster -> Prerequisites]
|Added more information about port 1936 to the xref:../install_config/install/prerequisites.adoc#required-ports[Required Ports] section.
%

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it makes sense to xref to notes section? (if it requires too much scrolling)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's barely a roll away, so I figured it was OK not to. It's on the same screen even.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/1936:/*1936*:

@gaurav-nelson
Copy link
Copy Markdown
Contributor

few minor suggestion. LGTM otherwise :neckbeard:
Remember to squash your commits before you merge.

@bfallonf
Copy link
Copy Markdown
Author

Thanks @gaurav-nelson . Commits squashed. I'll merge.

@bfallonf bfallonf merged commit 830c302 into openshift:master Dec 19, 2017
@bfallonf bfallonf deleted the ports_1518471 branch December 19, 2017 05:40
bfallonf pushed a commit to bfallonf/openshift-docs that referenced this pull request Dec 19, 2017
bfallonf pushed a commit to bfallonf/openshift-docs that referenced this pull request Dec 19, 2017
bfallonf pushed a commit to bfallonf/openshift-docs that referenced this pull request Dec 19, 2017
bfallonf pushed a commit to bfallonf/openshift-docs that referenced this pull request Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants