Skip to content

Typo in prerequisites regarding the firewall#10540

Merged
mburke5678 merged 1 commit intoopenshift:masterfrom
mburke5678:BZ-1572935-2
Jul 2, 2018
Merged

Typo in prerequisites regarding the firewall#10540
mburke5678 merged 1 commit intoopenshift:masterfrom
mburke5678:BZ-1572935-2

Conversation

@mburke5678
Copy link
Copy Markdown
Contributor

@mburke5678 mburke5678 commented Jun 29, 2018

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 29, 2018
@mburke5678 mburke5678 mentioned this pull request Jun 29, 2018
Merged
@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Jun 29, 2018

@knobunc Is this something you can look at?

knobunc
knobunc approved these changes Jun 29, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@knobunc knobunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Jun 29, 2018

@bmeng PTAL

@bmeng
Copy link
Copy Markdown

bmeng commented Jul 2, 2018

LGTM, thanks.

@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Jul 2, 2018

This command was added for 3.5+ via #6881

@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Jul 2, 2018

@openshift/team-documentation PTAL

kalexand-rh
kalexand-rh reviewed Jul 2, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@kalexand-rh kalexand-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kalexand-rh kalexand-rh added the peer-review-done Signifies that the peer review team has reviewed this PR label Jul 2, 2018
@mburke5678 mburke5678 mentioned this pull request Jul 2, 2018
Merged
@mburke5678 mburke5678 added this to the Next Release milestone Jul 2, 2018
@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Jul 2, 2018

@kalexand-rh ++ (have to do it here as I cannot access IRC!)

@mburke5678 mburke5678 merged commit 36b5e09 into openshift:master Jul 2, 2018
@mburke5678 mburke5678 deleted the BZ-1572935-2 branch July 2, 2018 14:13
@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Jul 2, 2018

/cherrypick enterprise-3.5

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 2, 2018
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Jul 2, 2018

@mburke5678: new pull request created: #10568

Details

In response to this:

/cherrypick enterprise-3.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Jul 2, 2018

/cherrypick enterprise-3.6

@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Jul 2, 2018

/cherrypick enterprise-3.7

@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Jul 2, 2018

/cherrypick enterprise-3.9

@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Jul 2, 2018

@mburke5678: new pull request created: #10569

Details

In response to this:

/cherrypick enterprise-3.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 2, 2018
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Jul 2, 2018

@mburke5678: new pull request created: #10570

Details

In response to this:

/cherrypick enterprise-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 2, 2018
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Jul 2, 2018

@mburke5678: new pull request created: #10571

Details

In response to this:

/cherrypick enterprise-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kalexand-rh kalexand-rh kalexand-rh left review comments

@knobunc knobunc knobunc approved these changes

Assignees

No one assigned

Labels

branch/enterprise-3.5 branch/enterprise-3.6 branch/enterprise-3.7 branch/enterprise-3.9 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

6 participants

@mburke5678 @bmeng @openshift-cherrypick-robot @knobunc @kalexand-rh @openshift-ci-robot