OSDOCS-7061: Documented the AWS Wavelength zone feature by dfitzmau · Pull Request #69537 · openshift/openshift-docs

dfitzmau · 2023-12-18T16:52:01Z

Version(s):
4.15

Issue:
OSDOCS-7061

Link to docs preview:

SME review:

[SME ack]

QE review:

QE ack:

Additional information:
https://github.com/openshift/openshift-docs/pull/69128/files

openshift-ci-robot · 2023-12-18T16:52:05Z

@dfitzmau: This pull request references OSDOCS-7061 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

Details

In response to this:

OSDOCS-7061

Version(s):
4.15

Issue:

Link to docs preview:

QE review:

QE has approved this change.

Additional information:
https://github.com/openshift/openshift-docs/pull/69128/files

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ocpdocs-previewbot · 2023-12-18T16:57:20Z

🤖 Thu Feb 15 19:48:34 - Prow CI generated the docs preview: https://69537--ocpdocs-pr.netlify.app

dfitzmau · 2024-02-13T22:29:52Z

/label peer-review-needed

ShaunaDiaz · 2024-02-14T11:35:12Z

/label peer-review-in-progress

ShaunaDiaz · 2024-02-14T11:35:20Z

/remove-label peer-review-needed

openshift-ci-robot · 2024-02-14T11:39:04Z

@dfitzmau: This pull request references OSDOCS-7061 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.15

Issue:
OSDOCS-7061

Link to docs preview:

AWS Local Zones

AWS Wavelength Zones

AWS Outposts

AWS zone tasks

SME review:

[]

QE review:

QE ack:

Additional information:
https://github.com/openshift/openshift-docs/pull/69128/files

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ShaunaDiaz

Amazing, excellent work! Kudos!

ShaunaDiaz · 2024-02-14T19:13:00Z

/label peer-review-done

ShaunaDiaz · 2024-02-14T19:13:12Z

/remove-label peer-review-in-progress

openshift-ci-robot · 2024-02-15T14:46:24Z

@dfitzmau: This pull request references OSDOCS-7061 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.15

Issue:
OSDOCS-7061

Link to docs preview:

AWS Local Zones

AWS Wavelength Zones

AWS Outposts

AWS zone tasks

SME review:

[]

QE review:

QE ack:

Additional information:
https://github.com/openshift/openshift-docs/pull/69128/files

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-02-15T14:46:46Z

@dfitzmau: This pull request references OSDOCS-7061 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.15

Issue:
OSDOCS-7061

Link to docs preview:

AWS Local Zones

AWS Wavelength Zones

AWS Outposts

AWS zone tasks

SME review:

[]

QE review:

QE ack:

Additional information:
https://github.com/openshift/openshift-docs/pull/69128/files

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

mtulio

AWS Local Zones: LGTM with NITs (can be post GA)
AWS Wavelength Zones: LGTM with NITs (can be post GA)
AWS zone tasks: Critical change is required before GA to adjust the permissions correctly for each zone type

mtulio

Great job, @dfitzmau ! Thanks for the partnership in this journey! 🚀
/lgtm

dfitzmau · 2024-02-15T16:41:24Z

/label merge-review-needed

openshift-ci-robot · 2024-02-15T16:42:12Z

@dfitzmau: This pull request references OSDOCS-7061 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.15

Issue:
OSDOCS-7061

Link to docs preview:

AWS Local Zones

AWS Wavelength Zones

AWS Outposts

AWS zone tasks

SME review:

[x]

QE review:

QE ack:

Additional information:
https://github.com/openshift/openshift-docs/pull/69128/files

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-02-15T16:43:51Z

@dfitzmau: This pull request references OSDOCS-7061 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.15

Issue:
OSDOCS-7061

Link to docs preview:

AWS Local Zones

AWS Wavelength Zones

AWS Outposts

AWS zone tasks

SME review:

[SME ack]

QE review:

QE ack:

Additional information:
https://github.com/openshift/openshift-docs/pull/69128/files

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

dfitzmau · 2024-02-15T16:47:19Z

/label merge-review-needed

mjpytlak

@dfitzmau Both Ben and I took another pass at this. I did find one condition that needs your attention ahead of a merge. I did notice that you have several other questions out to Marco, so I will ask that you reach out in this PR after you have addressed the one item I found, anything Ben has found, and when you are satisfied that you do not need further input from Marco. Thank you. Almost there...

mjpytlak · 2024-02-15T18:14:52Z

-After the `StackStatus` displays `CREATE_COMPLETE`, the output displays values
-for the following parameters. You must provide these parameter values to
-the other CloudFormation templates that you run to create your cluster:
+After the `StackStatus` displays `CREATE_COMPLETE`, the output displays values for the following parameters. You must provide these parameter values to the other CloudFormation templates that you run to create your cluster:


@dfitzmau I do not believe @ShaunaDiaz is suggesting that you remove the statement. Rather, she is suggesting that you add "You must provide these parameter values to the other CloudFormation templates that you run to create your cluster." after line 102. I do not think this is must have for GA.

mjpytlak · 2024-02-15T18:46:38Z

+ifeval::["{context}" == "installing-aws-wavelength-zone"]
+:cp-first: Amazon Web Services
+:cp: AWS
+:aws:


@bscott-rh Gut check on this. This appears to be empty in every ifeval directive. Can you think of a reason this would be here. Appears to be a copy/paste from previous ifevals

dfitzmau · 2024-02-15T19:07:28Z

stalling-aws-wavelength-zon

Stephanie, myself, and Marco agreed to leave minor items as a post-GA items. I can address your feedback.

openshift-ci · 2024-02-15T19:53:28Z

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

bscott-rh · 2024-02-15T19:58:43Z

Rest of the PR LGTM on my second pass.

mjpytlak · 2024-02-15T21:00:59Z

@dfitzmau reached out to me in Slack to request the merge.

mjpytlak · 2024-02-15T21:01:34Z

/cherrypick enterprise-4.15

openshift-cherrypick-robot · 2024-02-15T21:02:21Z

@mjpytlak: new pull request created: #71713

Details

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yunjiang29 · 2024-02-19T09:01:06Z

/lgtm

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 18, 2023

openshift-ci Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 18, 2023

dfitzmau force-pushed the OSDOCS-7061 branch from 19bb285 to 5f008f7 Compare December 19, 2023 16:47

openshift-ci Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 19, 2023

dfitzmau force-pushed the OSDOCS-7061 branch 2 times, most recently from 4477852 to e8c0137 Compare December 19, 2023 17:22

openshift-ci Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 19, 2023

dfitzmau force-pushed the OSDOCS-7061 branch from e8c0137 to f9b4d18 Compare December 20, 2023 11:14

openshift-ci Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 20, 2023

dfitzmau force-pushed the OSDOCS-7061 branch 2 times, most recently from c2c00bf to 3c12fb1 Compare December 20, 2023 12:12

openshift-ci Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 20, 2023

dfitzmau force-pushed the OSDOCS-7061 branch 3 times, most recently from 0863650 to b8266aa Compare December 20, 2023 13:01

openshift-ci Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 20, 2023

dfitzmau force-pushed the OSDOCS-7061 branch 7 times, most recently from ad3a5d6 to 52bcc85 Compare December 20, 2023 16:02

mtulio reviewed Feb 14, 2024

View reviewed changes

ShaunaDiaz reviewed Feb 14, 2024

View reviewed changes

dfitzmau mentioned this pull request Feb 15, 2024

OSDOCS-9587: Documented the AWS WZ Day 0 and Day 2 release note #71333

Merged

2 tasks

mtulio reviewed Feb 15, 2024

View reviewed changes

Comment thread installing/installing_aws/installing-aws-wavelength-zone.adoc Outdated

Comment thread installing/installing_aws/installing-aws-localzone.adoc Outdated

mtulio suggested changes Feb 15, 2024

View reviewed changes

mtulio approved these changes Feb 15, 2024

View reviewed changes

bscott-rh reviewed Feb 15, 2024

View reviewed changes

Comment thread modules/installation-creating-aws-vpc-subnets-lz.adoc Outdated

mjpytlak reviewed Feb 15, 2024

View reviewed changes

OSDOCS-7061: Documented the AWS Wavelenght zone feature

dedcfca

openshift-cherrypick-robot mentioned this pull request Feb 15, 2024

[enterprise-4.15] OSDOCS-7061: Documented the AWS Wavelength zone feature #71713

Merged

dfitzmau mentioned this pull request Mar 15, 2024

OCPBUGS-30956: AWS LZ and WZ docs reference server-side CFormation links #73228

Closed

1 task

Conversation

dfitzmau commented Dec 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Dec 18, 2023 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ocpdocs-previewbot commented Dec 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dfitzmau commented Feb 13, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ShaunaDiaz commented Feb 14, 2024

Uh oh!

ShaunaDiaz commented Feb 14, 2024

Uh oh!

openshift-ci-robot commented Feb 14, 2024 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ShaunaDiaz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ShaunaDiaz commented Feb 14, 2024

Uh oh!

ShaunaDiaz commented Feb 14, 2024

Uh oh!

openshift-ci-robot commented Feb 15, 2024 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 15, 2024 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mtulio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mtulio left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dfitzmau commented Feb 15, 2024

Uh oh!

openshift-ci-robot commented Feb 15, 2024

Uh oh!

openshift-ci-robot commented Feb 15, 2024 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dfitzmau commented Feb 15, 2024

Uh oh!

Uh oh!

mjpytlak left a comment

Choose a reason for hiding this comment

Uh oh!

mjpytlak Feb 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mjpytlak Feb 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

dfitzmau commented Dec 18, 2023 •

edited

Loading

openshift-ci-robot commented Dec 18, 2023 •

edited by openshift-ci Bot

Loading

ocpdocs-previewbot commented Dec 18, 2023 •

edited

Loading

openshift-ci-robot commented Feb 14, 2024 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Feb 15, 2024 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Feb 15, 2024 •

edited by openshift-ci Bot

Loading

mtulio left a comment •

edited

Loading

openshift-ci-robot commented Feb 15, 2024 •

edited by openshift-ci Bot

Loading

mjpytlak Feb 15, 2024 •

edited

Loading

mjpytlak Feb 15, 2024 •

edited

Loading