Skip to content

OSDOCS-8991: OLM on MicroShift intro#70128

Merged
ShaunaDiaz merged 1 commit intoopenshift:mainfrom
ShaunaDiaz:OSDOCS-8991
Feb 7, 2024
Merged

OSDOCS-8991: OLM on MicroShift intro#70128
ShaunaDiaz merged 1 commit intoopenshift:mainfrom
ShaunaDiaz:OSDOCS-8991

Conversation

@ShaunaDiaz
Copy link
Copy Markdown
Contributor

@ShaunaDiaz ShaunaDiaz commented Jan 11, 2024

Version(s):
4.15+

Issue:
OSDOCS-8991

Link to docs preview:
How Operators work with MicroShift
Using OLM with MicroShift
xref in Install with RPMs
xref in Add to Blueprint

QE review:

  • QE has approved this change.

Additional information:
Install updates for OLM
SME and PM LGTM 2 Feb 2024

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 11, 2024

@ShaunaDiaz: This pull request references OSDOCS-8991 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.15+

Issue:
OSDOCS-8991

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 11, 2024
@openshift-ci openshift-ci Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 11, 2024
@ocpdocs-previewbot
Copy link
Copy Markdown

ocpdocs-previewbot commented Jan 11, 2024

🤖 Wed Feb 07 16:09:59 - Prow CI generated the docs preview: https://70128--ocpdocs-pr.netlify.app

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 11, 2024

@ShaunaDiaz: This pull request references OSDOCS-8991 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.15+

Issue:
OSDOCS-8991

Link to docs preview:
How Operators work with MicroShift

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ShaunaDiaz ShaunaDiaz added this to the Planned for 4.15 GA milestone Jan 11, 2024
@openshift-ci openshift-ci Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 12, 2024
@ShaunaDiaz ShaunaDiaz force-pushed the OSDOCS-8991 branch 3 times, most recently from 478a791 to 81fd1e8 Compare January 16, 2024 12:00
@ShaunaDiaz ShaunaDiaz changed the title [WIP] OSDOCS-8991: OLM to on MicroShift intro OSDOCS-8991: OLM to on MicroShift intro Jan 16, 2024
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2024
Copy link
Copy Markdown
Member

@kevinrizza kevinrizza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment on the existing content. Otherwise, I think the only other bits that are missing are that I would have expected something specific about how to install OLM itself with a microshift cluster.

Comment thread microshift_running_apps/microshift-operators.adoc Outdated
Comment thread microshift_running_apps/microshift-operators.adoc Outdated
Comment thread microshift_running_apps/microshift-operators.adoc Outdated
Comment thread microshift_running_apps/microshift-operators.adoc Outdated
Comment thread microshift_running_apps/microshift-operators.adoc Outdated
@ShaunaDiaz ShaunaDiaz removed the request for review from dhellmann January 18, 2024 19:34
@ShaunaDiaz ShaunaDiaz changed the title OSDOCS-8991: OLM to on MicroShift intro OSDOCS-8991: OLM on MicroShift intro Jan 19, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 19, 2024

@ShaunaDiaz: This pull request references OSDOCS-8991 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.15+

Issue:
OSDOCS-8991

Link to docs preview:
How Operators work with MicroShift
Using OLM with MicroShift

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ShaunaDiaz
Copy link
Copy Markdown
Contributor Author

/retest

@kevinrizza
Copy link
Copy Markdown
Member

lgtm

Copy link
Copy Markdown
Member

@pmtk pmtk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ShaunaDiaz
Copy link
Copy Markdown
Contributor Author

ShaunaDiaz commented Feb 2, 2024

@kuiwang02 A few things about the goal of this PR to help:

  • This is a foundational PR; I expect to add links to other elements as they are completed, such as offine use and installing OLM. Docs epic: https://issues.redhat.com/browse/OSDOCS-7079
    ** Disconnected and offline use for MicroShift will come in a later PR. I will add links to that section once complete.
    ** We will add OLM and Operators for offline use as a compliment to our existing workflow in another PR. The oc mirror docs team is being asked to document a single procedure that we can link to, so we hope that is coming soon.
  • We discussed with OLM engineering leads yesterday, and they prefer we use curated links for catalog building (either method). I will update the links as you suggested.

Other than the unfinished nature of the information, do you agree that the procedures we worked on are correct?

Comment thread modules/microshift-olm-build-op-catalogs.adoc Outdated
Copy link
Copy Markdown

@DanielFroehlich DanielFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ShaunaDiaz
Copy link
Copy Markdown
Contributor Author

/label peer-review-needed

@ShaunaDiaz
Copy link
Copy Markdown
Contributor Author

Last few updates (bb2b4a4 to fa372d6) removed changes to OLM doc modules that are not used in this PR.

@pmtk
Copy link
Copy Markdown
Member

pmtk commented Feb 2, 2024

/lgtm

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Feb 2, 2024

New changes are detected. LGTM label has been removed.

@ShaunaDiaz
Copy link
Copy Markdown
Contributor Author

c62731d rebase to scoop up install xrefs

@ShaunaDiaz
Copy link
Copy Markdown
Contributor Author

/remove-label peer-review-needed

@ShaunaDiaz
Copy link
Copy Markdown
Contributor Author

4b0701b adding/fixing xrefs to Install modules (and back to OLM assembly from the installation chapters)

@ShaunaDiaz
Copy link
Copy Markdown
Contributor Author

/label peer-review-needed

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 2, 2024

@ShaunaDiaz: This pull request references OSDOCS-8991 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.15+

Issue:
OSDOCS-8991

Link to docs preview:
How Operators work with MicroShift
Using OLM with MicroShift
xref in Install with RPMs
xref in Add to Blueprint

QE review:

  • QE has approved this change.

Additional information:
Install updates for OLM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 2, 2024

@ShaunaDiaz: This pull request references OSDOCS-8991 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.15+

Issue:
OSDOCS-8991

Link to docs preview:
How Operators work with MicroShift
Using OLM with MicroShift
xref in Install with RPMs
xref in Add to Blueprint

QE review:

  • QE has approved this change.

Additional information:
Install updates for OLM
SME and PM LGTM 2 Feb 2024

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ShaunaDiaz
Copy link
Copy Markdown
Contributor Author

/label peer-review-needed

Comment thread modules/microshift-olm-deploy-ops-spec-ns.adoc Outdated
Comment thread modules/microshift-olm-deploy-ops-spec-ns.adoc Outdated
@kuiwang02
Copy link
Copy Markdown

kuiwang02 commented Feb 4, 2024

Using OLM with MicroShift

@ShaunaDiaz Thanks.
let's review this PR per current scope.

1, https://70128--ocpdocs-pr.netlify.app/microshift/latest/microshift_running_apps/microshift-operators-olm#microshift-olm-namespaces_microshift-operators-olm
The global namespace. Empty by default. This namespace must be set in the catalog source YAML if you want the catalog source to be available globally to users in all namespaces. An Operator group in this namespace is set to All Namespaces mode by default. should be The global namespace. Empty by default. This namespace must be set in the catalog source YAML if you want the catalog source to be available globally to users in all namespaces. because Operator group is in openshift-operators ns, not openshift-marketplace

of course, you could move An Operator group in this namespace is set to All Namespaces mode by default. into description for openshift-operators

2, https://70128--ocpdocs-pr.netlify.app/microshift/latest/microshift_running_apps/microshift-operators-olm#microshift-file-based-olm-catalogs_microshift-operators-olm
I suggest to remove the link https://access.redhat.com/documentation/en-us/openshift_container_platform/4.15/html/operators/understanding-operators#olm-fb-catalogs-example_olm-packaging-format. and the link
https://docs.openshift.com/container-platform/4.14/operators/admin/olm-managing-custom-catalogs.html#olm-creating-fb-catalog-image_olm-managing-custom-catalogs is enough.

Comment thread modules/microshift-olm-deploy-ops-spec-ns.adoc Outdated
Copy link
Copy Markdown
Contributor

@lpettyjo lpettyjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM! Nice work!

Comment thread microshift_running_apps/microshift-operators.adoc
Comment thread microshift_running_apps/microshift-operators.adoc Outdated
Comment thread modules/microshift-olm-build-op-catalogs.adoc Outdated
Comment thread modules/microshift-olm-deploy-ops-global-ns.adoc Outdated
Comment thread modules/microshift-olm-deploy-ops-spec-ns.adoc Outdated
Comment thread modules/microshift-olm-namespaces.adoc Outdated
Comment thread modules/microshift-olm-namespaces.adoc Outdated
Comment thread modules/microshift-olm-namespaces.adoc Outdated
Comment thread modules/microshift-olm-namespaces.adoc Outdated
Comment thread modules/microshift-olm-build-op-catalogs.adoc Outdated
@kuiwang02
Copy link
Copy Markdown

@ShaunaDiaz this comment is not correctly fixed.
here are the corrected per your PR.

for 1,
#70128 (comment)
#70128 (comment)

for 2,
#70128 (comment)

@kuiwang02
Copy link
Copy Markdown

@ShaunaDiaz
I will take PTO from tomorrow (2/8 BJ time) and am back after Spring Festival.
after #70128 (comment) is fixed, lgtm for me.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 7, 2024

@ShaunaDiaz: This pull request references OSDOCS-8991 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.15+

Issue:
OSDOCS-8991

Link to docs preview:
How Operators work with MicroShift
Using OLM with MicroShift
xref in Install with RPMs
xref in Add to Blueprint

QE review:

  • QE has approved this change.

Additional information:
Install updates for OLM
SME and PM LGTM 2 Feb 2024

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dhensel-rh
Copy link
Copy Markdown

/label qe-approved

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 7, 2024

@ShaunaDiaz: This pull request references OSDOCS-8991 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.15+

Issue:
OSDOCS-8991

Link to docs preview:
How Operators work with MicroShift
Using OLM with MicroShift
xref in Install with RPMs
xref in Add to Blueprint

QE review:

  • QE has approved this change.

Additional information:
Install updates for OLM
SME and PM LGTM 2 Feb 2024

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Feb 7, 2024

@ShaunaDiaz: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ShaunaDiaz
Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-4.15

@openshift-cherrypick-robot
Copy link
Copy Markdown

@ShaunaDiaz: new pull request created: #71312

Details

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.15 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.