Migrating cart spec guide topics#9
Merged
nhr merged 2 commits intoopenshift:masterfrom Aug 11, 2014
Bilhar-rh:cart_spec_guide
Merged
Migrating cart spec guide topics#9nhr merged 2 commits intoopenshift:masterfrom Bilhar-rh:cart_spec_guide
nhr merged 2 commits intoopenshift:masterfrom
Bilhar-rh:cart_spec_guide
Conversation
Member
There was a problem hiding this comment.
Couple of thoughts:
- Probably better not to use specific distribution names outside of an ifdef/endif block. I will create a macro for when the product name appears in the text, but in the case of anchors such as this, it is probably best to stick with 'openshift'.
- Please don't use Camel_Case, stick to lower case for system things like link anchors.
- This link anchor is separated from the related header (below) by two blank lines. Please put link anchors directly above the relevant line for clarity.
Author
There was a problem hiding this comment.
Actually, I've been wondering.....do we need those link anchors? I couldn't link to a section without them.
Member
|
There are several places in the pull request where the issues that I pointed out occur. Please update the docs with those changes and update this PR by pushing another commit to your feature branch. Also - since you're adding a new topic group to the docs, please also include the relevant changes to |
Author
|
Fixed the issues that were highlighted, and updated the _build_cfg.yml file. |
Merged
StephenJamesSmith
pushed a commit
to StephenJamesSmith/openshift-docs
that referenced
this pull request
Apr 11, 2022
…ZTP_review-comments tweaking podman pull command + ptp fix
1 task
1 task
ogradyp
pushed a commit
to ogradyp/openshift-docs
that referenced
this pull request
Dec 13, 2024
ogradyp
pushed a commit
to ogradyp/openshift-docs
that referenced
this pull request
Dec 19, 2024
TELCODOCS-1990: Docfooding feedback openshift#2 applied TELCODOCS-1990: Docfooding feedback openshift#3 applied TELCODOCS-1990: Docfooding feedback openshift#4 applied TELCODOCS-1990: Docfooding feedback openshift#5 applied TELCODOCS-1990: Docfooding feedback openshift#6 applied TELCODOCS-1990: Docfooding feedback openshift#7 applied TELCODOCS-1990: Docfooding feedback openshift#8 applied TELCODOCS-1990: Docfooding feedback openshift#9 applied TELCODOCS-1990: Docfooding feedback openshift#10 applied TELCODOCS-1990: Docfooding feedback openshift#11 applied TELCODOCS-1990: Peer review feedback applied TELCODOCS-1990: Dev review feedback applied TELCODOCS-1990: Dev/Peer review feedback applied TELCODOCS-1990: Dev/Peer openshift#2 review feedback applied TELCODOCS-1990: Dev openshift#2 review feedback applied
ogradyp
pushed a commit
to ogradyp/openshift-docs
that referenced
this pull request
Dec 19, 2024
TELCODOCS-1990: Docfooding feedback openshift#2 applied TELCODOCS-1990: Docfooding feedback openshift#3 applied TELCODOCS-1990: Docfooding feedback openshift#4 applied TELCODOCS-1990: Docfooding feedback openshift#5 applied TELCODOCS-1990: Docfooding feedback openshift#6 applied TELCODOCS-1990: Docfooding feedback openshift#7 applied TELCODOCS-1990: Docfooding feedback openshift#8 applied TELCODOCS-1990: Docfooding feedback openshift#9 applied TELCODOCS-1990: Docfooding feedback openshift#10 applied TELCODOCS-1990: Docfooding feedback openshift#11 applied TELCODOCS-1990: Peer review feedback applied TELCODOCS-1990: Dev review feedback applied TELCODOCS-1990: Dev/Peer review feedback applied TELCODOCS-1990: Dev/Peer openshift#2 review feedback applied TELCODOCS-1990: Dev openshift#2 review feedback applied TELCODOCS-1990: Peer review squad feedback applied
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/openshift-docs
that referenced
this pull request
Dec 20, 2024
TELCODOCS-1990: Docfooding feedback openshift#2 applied TELCODOCS-1990: Docfooding feedback openshift#3 applied TELCODOCS-1990: Docfooding feedback openshift#4 applied TELCODOCS-1990: Docfooding feedback openshift#5 applied TELCODOCS-1990: Docfooding feedback openshift#6 applied TELCODOCS-1990: Docfooding feedback openshift#7 applied TELCODOCS-1990: Docfooding feedback openshift#8 applied TELCODOCS-1990: Docfooding feedback openshift#9 applied TELCODOCS-1990: Docfooding feedback openshift#10 applied TELCODOCS-1990: Docfooding feedback openshift#11 applied TELCODOCS-1990: Peer review feedback applied TELCODOCS-1990: Dev review feedback applied TELCODOCS-1990: Dev/Peer review feedback applied TELCODOCS-1990: Dev/Peer openshift#2 review feedback applied TELCODOCS-1990: Dev openshift#2 review feedback applied TELCODOCS-1990: Peer review squad feedback applied
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/openshift-docs
that referenced
this pull request
Jan 14, 2025
TELCODOCS-1990: Docfooding feedback openshift#2 applied TELCODOCS-1990: Docfooding feedback openshift#3 applied TELCODOCS-1990: Docfooding feedback openshift#4 applied TELCODOCS-1990: Docfooding feedback openshift#5 applied TELCODOCS-1990: Docfooding feedback openshift#6 applied TELCODOCS-1990: Docfooding feedback openshift#7 applied TELCODOCS-1990: Docfooding feedback openshift#8 applied TELCODOCS-1990: Docfooding feedback openshift#9 applied TELCODOCS-1990: Docfooding feedback openshift#10 applied TELCODOCS-1990: Docfooding feedback openshift#11 applied TELCODOCS-1990: Peer review feedback applied TELCODOCS-1990: Dev review feedback applied TELCODOCS-1990: Dev/Peer review feedback applied TELCODOCS-1990: Dev/Peer openshift#2 review feedback applied TELCODOCS-1990: Dev openshift#2 review feedback applied TELCODOCS-1990: Peer review squad feedback applied
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/openshift-docs
that referenced
this pull request
Jan 14, 2025
TELCODOCS-1990: Docfooding feedback openshift#2 applied TELCODOCS-1990: Docfooding feedback openshift#3 applied TELCODOCS-1990: Docfooding feedback openshift#4 applied TELCODOCS-1990: Docfooding feedback openshift#5 applied TELCODOCS-1990: Docfooding feedback openshift#6 applied TELCODOCS-1990: Docfooding feedback openshift#7 applied TELCODOCS-1990: Docfooding feedback openshift#8 applied TELCODOCS-1990: Docfooding feedback openshift#9 applied TELCODOCS-1990: Docfooding feedback openshift#10 applied TELCODOCS-1990: Docfooding feedback openshift#11 applied TELCODOCS-1990: Peer review feedback applied TELCODOCS-1990: Dev review feedback applied TELCODOCS-1990: Dev/Peer review feedback applied TELCODOCS-1990: Dev/Peer openshift#2 review feedback applied TELCODOCS-1990: Dev openshift#2 review feedback applied TELCODOCS-1990: Peer review squad feedback applied
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/openshift-docs
that referenced
this pull request
Jan 14, 2025
TELCODOCS-1990: Docfooding feedback openshift#2 applied TELCODOCS-1990: Docfooding feedback openshift#3 applied TELCODOCS-1990: Docfooding feedback openshift#4 applied TELCODOCS-1990: Docfooding feedback openshift#5 applied TELCODOCS-1990: Docfooding feedback openshift#6 applied TELCODOCS-1990: Docfooding feedback openshift#7 applied TELCODOCS-1990: Docfooding feedback openshift#8 applied TELCODOCS-1990: Docfooding feedback openshift#9 applied TELCODOCS-1990: Docfooding feedback openshift#10 applied TELCODOCS-1990: Docfooding feedback openshift#11 applied TELCODOCS-1990: Peer review feedback applied TELCODOCS-1990: Dev review feedback applied TELCODOCS-1990: Dev/Peer review feedback applied TELCODOCS-1990: Dev/Peer openshift#2 review feedback applied TELCODOCS-1990: Dev openshift#2 review feedback applied TELCODOCS-1990: Peer review squad feedback applied
1 task
sheriff-rh
pushed a commit
that referenced
this pull request
Jan 15, 2025
TELCODOCS-1990: Docfooding feedback #2 applied TELCODOCS-1990: Docfooding feedback #3 applied TELCODOCS-1990: Docfooding feedback #4 applied TELCODOCS-1990: Docfooding feedback #5 applied TELCODOCS-1990: Docfooding feedback #6 applied TELCODOCS-1990: Docfooding feedback #7 applied TELCODOCS-1990: Docfooding feedback #8 applied TELCODOCS-1990: Docfooding feedback #9 applied TELCODOCS-1990: Docfooding feedback #10 applied TELCODOCS-1990: Docfooding feedback #11 applied TELCODOCS-1990: Peer review feedback applied TELCODOCS-1990: Dev review feedback applied TELCODOCS-1990: Dev/Peer review feedback applied TELCODOCS-1990: Dev/Peer #2 review feedback applied TELCODOCS-1990: Dev #2 review feedback applied TELCODOCS-1990: Peer review squad feedback applied
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.