[OCPBUGS#54694]: Fix capitalization issue with updateMode values#91788
[OCPBUGS#54694]: Fix capitalization issue with updateMode values#91788chuckersjp wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
@openshift/team-documentation |
|
Hi @chuckersjp. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
🤖 Wed Apr 09 05:17:50 - Prow CI generated the docs preview: |
|
@chuckersjp: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@chuckersjp @asahay19 I'm sorry. I didn't see that Chuck created this PR. I created another PR to address the same issue. Mind if we go with that one? |
Current docs list a number of options for the
updateModeparameter of theVerticalPodAutoscalerthat are listed as lower case. However using lower case for these values will result in an error from the server and fail to create said VPA. This PR fixes those values.Version(s):
OCP Docs for 4.12 though Current Release. This issue actually appears earlier as well.
Issue:
https://issues.redhat.com/browse/OCPBUGS-54694
Additional information:
Upstream source implies that only capitals are permitted:
https://github.com/kubernetes/autoscaler/blob/master/vertical-pod-autoscaler/pkg/apis/autoscaling.k8s.io/v1/types.go#L157-L174