Skip to content

[OCPBUGS#54694]: Fix capitalization issue with updateMode values#91788

Closed
chuckersjp wants to merge 1 commit intoopenshift:mainfrom
chuckersjp:vpa-docs-bug
Closed

[OCPBUGS#54694]: Fix capitalization issue with updateMode values#91788
chuckersjp wants to merge 1 commit intoopenshift:mainfrom
chuckersjp:vpa-docs-bug

Conversation

@chuckersjp
Copy link
Copy Markdown
Contributor

Current docs list a number of options for the updateMode parameter of the VerticalPodAutoscaler that are listed as lower case. However using lower case for these values will result in an error from the server and fail to create said VPA. This PR fixes those values.

Version(s):

OCP Docs for 4.12 though Current Release. This issue actually appears earlier as well.
Issue:

https://issues.redhat.com/browse/OCPBUGS-54694

Additional information:

Upstream source implies that only capitals are permitted:

https://github.com/kubernetes/autoscaler/blob/master/vertical-pod-autoscaler/pkg/apis/autoscaling.k8s.io/v1/types.go#L157-L174

@chuckersjp
Copy link
Copy Markdown
Contributor Author

@openshift/team-documentation
Submitted for your approval.

@openshift-ci openshift-ci Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 7, 2025
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 7, 2025

Hi @chuckersjp. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 7, 2025
@asahay19
Copy link
Copy Markdown

asahay19 commented Apr 9, 2025

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2025
@ocpdocs-previewbot
Copy link
Copy Markdown

🤖 Wed Apr 09 05:17:50 - Prow CI generated the docs preview:

https://91788--ocpdocs-pr.netlify.app/openshift-enterprise/latest/nodes/pods/nodes-pods-vertical-autoscaler.html

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 9, 2025

@chuckersjp: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mburke5678
Copy link
Copy Markdown
Contributor

@chuckersjp @asahay19 I'm sorry. I didn't see that Chuck created this PR. I created another PR to address the same issue. Mind if we go with that one?

@mburke5678 mburke5678 closed this Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants