Skip to content

VPA updateMode values show lower cased options which won't work in cluster#91896

Merged
mburke5678 merged 1 commit intoopenshift:mainfrom
mburke5678:nodes-vpa-params-fix
Apr 9, 2025
Merged

VPA updateMode values show lower cased options which won't work in cluster#91896
mburke5678 merged 1 commit intoopenshift:mainfrom
mburke5678:nodes-vpa-params-fix

Conversation

@mburke5678
Copy link
Copy Markdown
Contributor

@mburke5678 mburke5678 commented Apr 8, 2025 •
edited
Loading

The docs talking about VerticalPodAutoscaler .spec.updatePolicy.updateMode list a number of options for the value that are all listed in lower case. However, using the lower case value will result in an error.
https://issues.redhat.com/browse/OCPBUGS-54694

Using the Vertical Pod Autoscaler Operator
About Using the Vertical Pod Autoscaler Operator

@mburke5678 mburke5678 added this to the Continuous Release milestone Apr 8, 2025
@openshift-ci openshift-ci Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 8, 2025
@ocpdocs-previewbot
Copy link
Copy Markdown

ocpdocs-previewbot commented Apr 8, 2025

🤖 Tue Apr 08 21:51:58 - Prow CI generated the docs preview:

https://91896--ocpdocs-pr.netlify.app/openshift-enterprise/latest/nodes/pods/nodes-pods-vertical-autoscaler.html

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 8, 2025

@mburke5678: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@arnaik-rh
Copy link
Copy Markdown

arnaik-rh commented Apr 9, 2025

@prozehna Can you please review this PR

@prozehna
Copy link
Copy Markdown
Contributor

prozehna commented Apr 9, 2025 •
edited
Loading

  1. I found a few nits, but they are technically in other files, since the 'netlify document previewer' amalgamates more than just the two files that are changed here. I'll open a new PR for that. Edt: PR
  2. These changes look good.
    /lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2025
@prozehna prozehna mentioned this pull request Apr 9, 2025
Closed
@mburke5678 mburke5678 added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 9, 2025
@mburke5678 mburke5678 mentioned this pull request Apr 9, 2025
Closed
@dfitzmau dfitzmau added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 9, 2025
@dfitzmau dfitzmau added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Apr 9, 2025
@prozehna prozehna mentioned this pull request Apr 9, 2025
Merged
@mburke5678 mburke5678 merged commit 098f495 into openshift:main Apr 9, 2025
2 checks passed
@mburke5678 mburke5678 deleted the nodes-vpa-params-fix branch April 9, 2025 14:47
@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Apr 9, 2025

/cherrypick enterprise-4.12

@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Apr 9, 2025

/cherrypick enterprise-4.13

@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Apr 9, 2025

/cherrypick enterprise-4.14

@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Apr 9, 2025

/cherrypick enterprise-4.15

@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Apr 9, 2025

/cherrypick enterprise-4.16

@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Apr 9, 2025

/cherrypick enterprise-4.17

@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Apr 9, 2025

/cherrypick enterprise-4.18

@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented Apr 9, 2025

/cherrypick enterprise-4.19

@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Apr 9, 2025

@mburke5678: new pull request created: #91924

Details

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 9, 2025
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Apr 9, 2025

@mburke5678: new pull request created: #91925

Details

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 9, 2025
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Apr 9, 2025

@mburke5678: new pull request created: #91926

Details

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 9, 2025
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Apr 9, 2025

@mburke5678: new pull request created: #91927

Details

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 9, 2025
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Apr 9, 2025

@mburke5678: new pull request created: #91928

Details

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 9, 2025
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Apr 9, 2025

@mburke5678: new pull request created: #91929

Details

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 9, 2025
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Apr 9, 2025

@mburke5678: new pull request created: #91930

Details

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 9, 2025
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Apr 9, 2025

@mburke5678: new pull request created: #91931

Details

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dfitzmau dfitzmau dfitzmau approved these changes

Assignees

@prozehna prozehna

Labels

branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

6 participants

@mburke5678 @ocpdocs-previewbot @arnaik-rh @prozehna @openshift-cherrypick-robot @dfitzmau