Nits in VPA documentation#91918
Closed
prozehna wants to merge 1 commit intoopenshift:mainfrom
Closed
Conversation
openshift-ci
Bot
added
the
size/S
|
🤖 Wed Apr 09 12:29:37 - Prow CI generated the docs preview: |
|
@prozehna: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Contributor
|
@prozehna It appears that these changes are the same as in https://github.com/openshift/openshift-docs/pull/91896/files, right? |
Contributor
Author
|
@mburke5678 whoops, that was not my intention. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While investigation PR #91896
I found some nits that'd I'd like to correct.
All but one are punctuation/grammar, the other being a small clarification (node being used changing from master to infra.)
Version(s): 4.12 to 4.19
Issue:
N/A, just nits I found
Link to docs preview:
I don't know how to this
@mburke5678 Since I am QE, I'm not sure who else would run through these suggestions other than the two of us. Would you take a look?