Skip to content

OSDOCS-14601 [NETOBSERV-2053] Flowlogs Flp filtering#93270

Merged
skopacz1 merged 1 commit intoopenshift:no-1.9from
gwynnemonahan:OSDOCS-14601
Jun 3, 2025
Merged

OSDOCS-14601 [NETOBSERV-2053] Flowlogs Flp filtering#93270
skopacz1 merged 1 commit intoopenshift:no-1.9from
gwynnemonahan:OSDOCS-14601

Conversation

@gwynnemonahan
Copy link
Copy Markdown
Contributor

@gwynnemonahan gwynnemonahan commented May 13, 2025

https://issues.redhat.com/browse/OSDOCS-14601 [NETOBSERV-2053] Flowlogs Flp filtering

Version(s):
Merge to only the no-1.9 branch - no cherrypicks are required.
I will open one PR against main to incorporate all of the NetObserv content just before its GA.

Cherry-pick to OCP 4.12, 4.14, 4.16+

Issue:
https://issues.redhat.com/browse/OSDOCS-14601

Link to docs preview:
https://93270--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/configuring-operator.html#network-observability-filter-network-flows-at-ingestion_network_observability

QE review:

  • QE has approved this change.

Additional information:
Following CONCEPT template: https://github.com/redhat-documentation/modular-docs/blob/main/modular-docs-manual/files/TEMPLATE_CONCEPT_concept-explanation.adoc?plain=1 so file name includes con_ since it is new content.

@openshift-ci openshift-ci Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 13, 2025
@ocpdocs-previewbot
Copy link
Copy Markdown

ocpdocs-previewbot commented May 13, 2025

@openshift-ci openshift-ci Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 13, 2025
@gwynnemonahan gwynnemonahan changed the title [NETOBSERV-2053] Flowlogs Flp filtering OSDOCS-14602 [NETOBSERV-2053] Flowlogs Flp filtering May 13, 2025
Comment thread modules/network-observability-config-flows-at-ingestion.adoc Outdated
Comment thread modules/network-observability-config-flows-at-ingestion.adoc Outdated
Comment thread modules/network-observability-config-flows-at-ingestion.adoc Outdated
@gwynnemonahan gwynnemonahan changed the title OSDOCS-14602 [NETOBSERV-2053] Flowlogs Flp filtering OSDOCS-14601 [NETOBSERV-2053] Flowlogs Flp filtering May 15, 2025
Comment thread modules/network-observability-config-flows-at-ingestion.adoc Outdated
@Amoghrd
Copy link
Copy Markdown

Amoghrd commented May 15, 2025

/assign @jotak

Comment thread modules/network-observability-config-flows-at-ingestion.adoc Outdated
Comment thread modules/network-observability-config-flows-at-ingestion.adoc Outdated
Comment thread modules/network-observability-config-flows-at-ingestion.adoc Outdated
Comment thread modules/network-observability-config-flows-at-ingestion.adoc Outdated
Comment thread modules/network-observability-config-flows-at-ingestion.adoc
Comment thread modules/network-observability-config-flows-at-ingestion.adoc Outdated
@Amoghrd
Copy link
Copy Markdown

Amoghrd commented Jun 2, 2025

/label qe-approved

@openshift-ci openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label Jun 2, 2025
@gwynnemonahan gwynnemonahan force-pushed the OSDOCS-14601 branch 2 times, most recently from dbade73 to cd0d102 Compare June 2, 2025 20:01
@gwynnemonahan
Copy link
Copy Markdown
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci Bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 2, 2025
Copy link
Copy Markdown

@jotak jotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Gwynne, LGTM!

@xenolinux xenolinux added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 3, 2025
Copy link
Copy Markdown
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments; lgtm

Comment thread modules/network-observability-con_filter-network-flows-at-ingestion.adoc Outdated
Comment thread modules/network-observability-con_filter-network-flows-at-ingestion.adoc Outdated
Comment thread modules/network-observability-con_filter-network-flows-at-ingestion.adoc Outdated
Comment thread modules/network-observability-con_filter-network-flows-at-ingestion.adoc Outdated
Comment thread modules/network-observability-con_filter-network-flows-at-ingestion.adoc Outdated
@xenolinux xenolinux added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jun 3, 2025
@openshift-ci openshift-ci Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 3, 2025
@openshift-ci openshift-ci Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 3, 2025
@gwynnemonahan
Copy link
Copy Markdown
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci Bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 3, 2025
@skopacz1 skopacz1 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jun 3, 2025
Copy link
Copy Markdown
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few things worth checking out before I merge.

Comment thread modules/network-observability-con_filter-network-flows-at-ingestion.adoc Outdated
Comment thread modules/network-observability-con_filter-network-flows-at-ingestion.adoc Outdated
Comment thread modules/network-observability-con_filter-network-flows-at-ingestion.adoc Outdated
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 3, 2025

@gwynnemonahan: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@skopacz1 skopacz1 merged commit 14ac4a3 into openshift:no-1.9 Jun 3, 2025
2 checks passed
@skopacz1 skopacz1 removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Jun 3, 2025
@skopacz1 skopacz1 added this to the Continuous Release milestone Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants