Redo-OSDOCS-14786 [NETOBSERV] Add section for IPSec#95159
Redo-OSDOCS-14786 [NETOBSERV] Add section for IPSec#95159lahinson merged 2 commits intoopenshift:no-1.9from
Conversation
cd1275d to
7c1a809
Compare
|
/label peer-review-needed |
gabriel-rh
left a comment
There was a problem hiding this comment.
/LGTM
Good work on very technical info - only a few trivial comments
caee173 to
bc53151
Compare
|
Here's hoping merging this PR puts all the files back in the |
|
/label merge-review-needed |
lahinson
left a comment
There was a problem hiding this comment.
Just a few nits for your consideration. Let me know when you've reviewed the comments and made any changes, and I'll merge this.
| * xref:../../networking/multiple_networks/primary_networks/about-user-defined-networks.adoc#nw-udn-cr_about-user-defined-networks[Creating a UserDefinedNetwork by using the CLI] | ||
| * xref:../../networking/multiple_networks/primary_networks/about-user-defined-networks.adoc#nw-udn-cr-ui_about-user-defined-networks[Creating a UserDefinedNetwork by using the web console] | ||
|
|
||
| include::modules/network-observability-viewing-network-events.adoc[leveloffset=+2] |
|
@gwynnemonahan: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
lahinson
left a comment
There was a problem hiding this comment.
Thanks for incorporating my suggestions! Merging now :)

https://issues.redhat.com/browse/OSDOCS-14786 [NETOBSERV] Add section for IPsec
Version(s):
Merge to only the
no-1.9branch - no cherrypicks are required.I will open one PR against main to incorporate all of the NetObserv content just before its GA.
Cherry-pick to OCP 4.12, 4.14, 4.16+
Issue:
https://issues.redhat.com/browse/OSDOCS-14786
Link to docs preview:
QE review:
Additional information:
Redo/copy of #93858 which I somehow messed up. So this is a copy of the Dev/QE approved PR, and making this copy revealed that the content in the following already merged PRs is no longer present in the
no-1.9branch:The only new content is
proc_working-with-ipsec.adoc, and this addition toobserving-network-traffic.adocfor IPsec:The remaining files have been reviewed and merged as part of the PRs listed above. However, removing those files results in build failures as that content has vanished from the
no-1.9branch for reasons no one has been able to identify.The previously reviewed and merged content is now part of this PR, and hopefully this will fix the
no-1.9branch and return it to its updated state with all NetObserv 1.9 content. And hopefully that will resolve existing open PRs againstno-1.9that now have these same previously merged PRs.Copied from 93858:
API reference updates are being handled by #94756
First time doing NETOBSERV release, and did not realize API/CLI changes were automatically generated, and those updates to prod docs are generally handed separately and not in individual PRs where CLI/API changes may occur.