Skip to content

Bug 2011927: Introduce GRPC_PROXY EnvVar Support (#2364)#206

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
njhale:sync/grpc-no-proxy
Oct 20, 2021
Merged

Bug 2011927: Introduce GRPC_PROXY EnvVar Support (#2364)#206
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
njhale:sync/grpc-no-proxy

Conversation

@njhale
Copy link
Copy Markdown
Contributor

@njhale njhale commented Oct 18, 2021

Introduce the ability to specify a dial context for GRPC connections.

Signed-off-by: Alexander Greene greene.al1991@gmail.com

Upstream-repository: operator-lifecycle-manager
Upstream-commit: afc0848d102ecdc01a0b0f3b55d389bb66acf168

(upstream PR: operator-framework/operator-lifecycle-manager#2364)

@awgreene @njhale
Introduce GRPC_PROXY EnvVar Support (#2364)
c4e2447 
Introduce the ability to specify a dial context for GRPC connections.

Signed-off-by: Alexander Greene <greene.al1991@gmail.com>

Upstream-repository: operator-lifecycle-manager
Upstream-commit: afc0848d102ecdc01a0b0f3b55d389bb66acf168
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot requested review from hasbro17 and joelanford October 18, 2021 21:28
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2021
@timflannagan
Copy link
Copy Markdown
Contributor

timflannagan commented Oct 18, 2021

/lgtm
/cherrypick release-4.9

@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Oct 18, 2021

@timflannagan: once the present PR merges, I will cherry-pick it on top of release-4.9 in a new PR and assign it to you.

Details

In response to this:

/lgtm
/cherrypick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2021
@timflannagan
Copy link
Copy Markdown
Contributor

timflannagan commented Oct 18, 2021

/retitle Bug 2011927: Introduce GRPC_PROXY EnvVar Support (#2364)

@openshift-ci openshift-ci Bot changed the title Introduce GRPC_PROXY EnvVar Support (#2364) Bug 2011927: Introduce GRPC_PROXY EnvVar Support (#2364) Oct 18, 2021
@openshift-ci openshift-ci Bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Oct 18, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 18, 2021

@njhale: This pull request references Bugzilla bug 2011927, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

Details

In response to this:

Bug 2011927: Introduce GRPC_PROXY EnvVar Support (#2364)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 18, 2021
@openshift-ci openshift-ci Bot requested a review from jianzhangbjz October 18, 2021 21:32
@awgreene
Copy link
Copy Markdown
Contributor

awgreene commented Oct 18, 2021

/lgtm

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 18, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

12 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 18, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 18, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 18, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 19, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 19, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 19, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 19, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 19, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 19, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 19, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 19, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 19, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@timflannagan
Copy link
Copy Markdown
Contributor

timflannagan commented Oct 19, 2021

Upgrade failures look unrelated.

/retest

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 19, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 19, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 19, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 20, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 20, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 20, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 20, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 20, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit dde7292 into openshift:master Oct 20, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 20, 2021

@njhale: All pull requests linked via external trackers have merged:

Bugzilla bug 2011927 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2011927: Introduce GRPC_PROXY EnvVar Support (#2364)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 20, 2021
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Oct 20, 2021

@timflannagan: new pull request created: #207

Details

In response to this:

/lgtm
/cherrypick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

awgreene pushed a commit to awgreene/operator-framework-olm that referenced this pull request Feb 2, 2022
@camilamacedo86 @awgreene
validator/good practices: Improve message (openshift#206)
4d91ab7 
Upstream-repository: api
Upstream-commit: ff6b5ebe3c251e09ef4bf11a6fcd1bd8464be1d6
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 1, 2022
@camilamacedo86 @perdasilva
validator/good practices: Improve message (openshift#206)
53fefae 
Upstream-repository: api
Upstream-commit: ff6b5ebe3c251e09ef4bf11a6fcd1bd8464be1d6
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 2, 2022
@camilamacedo86 @perdasilva
validator/good practices: Improve message (openshift#206)
698ad85 
Upstream-repository: api
Upstream-commit: ff6b5ebe3c251e09ef4bf11a6fcd1bd8464be1d6
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 2, 2022
@camilamacedo86 @perdasilva
validator/good practices: Improve message (openshift#206)
0faf168 
Upstream-repository: api
Upstream-commit: ff6b5ebe3c251e09ef4bf11a6fcd1bd8464be1d6
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 2, 2022
@camilamacedo86 @perdasilva
validator/good practices: Improve message (openshift#206)
219c5ab 
Upstream-repository: api
Upstream-commit: ff6b5ebe3c251e09ef4bf11a6fcd1bd8464be1d6
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
@camilamacedo86 @perdasilva
validator/good practices: Improve message (openshift#206)
3f0afe5 
Upstream-repository: api
Upstream-commit: ff6b5ebe3c251e09ef4bf11a6fcd1bd8464be1d6
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
@camilamacedo86 @perdasilva
validator/good practices: Improve message (openshift#206)
88af97b 
Upstream-repository: api
Upstream-commit: ff6b5ebe3c251e09ef4bf11a6fcd1bd8464be1d6
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
@camilamacedo86 @perdasilva
validator/good practices: Improve message (openshift#206)
217844f 
Upstream-repository: api
Upstream-commit: ff6b5ebe3c251e09ef4bf11a6fcd1bd8464be1d6
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
@camilamacedo86 @perdasilva
validator/good practices: Improve message (openshift#206)
303c0f4 
Upstream-repository: api
Upstream-commit: ff6b5ebe3c251e09ef4bf11a6fcd1bd8464be1d6
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
@camilamacedo86 @perdasilva
validator/good practices: Improve message (openshift#206)
23800bf 
Upstream-repository: api
Upstream-commit: ff6b5ebe3c251e09ef4bf11a6fcd1bd8464be1d6
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 7, 2022
@camilamacedo86 @perdasilva
validator/good practices: Improve message (openshift#206)
8c8c07f 
Upstream-repository: api
Upstream-commit: ff6b5ebe3c251e09ef4bf11a6fcd1bd8464be1d6
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 7, 2022
@camilamacedo86 @perdasilva
validator/good practices: Improve message (openshift#206)
8991bd1 
Upstream-repository: api
Upstream-commit: ff6b5ebe3c251e09ef4bf11a6fcd1bd8464be1d6
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 8, 2022
@camilamacedo86 @perdasilva
validator/good practices: Improve message (openshift#206)
806da84 
Upstream-repository: api
Upstream-commit: ff6b5ebe3c251e09ef4bf11a6fcd1bd8464be1d6
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 9, 2022
@camilamacedo86 @perdasilva
validator/good practices: Improve message (openshift#206)
d9a5859 
Upstream-repository: api
Upstream-commit: ff6b5ebe3c251e09ef4bf11a6fcd1bd8464be1d6
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 10, 2022
@camilamacedo86 @perdasilva
validator/good practices: Improve message (openshift#206)
ae5080d 
Upstream-repository: api
Upstream-commit: ff6b5ebe3c251e09ef4bf11a6fcd1bd8464be1d6
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 10, 2022
@camilamacedo86 @perdasilva
validator/good practices: Improve message (openshift#206)
62288ef 
Upstream-repository: api
Upstream-commit: ff6b5ebe3c251e09ef4bf11a6fcd1bd8464be1d6
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 12, 2022
@camilamacedo86 @perdasilva
validator/good practices: Improve message (openshift#206)
7672c23 
Upstream-repository: api
Upstream-commit: ff6b5ebe3c251e09ef4bf11a6fcd1bd8464be1d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hasbro17 hasbro17 Awaiting requested review from hasbro17

@joelanford joelanford Awaiting requested review from joelanford

@jianzhangbjz jianzhangbjz Awaiting requested review from jianzhangbjz

Assignees

@awgreene awgreene

@timflannagan timflannagan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@njhale @timflannagan @openshift-cherrypick-robot @awgreene @openshift-bot @openshift-merge-robot