Skip to content

[release-4.9] Bug 2015799: Introduce GRPC_PROXY EnvVar Support (#2364)#207

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.9from
openshift-cherrypick-robot:cherry-pick-206-to-release-4.9
Oct 25, 2021
Merged

[release-4.9] Bug 2015799: Introduce GRPC_PROXY EnvVar Support (#2364)#207
openshift-merge-robot merged 1 commit intoopenshift:release-4.9from
openshift-cherrypick-robot:cherry-pick-206-to-release-4.9

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

This is an automated cherry-pick of #206

/assign timflannagan

Introduce the ability to specify a dial context for GRPC connections.

Signed-off-by: Alexander Greene <greene.al1991@gmail.com>

Upstream-repository: operator-lifecycle-manager
Upstream-commit: afc0848d102ecdc01a0b0f3b55d389bb66acf168
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 20, 2021

@openshift-cherrypick-robot: Bugzilla bug 2011927 has been cloned as Bugzilla bug 2015799. Retitling PR to link against new bug.
/retitle [release-4.9] Bug 2015799: Introduce GRPC_PROXY EnvVar Support (#2364)

Details

In response to this:

[release-4.9] Bug 2011927: Introduce GRPC_PROXY EnvVar Support (#2364)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot changed the title [release-4.9] Bug 2011927: Introduce GRPC_PROXY EnvVar Support (#2364) [release-4.9] Bug 2015799: Introduce GRPC_PROXY EnvVar Support (#2364) Oct 20, 2021
@openshift-ci openshift-ci Bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 20, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 20, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2015799, which is invalid:

  • expected dependent Bugzilla bug 2011927 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.9] Bug 2015799: Introduce GRPC_PROXY EnvVar Support (#2364)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@awgreene
Copy link
Copy Markdown
Contributor

/retest

1 similar comment
@awgreene
Copy link
Copy Markdown
Contributor

/retest

@awgreene
Copy link
Copy Markdown
Contributor

/bugzilla refresh

1 similar comment
@awgreene
Copy link
Copy Markdown
Contributor

/bugzilla refresh

@openshift-ci openshift-ci Bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 25, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 25, 2021

@awgreene: This pull request references Bugzilla bug 2015799, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2011927 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2011927 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (kuiwang@redhat.com), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 25, 2021

@awgreene: This pull request references Bugzilla bug 2015799, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2011927 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2011927 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (kuiwang@redhat.com), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@awgreene
Copy link
Copy Markdown
Contributor

/bugzilla refresh

@openshift-ci openshift-ci Bot removed the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Oct 25, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 25, 2021

@awgreene: This pull request references Bugzilla bug 2015799, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2011927 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2011927 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (kuiwang@redhat.com), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Oct 25, 2021
@kevinrizza
Copy link
Copy Markdown
Member

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 25, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevinrizza, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2021
@kevinrizza
Copy link
Copy Markdown
Member

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 25, 2021
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2021
@tylerslaton
Copy link
Copy Markdown
Contributor

/lgtm

@estroz
Copy link
Copy Markdown

estroz commented Oct 25, 2021

/lgtm

@mrunalp mrunalp added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 25, 2021
@openshift-merge-robot openshift-merge-robot merged commit 1b22ab7 into openshift:release-4.9 Oct 25, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 25, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2015799 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.9] Bug 2015799: Introduce GRPC_PROXY EnvVar Support (#2364)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@awgreene
Copy link
Copy Markdown
Contributor

awgreene commented Nov 3, 2021

@csrwng has requested that this change be backported to release-4.8 to support the hypershift solution. Based on our conversation, it should not need to be backported any further.

/cherry-pick release-4.8

@openshift-cherrypick-robot
Copy link
Copy Markdown
Author

@awgreene: #207 failed to apply on top of branch "release-4.8":

Applying: Introduce GRPC_PROXY EnvVar Support (#2364)
Using index info to reconstruct a base tree...
M	staging/operator-lifecycle-manager/go.mod
M	vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
Auto-merging staging/operator-lifecycle-manager/go.mod
CONFLICT (content): Merge conflict in staging/operator-lifecycle-manager/go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Introduce GRPC_PROXY EnvVar Support (#2364)
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

@csrwng has requested that this change be backported to release-4.8 to support the hypershift solution. Based on our conversation, it should not need to be backported any further.

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

awgreene pushed a commit to awgreene/operator-framework-olm that referenced this pull request Feb 2, 2022
…penshift#207)

Upstream-repository: api
Upstream-commit: 319988037fc8077cb01cf75005771bc17653059a
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 1, 2022
…penshift#207)

Upstream-repository: api
Upstream-commit: 319988037fc8077cb01cf75005771bc17653059a
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 2, 2022
…penshift#207)

Upstream-repository: api
Upstream-commit: 319988037fc8077cb01cf75005771bc17653059a
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 2, 2022
…penshift#207)

Upstream-repository: api
Upstream-commit: 319988037fc8077cb01cf75005771bc17653059a
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 2, 2022
…penshift#207)

Upstream-repository: api
Upstream-commit: 319988037fc8077cb01cf75005771bc17653059a
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
…penshift#207)

Upstream-repository: api
Upstream-commit: 319988037fc8077cb01cf75005771bc17653059a
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
…penshift#207)

Upstream-repository: api
Upstream-commit: 319988037fc8077cb01cf75005771bc17653059a
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
…penshift#207)

Upstream-repository: api
Upstream-commit: 319988037fc8077cb01cf75005771bc17653059a
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
…penshift#207)

Upstream-repository: api
Upstream-commit: 319988037fc8077cb01cf75005771bc17653059a
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
…penshift#207)

Upstream-repository: api
Upstream-commit: 319988037fc8077cb01cf75005771bc17653059a
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 7, 2022
…penshift#207)

Upstream-repository: api
Upstream-commit: 319988037fc8077cb01cf75005771bc17653059a
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 7, 2022
…penshift#207)

Upstream-repository: api
Upstream-commit: 319988037fc8077cb01cf75005771bc17653059a
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 8, 2022
…penshift#207)

Upstream-repository: api
Upstream-commit: 319988037fc8077cb01cf75005771bc17653059a
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 9, 2022
…penshift#207)

Upstream-repository: api
Upstream-commit: 319988037fc8077cb01cf75005771bc17653059a
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 10, 2022
…penshift#207)

Upstream-repository: api
Upstream-commit: 319988037fc8077cb01cf75005771bc17653059a
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 10, 2022
…penshift#207)

Upstream-repository: api
Upstream-commit: 319988037fc8077cb01cf75005771bc17653059a
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 12, 2022
…penshift#207)

Upstream-repository: api
Upstream-commit: 319988037fc8077cb01cf75005771bc17653059a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants