Skip to content

[release-4.11] Bug 2117324: concurrent write bug fix#355

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.11from
openshift-cherrypick-robot:cherry-pick-337-to-release-4.11
Aug 12, 2022
Merged

[release-4.11] Bug 2117324: concurrent write bug fix#355
openshift-merge-robot merged 1 commit intoopenshift:release-4.11from
openshift-cherrypick-robot:cherry-pick-337-to-release-4.11

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot openshift-cherrypick-robot commented Aug 10, 2022

This is an automated cherry-pick of #337

/assign perdasilva

@perdasilva @awgreene
Return copy of annotations in grpcCatalogSourceDecorator (#2813)
071f4fd 
* Update catalog source pod creation to not mutate parameters

Signed-off-by: perdasilva <perdasilva@redhat.com>

* Update pkg/controller/registry/reconciler/reconciler_test.go

Co-authored-by: Alexander Greene <agreene@redhat.com>
Signed-off-by: perdasilva <perdasilva@redhat.com>

Co-authored-by: Alexander Greene <agreene@redhat.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 83e3ebf96856643286e2e3e9438352c975923858
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 10, 2022
Merged
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 10, 2022

@openshift-cherrypick-robot: Bugzilla bug 2101357 has been cloned as Bugzilla bug 2117324. Retitling PR to link against new bug.
/retitle [release-4.11] Bug 2117324: concurrent write bug fix

Details

In response to this:

[release-4.11] Bug 2101357: concurrent write bug fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot changed the title [release-4.11] Bug 2101357: concurrent write bug fix [release-4.11] Bug 2117324: concurrent write bug fix Aug 10, 2022
@openshift-ci openshift-ci Bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 10, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 10, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2117324, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2101357 is in the state VERIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 2101357 targets the "4.12.0" release, which is one of the valid target releases: 4.12.0
  • bug has dependents

Requesting review from QA contact:
/cc @jianzhangbjz

Details

In response to this:

[release-4.11] Bug 2117324: concurrent write bug fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@perdasilva
Copy link
Copy Markdown
Contributor

perdasilva commented Aug 10, 2022

/retest

@jianzhangbjz
Copy link
Copy Markdown
Contributor

jianzhangbjz commented Aug 11, 2022

/label qe-approved
/label cherry-pick-approved

@openshift-ci openshift-ci Bot added qe-approved Signifies that QE has signed off on this PR cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Aug 11, 2022
@perdasilva
Copy link
Copy Markdown
Contributor

perdasilva commented Aug 11, 2022

/backport-risk-assessed

@perdasilva
Copy link
Copy Markdown
Contributor

perdasilva commented Aug 11, 2022

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 11, 2022
dinhxuanvu
dinhxuanvu approved these changes Aug 11, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2022
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 11, 2022

/retest-required

Remaining retests: 2 against base HEAD bbcb7cf and 8 for PR HEAD 071f4fd in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 11, 2022

/retest-required

Remaining retests: 1 against base HEAD bbcb7cf and 7 for PR HEAD 071f4fd in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 11, 2022

/retest-required

Remaining retests: 0 against base HEAD bbcb7cf and 6 for PR HEAD 071f4fd in total

@perdasilva
Copy link
Copy Markdown
Contributor

perdasilva commented Aug 12, 2022

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 12, 2022

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-olm-flaky 071f4fd link false /test e2e-gcp-olm-flaky

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 8e85433 into openshift:release-4.11 Aug 12, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 12, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2117324 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.11] Bug 2117324: concurrent write bug fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@perdasilva
Copy link
Copy Markdown
Contributor

perdasilva commented Nov 25, 2022

/cherry-pick release-4.10

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 25, 2022
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown
Author

openshift-cherrypick-robot commented Nov 25, 2022

@perdasilva: new pull request created: #415

Details

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jianzhangbjz jianzhangbjz Awaiting requested review from jianzhangbjz

@exdx exdx Awaiting requested review from exdx

@joelanford joelanford Awaiting requested review from joelanford

1 more reviewer

@dinhxuanvu dinhxuanvu dinhxuanvu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@perdasilva perdasilva

@dinhxuanvu dinhxuanvu

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@openshift-cherrypick-robot @perdasilva @jianzhangbjz @openshift-ci-robot @dinhxuanvu @openshift-merge-robot