Skip to content

[release-4.10] OCPBUGS-4128: concurrent write bug fix#415

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.10from
openshift-cherrypick-robot:cherry-pick-355-to-release-4.10
Dec 14, 2022
Merged

[release-4.10] OCPBUGS-4128: concurrent write bug fix#415
openshift-merge-robot merged 1 commit intoopenshift:release-4.10from
openshift-cherrypick-robot:cherry-pick-355-to-release-4.10

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

This is an automated cherry-pick of #355

/assign perdasilva

* Update catalog source pod creation to not mutate parameters

Signed-off-by: perdasilva <perdasilva@redhat.com>

* Update pkg/controller/registry/reconciler/reconciler_test.go

Co-authored-by: Alexander Greene <agreene@redhat.com>
Signed-off-by: perdasilva <perdasilva@redhat.com>

Co-authored-by: Alexander Greene <agreene@redhat.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 83e3ebf96856643286e2e3e9438352c975923858
@openshift-ci-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot: Bugzilla Bug 2117324 has been cloned as Jira Issue OCPBUGS-4128. Retitling PR to link against new bug.
/retitle [release-4.10] OCPBUGS-4128: concurrent write bug fix

Details

In response to this:

This is an automated cherry-pick of #355

/assign perdasilva

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 25, 2022

@openshift-cherrypick-robot: An error was encountered cloning bug for cherrypick for bug 2117324 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. code 106: Sorry, entering a bug into the product OpenShift Container Platform has been disabled.

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.10] Bug 2117324: concurrent write bug fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot changed the title [release-4.10] Bug 2117324: concurrent write bug fix [release-4.10] OCPBUGS-4128: concurrent write bug fix Nov 25, 2022
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Nov 25, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 25, 2022

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.10] OCPBUGS-4128: concurrent write bug fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-4128, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.10.z) matches configured target version for branch (4.10.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Bugzilla Bug 2117324 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Bugzilla Bug 2117324 targets the "4.11.z" version, which is one of the valid target versions: 4.11.0, 4.11.z
  • bug has dependents

Requesting review from QA contact:
/cc @jianzhangbjz

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #355

/assign perdasilva

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 25, 2022
@perdasilva
Copy link
Copy Markdown
Contributor

/retest

1 similar comment
@perdasilva
Copy link
Copy Markdown
Contributor

/retest

@jianzhangbjz
Copy link
Copy Markdown
Contributor

LGTM, details: https://issues.redhat.com/browse/OCPBUGS-4128
/lgtm
/cherry-pick-approved

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2022
@jianzhangbjz
Copy link
Copy Markdown
Contributor

/cherry-pick-approved

@jianzhangbjz
Copy link
Copy Markdown
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 28, 2022
@perdasilva
Copy link
Copy Markdown
Contributor

/retest

7 similar comments
@awgreene
Copy link
Copy Markdown
Contributor

/retest

@perdasilva
Copy link
Copy Markdown
Contributor

/retest

@perdasilva
Copy link
Copy Markdown
Contributor

/retest

@awgreene
Copy link
Copy Markdown
Contributor

awgreene commented Dec 2, 2022

/retest

@jianzhangbjz
Copy link
Copy Markdown
Contributor

/retest

@perdasilva
Copy link
Copy Markdown
Contributor

/retest

@perdasilva
Copy link
Copy Markdown
Contributor

/retest

@perdasilva
Copy link
Copy Markdown
Contributor

/backport-risk-assessed

@perdasilva
Copy link
Copy Markdown
Contributor

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2022
@perdasilva
Copy link
Copy Markdown
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Dec 8, 2022
@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 7837ef2 and 2 for PR HEAD d84caad in total

@awgreene
Copy link
Copy Markdown
Contributor

awgreene commented Dec 10, 2022

I spun up the console tests and found that the test is failing because the operator they search for, Red Hat Integration - 3scale - Managed Application Services doesn't seem to exist in 4.10, causing the operator-install-single-namespace.spec.ts test to fail:
image

image

This test worked if I got rid of - Managed Application Services:
image

I should note that the uninstallation of the operator didn't seem to start at any point.

@anik120
Copy link
Copy Markdown
Contributor

anik120 commented Dec 14, 2022

This is breaking a lot of our customers' operator upgrades/installations, and needs to be available in the latest possible 4.10.z. Based off of the comment from Alex above, I'm overriding the console test so that we can get this in.

/override e2e-aws-console-olm

@anik120
Copy link
Copy Markdown
Contributor

anik120 commented Dec 14, 2022

/override ci/prow/e2e-aws-console-olm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 14, 2022

@anik120: Overrode contexts on behalf of anik120: ci/prow/e2e-aws-console-olm

Details

In response to this:

/override ci/prow/e2e-aws-console-olm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 14, 2022

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 41c8838 into openshift:release-4.10 Dec 14, 2022
@openshift-ci-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-4128 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #355

/assign perdasilva

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants