Skip to content

update CSV copy watching all namespaces case#477

Closed
jianzhangbjz wants to merge 1 commit intoopenshift:masterfrom
jianzhangbjz:test
Closed

update CSV copy watching all namespaces case#477
jianzhangbjz wants to merge 1 commit intoopenshift:masterfrom
jianzhangbjz:test

Conversation

@jianzhangbjz
Copy link
Copy Markdown
Contributor

@jianzhangbjz jianzhangbjz commented Mar 27, 2023

The case CSV copy watching all namespaces updated the global-operators of openshift-operators to signalNamespace to watch if other namespaces' CSV is removed, but this global-operators configmap will be recover by CVO evey 15 mins, it will lead case failure sometime. In this PR, we used a ConfigMap called global-operators to watch all namespaces in a newly created namespace.
Address #368 (comment)

@openshift-ci openshift-ci Bot requested review from anik120 and ankitathomas March 27, 2023 10:35
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 27, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jianzhangbjz
Once this PR has been reviewed and has the lgtm label, please assign dinhxuanvu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jianzhangbjz
Copy link
Copy Markdown
Contributor Author

/retest

@jianzhangbjz
Copy link
Copy Markdown
Contributor Author

@jianzhangbjz
Copy link
Copy Markdown
Contributor Author

jianzhangbjz commented Mar 28, 2023

Failed at:

staging/operator-lifecycle-manager/test/e2e/operator_groups_e2e_test.go
[2023-03-28T01:10:25+0000]: only staging commits (i.e. from an upstream cherry-pick) may change staging
make[1]: *** [Makefile:162: verify-commits] Error 1
make[1]: Leaving directory '/go/src/github.com/openshift/operator-framework-olm'
make: *** [Makefile:173: verify] Error 2

Report an upstream fix PR here: operator-framework/operator-lifecycle-manager#2946

@jianzhangbjz
Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-ovn

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 28, 2023

@jianzhangbjz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify d8c1fb8 link true /test verify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Copy Markdown
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 26, 2023
@perdasilva
Copy link
Copy Markdown
Contributor

@jianzhangbjz we need to downstream the upstream commit using the sync scripts. I'll close this for now, until the upstream commit gets merged.

@perdasilva
Copy link
Copy Markdown
Contributor

/close

@openshift-ci openshift-ci Bot closed this Jul 17, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 17, 2023

@perdasilva: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot pushed a commit to openshift-bot/operator-framework-olm that referenced this pull request Feb 27, 2026
…penshift#477)

Use openapi-gen from k8s.io/kube-openapi to generate OpenAPIModelName()
accessor functions and OpenAPI schema definitions.

* Add openapi-gen to bingo.
* add +k8s:openapi-gen and +k8s:openapi-model-package markers to pkg/operators/v1alpha1 and pkg/lib/version.
* Add a generate-openapi Makefile target.
* Remove broken empty +patchMergeKey tag from SubscriptionStatus.CatalogHealth that blocked generation.

Assisted-By: Claude

Signed-off-by: Todd Short <todd.short@me.com>
Upstream-repository: api
Upstream-commit: 7641ce3927be5fafc063561ac0c51e570c222c4c
openshift-bot pushed a commit to openshift-bot/operator-framework-olm that referenced this pull request Feb 27, 2026
…penshift#477)

Use openapi-gen from k8s.io/kube-openapi to generate OpenAPIModelName()
accessor functions and OpenAPI schema definitions.

* Add openapi-gen to bingo.
* add +k8s:openapi-gen and +k8s:openapi-model-package markers to pkg/operators/v1alpha1 and pkg/lib/version.
* Add a generate-openapi Makefile target.
* Remove broken empty +patchMergeKey tag from SubscriptionStatus.CatalogHealth that blocked generation.

Assisted-By: Claude

Signed-off-by: Todd Short <todd.short@me.com>
Upstream-repository: api
Upstream-commit: 7641ce3927be5fafc063561ac0c51e570c222c4c
openshift-bot pushed a commit to openshift-bot/operator-framework-olm that referenced this pull request Mar 3, 2026
…penshift#477)

Use openapi-gen from k8s.io/kube-openapi to generate OpenAPIModelName()
accessor functions and OpenAPI schema definitions.

* Add openapi-gen to bingo.
* add +k8s:openapi-gen and +k8s:openapi-model-package markers to pkg/operators/v1alpha1 and pkg/lib/version.
* Add a generate-openapi Makefile target.
* Remove broken empty +patchMergeKey tag from SubscriptionStatus.CatalogHealth that blocked generation.

Assisted-By: Claude

Signed-off-by: Todd Short <todd.short@me.com>
Upstream-repository: api
Upstream-commit: 7641ce3927be5fafc063561ac0c51e570c222c4c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants