Skip to content

update 'CSV copy watching all namespaces' case#2946

Closed
jianzhangbjz wants to merge 1 commit intooperator-framework:masterfrom
jianzhangbjz:test
Closed

update 'CSV copy watching all namespaces' case#2946
jianzhangbjz wants to merge 1 commit intooperator-framework:masterfrom
jianzhangbjz:test

Conversation

@jianzhangbjz
Copy link
Copy Markdown
Contributor

The CSV copy watching all namespaces case updated the global-operators ConfigMap of openshift-operators to signalNamespace to watch if other namespaces' CSV is removed, but this global-operators ConfigMap will be recovered by CVO every 15 mins, it will lead case failure sometime. In this PR, we used a ConfigMap called global-operators to watch all namespaces in a newly created namespace.
Addressed openshift/operator-framework-olm#368 (comment)

@jianzhangbjz
Copy link
Copy Markdown
Contributor Author

/approve
/lgtm

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 29, 2023

@jianzhangbjz: you cannot LGTM your own PR.

Details

In response to this:

/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jianzhangbjz
Copy link
Copy Markdown
Contributor Author

jianzhangbjz commented Mar 29, 2023

Hi @perdasilva @awgreene, could you help approve it? Thanks!
/assign @perdasilva @awgreene

@jianzhangbjz
Copy link
Copy Markdown
Contributor Author

Hi @awgreene , could you help have a review when you get a chance? Thanks!
/assign @awgreene

Copy link
Copy Markdown
Collaborator

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jul 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianzhangbjz, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2023
@perdasilva perdasilva force-pushed the test branch 2 times, most recently from 7976e6d to 39e5d8e Compare July 25, 2023 11:45
Signed-off-by: Jian Zhang <jiazha@redhat.com>
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 8, 2023
@openshift-merge-robot
Copy link
Copy Markdown
Collaborator

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@awgreene
Copy link
Copy Markdown
Member

No longer necessary given #3042

@awgreene awgreene closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants