Skip to content

*: sync upstream#547

Closed
stevekuznetsov wants to merge 6 commits intoopenshift:masterfrom
stevekuznetsov:skuznets/sync-1692194279
Closed

*: sync upstream#547
stevekuznetsov wants to merge 6 commits intoopenshift:masterfrom
stevekuznetsov:skuznets/sync-1692194279

Conversation

@stevekuznetsov
Copy link
Copy Markdown
Contributor

@stevekuznetsov stevekuznetsov commented Aug 16, 2023

No description provided.

stevekuznetsov and others added 5 commits August 16, 2023 08:07
@stevekuznetsov
bumper: add a gitignore
c0164ae 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@tmshort @stevekuznetsov
Add tmshort to reviewers (#3008)
469482a 
Signed-off-by: Todd Short <todd.short@me.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: ad4ac77284454a077ecccfc6740f180bbb58e6f4
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@grokspawn @stevekuznetsov
[chore] bump containerd to 1.6.22 (openshift#1134)
5e1a064 
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
Upstream-repository: operator-registry
Upstream-commit: dba1e1052875cbf3850058120c8eb7a1c8a5d11c
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@tmshort @stevekuznetsov
[chore] Update github.com/emicklei/go-restful/v3 to v3.10.2 (openshif…
4400c5b 
…t#1136)

Fixes path join issue

Signed-off-by: Todd Short <todd.short@me.com>
Upstream-repository: operator-registry
Upstream-commit: 7f37952d54699439d27e0dc27c1a5778cdb101ec
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@tmshort @stevekuznetsov
[chore] Update github.com/emicklei/go-restful/v3 to v3.10.2 (openshif…
46536b8 
…t#290)

Fixes path join issue

Signed-off-by: Todd Short <todd.short@me.com>
Upstream-repository: api
Upstream-commit: 775e6c6534b89dde01826627ceb570c16ab6768f
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@openshift-ci openshift-ci Bot requested review from awgreene and kevinrizza August 16, 2023 14:14
@tmshort
Copy link
Copy Markdown
Contributor

tmshort commented Aug 16, 2023

Can we wait until operator-framework/operator-lifecycle-manager#3011 lands? It's also a go-restful update. Get all three in at the same time.

@tmshort
Copy link
Copy Markdown
Contributor

tmshort commented Aug 16, 2023

Can we wait until operator-framework/operator-lifecycle-manager#3011 lands? It's also a go-restful update. Get all three in at the same time.

And... it's merged...

@tmshort @stevekuznetsov
[chore] Update github.com/emicklei/go-restful/v3 to v3.10.2 (#3011)
2805e37 
Fixes path join issue

Signed-off-by: Todd Short <todd.short@me.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: a827c02a0530c0b0532630662dda423773cc5ed9
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
Copy link
Copy Markdown
Contributor Author

stevekuznetsov commented Aug 16, 2023

Updated :)

@tmshort
Copy link
Copy Markdown
Contributor

tmshort commented Aug 16, 2023

/approved
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2023
@stevekuznetsov
Copy link
Copy Markdown
Contributor Author

stevekuznetsov commented Aug 16, 2023

/retest

2 similar comments
@stevekuznetsov
Copy link
Copy Markdown
Contributor Author

stevekuznetsov commented Aug 16, 2023

/retest

@stevekuznetsov
Copy link
Copy Markdown
Contributor Author

stevekuznetsov commented Aug 17, 2023

/retest

@stevekuznetsov
Copy link
Copy Markdown
Contributor Author

stevekuznetsov commented Aug 17, 2023

/retest

... never the same failure twice, huh

@stevekuznetsov
Copy link
Copy Markdown
Contributor Author

stevekuznetsov commented Aug 17, 2023

/test e2e-gcp-olm

@stevekuznetsov stevekuznetsov mentioned this pull request Aug 17, 2023
Closed
@tmshort
Copy link
Copy Markdown
Contributor

tmshort commented Aug 17, 2023

Not sure why the .gitignore commit is in here?

@stevekuznetsov
Copy link
Copy Markdown
Contributor Author

stevekuznetsov commented Aug 17, 2023

@tmshort I had the built binary on my system when creating this branch and didn't want to commit it. Should be harmless ... ?

@tmshort
Copy link
Copy Markdown
Contributor

tmshort commented Aug 17, 2023

/retest

2 similar comments
@stevekuznetsov
Copy link
Copy Markdown
Contributor Author

stevekuznetsov commented Aug 18, 2023

/retest

@stevekuznetsov
Copy link
Copy Markdown
Contributor Author

stevekuznetsov commented Aug 21, 2023

/retest

@awgreene
Copy link
Copy Markdown
Contributor

awgreene commented Aug 21, 2023

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2023
@stevekuznetsov
Copy link
Copy Markdown
Contributor Author

stevekuznetsov commented Aug 22, 2023

/retest

1 similar comment
@stevekuznetsov
Copy link
Copy Markdown
Contributor Author

stevekuznetsov commented Aug 22, 2023

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 22, 2023

@stevekuznetsov: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ncdc ncdc mentioned this pull request Aug 24, 2023
Closed
@stevekuznetsov
Copy link
Copy Markdown
Contributor Author

stevekuznetsov commented Sep 9, 2023

Superseded by #562

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@awgreene awgreene Awaiting requested review from awgreene

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

Assignees

@tmshort tmshort

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stevekuznetsov @tmshort @awgreene @grokspawn