OCPBUGS-35373: [release-4.16] Warn and allow CRD upgrade if validation fails but webhook is specified by everettraven · Pull Request #781 · openshift/operator-framework-olm

everettraven · 2024-06-12T20:20:49Z

Cherry pick of b017f92 to 4.16

… CRD specifies a conversion strategy (#3209) * warn but allow CRD upgrade when validations fail but new CRD has conversion strategy Signed-off-by: everettraven <everettraven@gmail.com> * unexport validationError Signed-off-by: everettraven <everettraven@gmail.com> * updating warning message to be more descriptive, add warning event on installplan Signed-off-by: everettraven <everettraven@gmail.com> * update warning templ per review comments Signed-off-by: everettraven <everettraven@gmail.com> --------- Signed-off-by: everettraven <everettraven@gmail.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: c3e17741c5dde8d67203a9e34bba81c4ad2bddcd

everettraven · 2024-06-12T20:25:03Z

/retitle OCPBUGS-35373: [release-4.16] Warn and allow CRD upgrade if validation fails but webhook is specified

openshift-ci-robot · 2024-06-12T20:25:12Z

@everettraven: This pull request references Jira Issue OCPBUGS-35373, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
expected dependent Jira Issue OCPBUGS-31522 to target a version in 4.17.0, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Cherry pick of b017f92 to 4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

everettraven · 2024-06-12T20:26:14Z

/jira refresh

openshift-ci-robot · 2024-06-12T20:26:18Z

@everettraven: This pull request references Jira Issue OCPBUGS-35373, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

everettraven · 2024-06-12T20:31:41Z

/jira refresh

openshift-ci-robot · 2024-06-12T20:31:48Z

@everettraven: This pull request references Jira Issue OCPBUGS-35373, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.0) matches configured target version for branch (4.16.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-31522 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-31522 targets the "4.17.0" version, which is one of the valid target versions: 4.17.0
bug has dependents

Requesting review from QA contact:
/cc @Xia-Zhao-rh

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Xia-Zhao-rh · 2024-06-13T13:13:38Z

/label qe-approved

openshift-ci-robot · 2024-06-13T13:13:46Z

@everettraven: This pull request references Jira Issue OCPBUGS-35373, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.0) matches configured target version for branch (4.16.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-31522 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-31522 targets the "4.17.0" version, which is one of the valid target versions: 4.17.0
bug has dependents

Requesting review from QA contact:
/cc @Xia-Zhao-rh

Details

In response to this:

Cherry pick of b017f92 to 4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

everettraven · 2024-06-13T13:25:31Z

/retest

sferich888 · 2024-06-13T13:40:45Z

/cherry-pick release-4.15

openshift-cherrypick-robot · 2024-06-13T13:40:48Z

@sferich888: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

everettraven · 2024-06-13T17:21:59Z

/retest

openshift-ci · 2024-06-13T20:27:45Z

@everettraven: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

perdasilva · 2024-06-14T11:36:59Z

/label backport-risk-assessed

perdasilva · 2024-06-14T14:28:24Z

/lgtm

perdasilva · 2024-06-14T14:28:42Z

/label approved

openshift-ci · 2024-06-14T14:29:04Z

@perdasilva: Can not set label approved: Must be member in one of these teams: [openshift-release-oversight openshift-staff-engineers]

Details

In response to this:

/label approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

joelanford · 2024-06-14T15:37:43Z

/approve

openshift-ci · 2024-06-14T15:39:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~DOWNSTREAM_OWNERS~~ [joelanford]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Xia-Zhao-rh · 2024-06-18T05:05:24Z

/label cherry-pick-approved

openshift-ci-robot · 2024-06-18T05:10:21Z

@everettraven: Jira Issue OCPBUGS-35373: All pull requests linked via external trackers have merged:

openshift/operator-framework-olm#781

Jira Issue OCPBUGS-35373 has been moved to the MODIFIED state.

Details

In response to this:

Cherry pick of b017f92 to 4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot · 2024-06-18T05:11:11Z

@sferich888: new pull request created: #789

Details

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-bot · 2024-06-18T06:55:04Z

[ART PR BUILD NOTIFIER]

This PR has been included in build operator-lifecycle-manager-container-v4.16.0-202406180607.p0.g66ef61a.assembly.stream.el9 for distgit operator-lifecycle-manager.
All builds following this will include this PR.

openshift-merge-robot · 2024-06-18T19:01:55Z

Fix included in accepted release 4.16.0-0.nightly-2024-06-18-130927

openshift-ci Bot requested review from anik120 and kevinrizza June 12, 2024 20:21

openshift-ci Bot changed the title ~~OCPBUGS-XXX: [release-4.16] Warn and allow CRD upgrade if validation fails but webhook is specified~~ OCPBUGS-35373: [release-4.16] Warn and allow CRD upgrade if validation fails but webhook is specified Jun 12, 2024

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 12, 2024

openshift-ci Bot requested a review from Xia-Zhao-rh June 12, 2024 20:31

openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label Jun 13, 2024

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 14, 2024

openshift-ci Bot assigned bandrade, emmajiafan, jianzhangbjz and KeenonLee Jun 14, 2024

openshift-ci Bot assigned kuiwang02 and Xia-Zhao-rh Jun 14, 2024

openshift-ci Bot assigned perdasilva Jun 14, 2024

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2024

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2024

openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 18, 2024

openshift-merge-bot Bot merged commit 66ef61a into openshift:release-4.16 Jun 18, 2024

openshift-cherrypick-robot mentioned this pull request Jun 18, 2024

[release-4.15] OCPBUGS-35720: Warn and allow CRD upgrade if validation fails but webhook is specified #789

Merged

Conversation

everettraven commented Jun 12, 2024

Uh oh!

everettraven commented Jun 12, 2024

Uh oh!

openshift-ci-robot commented Jun 12, 2024

Uh oh!

everettraven commented Jun 12, 2024

Uh oh!

openshift-ci-robot commented Jun 12, 2024

Uh oh!

everettraven commented Jun 12, 2024

Uh oh!

openshift-ci-robot commented Jun 12, 2024

Uh oh!

Xia-Zhao-rh commented Jun 13, 2024

Uh oh!

openshift-ci-robot commented Jun 13, 2024

Uh oh!

everettraven commented Jun 13, 2024

Uh oh!

sferich888 commented Jun 13, 2024

Uh oh!

openshift-cherrypick-robot commented Jun 13, 2024

Uh oh!

everettraven commented Jun 13, 2024

Uh oh!

openshift-ci Bot commented Jun 13, 2024

Uh oh!

perdasilva commented Jun 14, 2024

Uh oh!

perdasilva commented Jun 14, 2024

Uh oh!

perdasilva commented Jun 14, 2024

Uh oh!

openshift-ci Bot commented Jun 14, 2024

Uh oh!

joelanford commented Jun 14, 2024

Uh oh!

openshift-ci Bot commented Jun 14, 2024

Uh oh!

Xia-Zhao-rh commented Jun 18, 2024

Uh oh!

openshift-ci-robot commented Jun 18, 2024

Uh oh!

openshift-cherrypick-robot commented Jun 18, 2024

Uh oh!

openshift-bot commented Jun 18, 2024

Uh oh!

openshift-merge-robot commented Jun 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants