Skip to content

[release-4.15] OCPBUGS-35720: Warn and allow CRD upgrade if validation fails but webhook is specified#789

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.15from
openshift-cherrypick-robot:cherry-pick-781-to-release-4.15
Jun 19, 2024
Merged

[release-4.15] OCPBUGS-35720: Warn and allow CRD upgrade if validation fails but webhook is specified#789
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.15from
openshift-cherrypick-robot:cherry-pick-781-to-release-4.15

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jun 18, 2024

This is an automated cherry-pick of #781

/assign sferich888

@everettraven
OCPBUGS-31522: Warn and allow CRD upgrade if validation fails but new…
dc9ee11 
… CRD specifies a conversion strategy (#3209)

* warn but allow CRD upgrade when validations fail but new CRD has conversion strategy

Signed-off-by: everettraven <everettraven@gmail.com>

* unexport validationError

Signed-off-by: everettraven <everettraven@gmail.com>

* updating warning message to be more descriptive, add warning event on installplan

Signed-off-by: everettraven <everettraven@gmail.com>

* update warning templ per review comments

Signed-off-by: everettraven <everettraven@gmail.com>

---------

Signed-off-by: everettraven <everettraven@gmail.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: c3e17741c5dde8d67203a9e34bba81c4ad2bddcd
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 18, 2024
Merged
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 18, 2024

@openshift-cherrypick-robot: Jira Issue OCPBUGS-35373 has been cloned as Jira Issue OCPBUGS-35720. Will retitle bug to link to clone.
/retitle [release-4.15] OCPBUGS-35720: Warn and allow CRD upgrade if validation fails but webhook is specified

Details

In response to this:

This is an automated cherry-pick of #781

/assign sferich888

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot changed the title [release-4.15] OCPBUGS-35373: Warn and allow CRD upgrade if validation fails but webhook is specified [release-4.15] OCPBUGS-35720: Warn and allow CRD upgrade if validation fails but webhook is specified Jun 18, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 18, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 18, 2024

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-35720, which is invalid:

  • expected dependent Jira Issue OCPBUGS-35373 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead
  • expected dependent Jira Issue OCPBUGS-35373 to target a version in 4.16.0, but it targets "4.16.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #781

/assign sferich888

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from anik120 and kevinrizza June 18, 2024 05:11
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 18, 2024

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@perdasilva
Copy link
Copy Markdown
Contributor

perdasilva commented Jun 18, 2024

/label backport-risk-assessed

@perdasilva
Copy link
Copy Markdown
Contributor

perdasilva commented Jun 18, 2024

/approve

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 18, 2024
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2024
@everettraven
Copy link
Copy Markdown
Contributor

everettraven commented Jun 18, 2024

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 18, 2024

@everettraven: This pull request references Jira Issue OCPBUGS-35720, which is invalid:

  • expected dependent Jira Issue OCPBUGS-35373 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead
  • expected dependent Jira Issue OCPBUGS-35373 to target a version in 4.16.0, but it targets "4.16.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@everettraven
Copy link
Copy Markdown
Contributor

everettraven commented Jun 18, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jun 18, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 18, 2024

@everettraven: This pull request references Jira Issue OCPBUGS-35720, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-35373 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-35373 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (jiazha@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 18, 2024
everettraven
everettraven approved these changes Jun 18, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, openshift-cherrypick-robot, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Xia-Zhao-rh
Copy link
Copy Markdown
Contributor

Xia-Zhao-rh commented Jun 19, 2024

/label qe-approved

@Xia-Zhao-rh
Copy link
Copy Markdown
Contributor

Xia-Zhao-rh commented Jun 19, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label Jun 19, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 19, 2024

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-35720, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-35373 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-35373 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @Xia-Zhao-rh

Details

In response to this:

This is an automated cherry-pick of #781

/assign sferich888

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 19, 2024
@openshift-ci openshift-ci Bot requested a review from Xia-Zhao-rh June 19, 2024 08:16
@openshift-merge-bot openshift-merge-bot Bot merged commit 95839e1 into openshift:release-4.15 Jun 19, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 19, 2024

@openshift-cherrypick-robot: Jira Issue OCPBUGS-35720: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-35720 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #781

/assign sferich888

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jun 19, 2024

[ART PR BUILD NOTIFIER]

This PR has been included in build operator-lifecycle-manager-container-v4.15.0-202406190836.p0.g95839e1.assembly.stream.el9 for distgit operator-lifecycle-manager.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@everettraven everettraven everettraven approved these changes

@anik120 anik120 Awaiting requested review from anik120

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

@Xia-Zhao-rh Xia-Zhao-rh Awaiting requested review from Xia-Zhao-rh

Assignees

@bandrade bandrade

@sferich888 sferich888

@jianzhangbjz jianzhangbjz

@everettraven everettraven

@emmajiafan emmajiafan

@kuiwang02 kuiwang02

@Xia-Zhao-rh Xia-Zhao-rh

@KeenonLee KeenonLee

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.