OCPBUGS-42114: add optional schema migrations; default to olm.bundle.object instead of olm.csv.metadata#870
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grokspawn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
| // CloneAllMigrations returns a shallow copy of allMigrations | ||
| // since slices.Clone is not available in the current golang version | ||
| func CloneAllMigrations() []Migration { | ||
| return append(allMigrations[:0:0], allMigrations...) | ||
| } |
There was a problem hiding this comment.
This is a semi-kludge to replace slices.Clone() from later golang versions. Hopefully not too odious.
|
/jira cherrypick OCPBUGS-41540 |
|
@grokspawn: Jira Issue OCPBUGS-41540 has been cloned as Jira Issue OCPBUGS-42114. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@grokspawn: This pull request references Jira Issue OCPBUGS-42114, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
…of olm.csv.metadata (#1384) * Allow disabling of migrations for bundles and sqlite DBs Signed-off-by: Joe Lanford <joe.lanford@gmail.com> * intro new migrations package Signed-off-by: Joe Lanford <joe.lanford@gmail.com> * schema migration optional; default to olm.bundle.object Signed-off-by: Jordan Keister <jordan@nimblewidget.com> * review resolutions Signed-off-by: Jordan Keister <jordan@nimblewidget.com> * use a type to protect migration interactions Signed-off-by: Jordan Keister <jordan@nimblewidget.com> * review revisions Signed-off-by: Jordan Keister <jordan@nimblewidget.com> --------- Signed-off-by: Joe Lanford <joe.lanford@gmail.com> Signed-off-by: Jordan Keister <jordan@nimblewidget.com> Co-authored-by: Joe Lanford <joe.lanford@gmail.com> Upstream-repository: operator-registry Upstream-commit: c80e8751e716c069017b55279a0f29d0254d426a
grokspawn
force-pushed
the
migrations-4.15
branch
from
edbb04e to
bb2cec7
Compare
|
/retest |
|
@grokspawn: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/close Had to fix up a vendor. Done it in #874 |
|
/close |
|
@grokspawn: This pull request references Jira Issue OCPBUGS-42114. The bug has been updated to no longer refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@tmshort: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 participants
… (#1384)
Upstream-repository: operator-registry
Upstream-commit: c80e8751e716c069017b55279a0f29d0254d426a